agentleFS
asarelcastellanosasarelcastellanos/claude-workbench/skills/pr-review/SKILL.md

pr-review

Skill1 starsChanged 3 days agoMITView on GitHub

Use to review a diff or PR for real bugs. Parallel agents find bugs, separate agents verify them, and each PR gets one review before it goes to main.

195 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use oss-pr, pr-automation and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • CES-LtdSkill

    oss-pr

    Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.

    Also in 3 projects that use this

  • CES-LtdSkill

    pr-automation

    PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".

    Also in 3 projects that use this

  • jtenniswoodSkill

    expert-reset

    Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.

    Also in 3 projects that use this

  • jtenniswoodSkill

    updates

    Summarize user-facing project updates from the last 7 days, ordered by importance and written as one-sentence "Feature: description" entries. Use when the user says "/updates", asks what changed recently, or wants a concise list of recent features, device support, fixes that users will notice, or other product value.

    Also in 3 projects that use this

  • openchamberSkill

    clack-cli-patterns

    Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.

    Also in 3 projects that use this

  • openchamberSkill

    drag-to-reorder

    Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.

    Also in 3 projects that use this

  • +6 more from openchamber

The file

We split this skill into the rules it gives an agent

2 rules. 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 179 edited versions we read keep these.

  • 2

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read the intent. Read the code around the diff, including callers of changed functions.

    line 30
  2. Distinctive:

    Keep a finding only if a majority votes CONFIRMED.

    line 55

“Common” is measured: kept by at least 6 in 10 of the 179 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

PR review

The main session runs this skill and spawns every reviewer itself. A subagent can't start agents of its own, so never hand this whole skill to one agent. Each finder and verifier is a fresh-context model-policy:reviewer agent, as the model-roles skill describes. Spawn them with the Agent tool. Use a Workflow only when the user asks for one.

Catching real bugs comes first. Keeping noise out comes second. When an agent wrote the change, every nit costs another round of edits.

Inputs

Collect these before you review:

  • The diff against the base branch.
  • The intent, from the PR description, the linked issue, or what the user asked for.
  • The repo's CLAUDE.md and REVIEW.md, if they exist. REVIEW.md rules override the defaults in this skill.

Depth

Pick a depth from the risk of the change, or use the depth the user names.

  • Quick. One reviewer agent reviews in one pass, with every lens. Use it for docs, copy, and small low-risk changes.
  • Standard. Three finder agents, then one verifier per finding. This is the default.
  • Deep. Five finder agents, then three verifiers per finding. Use it for auth, billing, data migrations, CI workflows, installers, and code where one missed bug is costly.

Phase 1. Understand the change

Read the intent. Read the code around the diff, including callers of changed functions. Then answer these questions:

  • Does the change solve its stated problem?
  • Does it fit how the rest of the system works?
  • Does it break anything else?
  • For a bug fix, does it fix the root cause?

Phase 2. Find candidate bugs in parallel

Spawn the finder agents at the same time. Give each one the diff, the intent, and one lens:

  1. Logic and edge cases. Off-by-one errors, null or empty input, wrong conditions, unhandled states.
  2. Integration. Callers, contracts, and schemas that the change breaks.
  3. Errors and state. Error handling, concurrency, resource leaks, data loss, partial failure.
  4. Security. Injection, missing auth checks, leaked secrets, unsafe input. Use /security-review if it is available.
  5. Tests. Whether the tests exercise the changed behavior and would fail without the change.

Standard depth uses lenses 1 to 3. Deep depth uses all five.

Each candidate needs a file and line, the defect in one sentence, and a concrete failure scenario. A failure scenario names an input or state and the wrong result it produces. A guess from a function name is not evidence. The finder must read the code.

Phase 3. Verify

Merge duplicate candidates first. Then, for each candidate, spawn verifier agents with fresh context. Give them the finding and access to the code. Do not give them the finder's reasoning. Each verifier votes CONFIRMED, REFUTED, or UNSURE with a one-line reason.

Keep a finding only if a majority votes CONFIRMED. With one verifier, keep it only if that verifier votes CONFIRMED.

Drop style, formatting, naming, and cleanup suggestions unless REVIEW.md asks for them.

Phase 4. Tag

Tag each finding that survived:

  • Important. A real bug or risk the author should fix before merge.
  • Nit. Minor and safe to skip. Report three at most.
  • Pre-existing. A real bug in code this change did not introduce. Never blame the author for it.

Sometimes several findings are the same kind of mistake. Report that mistake once as a bug class and list every instance. The author can then fix all of them in one pass.

Phase 5. Report

Open with the count, for example "2 important, 1 nit, 1 pre-existing." If nothing survived, write "No issues found. Nothing needs fixing." and stop.

List the findings sorted by severity. For each one, give the tag, the file and line, the defect, the failure scenario, and a suggested fix.

One review per PR

A change gets one review, on the full diff, just before the PR into the default branch. Fixes for its findings go into the PR's existing commits and rerun the checks, not the review. The one exception is a finding that shows the approach was wrong, or a fix that grows past the size limit or leaves the reviewed diff, as step 6 of ship-a-change sets out. Review again only when the user asks, for example after a fix that changed the approach. A second review covers only what changed since the first and never repeats an earlier finding.

If the repo has no REVIEW.md

Offer to draft one. A good REVIEW.md is short. It covers these points:

  • What failure looks like in this repo, for example "the API returns wrong totals."
  • Paths to skip, such as generated code or vendored files.
  • Paths that always need a person, such as auth, billing, and CI workflows.
  • The nit cap.
  • A rule that every finding needs a file and line.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.