Repository conventions for codereview
This is the companion code repository for *Machine Learning for Trading, 3rd Edition*.
The conventions below are deliberate and repository-wide. Please do not flag
No other project uses it yet
22k36d agoReviewMountCreate a free account to mount
Style & Readability
- Write readable, understandable, and maintainable code.
- Prioritize clarity and adhere to coding standards.
- Regularly review and refactor code for structure and maintainability.
- Use version control
No other project uses it yet
21k4y agoReviewMountCreate a free account to mount
Checklist](https://docs.qmk.fm/pr_checklist) and it is intended only for use by GitHub Copilot code-review agent during pull request reviews.
> **Scope**: This review applies **only to changes within
No other project uses it yet
21k21mo agoReviewMountCreate a free account to mount
github/skills/ /SKILL.md` and are auto-discovered by their YAML `description`. Useful ones here include `code-review`, `ci-analysis`, `analyzer-codefix`, `merge-into-branch`, `snap`, and `update-agent-docs`.
## Working Loop
No other project uses it yet
21k8mo agoReviewMountCreate a free account to mount
match. Invoke a named skill rather than assuming what it says.
Use the `code-review` skill when reviewing pull requests, and — when running under CCA — on your own changes before
No other project uses it yet
18k2y agoReviewMountCreate a free account to mount
Instructions
## Codereview
You are a pragmatic senior developer. When reviewing pull requests,
follow these rules to avoid noise and redundancy:
- Be concise: Keep comments brief and to the point
1 project uses a version of this
17k2mo agoReviewMountCreate a free account to mount
this repository are in `AGENTS.md` at the
repository root. Copilot cloud agent, Copilot codereview and the IDE agents load that file
directly; this file only covers the Copilot features
No other project uses it yet
17k6mo agoReviewMountCreate a free account to mount
When reviewing PRs, address general codereview criteria, but also specifically the following questions: What is it trying to do? Is it correct? Are there bugs? Are there omissions
No other project uses it yet
17k6mo agoReviewMountCreate a free account to mount
Copilot CodeReview
See [AGENTS.md](../AGENTS.md) for layout, architecture, and conventions. These notes cover review.
## Priorities
Report correctness problems first, then missing test coverage, then documentation that contradicts
the code
Steady2 mentions in 2 weeks
No other project uses it yet
16k4y agoReviewMountCreate a free account to mount
CI/CD pipelines. Existing behaviour must not change disruptively. Use UK English spelling.
## Backward-compatibility review (highest priority)
For every PR, check whether existing behaviour changes. Treat the following as potential
Steady2 mentions in 2 weeks
No other project uses it yet
16k11mo agoReviewMountCreate a free account to mount
words, short sentences, third-person self-reference ("grug").
Core grug beliefs to apply when reviewing:
- Complexity very, very bad. Flag any complexity demon spirit entering codebase.
Say so plainly: "complexity
Steady3 mentions in 2 weeks
No other project uses it yet
16k6y agoReviewMountCreate a free account to mount
Test Philosophy
- Performance matters. Tests should run as quickly as possible. Sleeps in the code are highly discouraged and should be avoided, to reduce run time and flakiness.
- Stability matters
No other project uses it yet
16k19mo agoReviewMountCreate a free account to mount
pyright`), an LSP language server (`pyright-langserver`), and a VS Code extension (`vscode-pyright`).
## Issue Agents
Use `pyright-issue-reviewer` to investigate an issue and draft a maintainer response without
No other project uses it yet
16k8d agoReviewMountCreate a free account to mount
coding agent in this repository, apply the project guidance in `.github/skills/subtitleedit-ai-contributor-guidelines/SKILL.md` for code changes, reviews, refactors, and documentation updates.
Keep AI-assisted changes small, verified, and tied directly
Steady3 mentions in 2 weeks
No other project uses it yet
15k6mo agoReviewMountCreate a free account to mount
filter-method "*ModelBuilderTest.Some_test"
```
`test\Directory.Build.props` adds `--filter-not-trait category=failing --ignore-exit-code 8`. Do not add `--no-build` unless the test assembly was built immediately beforehand
No other project uses it yet
15k9d agoReviewMountCreate a free account to mount
agents/skills`, and `.claude/skills` so coding agents do not auto-discover them.
- When a change affects public APIs, packages, samples, configuration, evaluation, integrations, or hosting guidance,
review and update the corresponding
Steady11 mentions in 2 weeks
No other project uses it yet
15k23d agoReviewMountCreate a free account to mount
General CodeReview Standards
## Review Priorities
- Prioritize correctness, regressions, missing tests, and API design issues.
- Check that the behavior scope matches the stated intent.
- Verify claims about external standards, platform
Steady2 mentions in 2 weeks
No other project uses it yet
15k4y agoReviewMountCreate a free account to mount
user-facing strings must be localized; no hardcoded English text in code.
- Error codes should be namespaced: `ModuleName:ErrorCode` (e.g., `Identity:UserNameAlreadyExists`).
---
## Settings & Features
- Define settings in `*SettingDefinitionProvider` in Domain.Shared
No other project uses it yet
14k8mo agoReviewMountCreate a free account to mount
Codereview guidelines
Repository layout, commands, and coding conventions are documented in
[`AGENTS.md`](../AGENTS.md) and the per-package `AGENTS.md` files under `packages/`.
Read those for context; this file covers only
No other project uses it yet
14k2mo agoReviewMountCreate a free account to mount
applyTo:
- "**/*.py"
- "**/*.md"
- "**/*.rst"
- "**/*.txt"
- "**/*.html"
- "**/*.css"
- "**/*.toml"
- "**/*.yaml"
- "**/*.ini"
---
Do not review this code. Do not post any comments, suggestions, or feedback.
Do not summarize the pull request
No other project uses it yet
13k6d agoReviewMountCreate a free account to mount