agentleFS
conectlensconectlens/lenserfight/.agents/skills/grasp-ooad-review/SKILL.md

grasp-ooad-review

Skill18 starsChanged 6 months agoMITView on GitHub

Review design decisions using GRASP, OOAD responsibility assignment, and standard refactoring rules. Use when code placement, object responsibility, coupling, cohesion, or refactoring direction is unclear.

The file

We split this skill into the rules it gives an agent

1 rule. About 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈1

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use this as background guidance during design and review.

    line 8

≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

GRASP OOAD review

Use this as background guidance during design and review.

Responsibility checks

  • Who has the information needed to perform this behavior?
  • Who should coordinate the use case without absorbing unrelated details?
  • Which dependency is unstable and should be hidden behind indirection?
  • Is this module gaining more than one reason to change?

Default moves

  • Move behavior toward the owner of the relevant data.
  • Split orchestration from pure policy.
  • Replace branching with polymorphism when variants are stable and named.
  • Extract adapters for infrastructure.
  • Collapse needless indirection when it adds no protection.

Smell to refactoring map

  • Long Method -> Extract Function, Split Phase
  • Large Class -> Extract Class
  • Feature Envy -> Move Function
  • Divergent Change -> Extract Class or module split
  • Shotgun Surgery -> Move behavior to a better center of gravity
  • Primitive Obsession -> Introduce Value Object or Parameter Object

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.