agentleFS
a-lottesa-lottes/aSPARK/skills/peer-review/SKILL.md

peer-review

Skill25 starsChanged 3 months agoMITView on GitHub

Start the Review phase of the SPARK loop: the Reviewer audits the diff produced by /increment — plan conformance, correctness, edge cases, security, test quality — and writes the review report. Use after /increment reports done, or to re-review after fixes.

47 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use usfiscaldata, research-grants and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • yf8578Skill

    usfiscaldata

    Query the U.S. Treasury Fiscal Data API for federal financial data including national debt, government spending, revenue, interest rates, exchange rates, and savings bonds. Access 54 datasets and 182 data tables with no API key required. Use when working with U.S. federal fiscal data, national debt tracking (Debt to the Penny), Daily Treasury Statements, Monthly Treasury Statements, Treasury securities auctions, interest rates on Treasury securities, foreign exchange rates, savings bonds, or any U.S. government financial statistics.

    Also in 7 projects that use this

  • garri333Skill

    research-grants

    Write competitive research proposals for NSF, NIH, DOE, DARPA, and Taiwan NSTC. Agency-specific formatting, review criteria, budget preparation, broader impacts, significance statements, innovation narratives, and compliance with submission requirements.

    Also in 11 projects that use this

  • garri333Skill

    arboreto

    Infer gene regulatory networks (GRNs) from gene expression data using scalable algorithms (GRNBoost2, GENIE3). Use when analyzing transcriptomics data (bulk RNA-seq, single-cell RNA-seq) to identify transcription factor-target gene relationships and regulatory interactions. Supports distributed computation for large-scale datasets.

    Also in 10 projects that use this

  • SoljournerSkill

    get-available-resources

    Enumerate installed packages, databases, and tools for engineering workflows

    Also in 10 projects that use this

  • +8 more from garri333

The file

We split this skill into the rules it gives an agent

7 rules. 0 are common, 2 are distinctive, and 5 are very specific to this project.

  • 0

    Common

    Most of the 38 edited versions we read keep these.

  • 2

    Distinctive

    This author's own choices. Worth a look.

  • 5

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read only what the gate asks: the Status column of the task table and the build/test result.

    line 24
  2. Very specific:

    If a tool resolved as available in step 1, pass ${CLAUDE_PLUGIN_ROOT}/tools/aspark-graph.md the same way — one more path alongside the lens …

    line 53
  3. Very specific:

    Always also pass ${CLAUDE_PLUGIN_ROOT}/standards/anti-generosity.md, by this literal path: no constitution read, no flag.

    line 56
  4. Very specific:

    Close the gate: When the REVIEW GATE checklist is genuinely satisfied, set the report status to passed.

    line 71
  5. Very specific:

    Open findings: After the gate decision, run ${CLAUDE_PLUGIN_ROOT}/standards/open-findings.md (read it now.

    line 73
  6. Distinctive:

    Never soften the verdict when presenting it.

    line 80
  7. Distinctive:

    Don't skip re-review after fixes: fixed code is new code.

    line 83

“Common” is measured: kept by at least 6 in 10 of the 38 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

/peer-review — Review (Reviewer)

You are running the code review ceremony. A second pair of eyes goes over everything /increment built, before any human-visible testing starts.

Input

Optional argument: the feature name. Resolve as usual.

Steps

  1. Check the gate. The plan at .spark/<feature-name>/plan.md must show all tasks done. If the working tree doesn't build or the test suite is red, STOP — that goes back to /increment without a review. Read only what the gate asks: the Status column of the task table and the build/test result. You do not read the spec, the plan or the diff here — the reviewer agent reads all three in full, in its own context. That separation is the entire point of delegating this phase; pre-loading the same material into this conversation gives the benefit straight back.
    • Only after the gate has passed, resolve optional tool availability, once: if the session exposes MCP tools whose names end in staleness and impact (they are normally namespaced, e.g. mcp__aspark-graph__staleness), treat that as the available surface and run no command; otherwise probe once, read-only, with command -v aspark-graph >/dev/null 2>&1 && echo runner=yes || echo runner=no; test -f .aspark-graph/graph.json && echo graph=yes || echo graph=no — it reports both facts and always exits 0, so the absent case never looks like a failed command. Resolve both facts — is there a surface, and does .aspark-graph/graph.json exist — and act on the four states in ${CLAUDE_PLUGIN_ROOT}/tools/aspark-graph.md: pass the tool file in step 2 only when both hold; say its one-sentence hint, at most once, in either mixed state; and when neither holds, say nothing at all and continue exactly as you would otherwise. Never probe in a run that already stopped, and never let the outcome change a gate.
  2. Delegate to the Reviewer. Invoke the reviewer agent with the feature paths, the report template from ${CLAUDE_PLUGIN_ROOT}/templates/review-report.md, how to determine the diff (commit range or changed files since the increment started), and the path of every active lens whose own frontmatter phases field includes review — read each active lens's file (${CLAUDE_PLUGIN_ROOT}/lenses/<name>.md) to decide; do not work from a list of lens names given here. If a tool resolved as available in step 1, pass ${CLAUDE_PLUGIN_ROOT}/tools/aspark-graph.md the same way — one more path alongside the lens paths, nothing else. Always also pass ${CLAUDE_PLUGIN_ROOT}/standards/anti-generosity.md, by this literal path: no constitution read, no flag. Tell the agent to read it in full before any verdict and to name it in the report as applied. For a re-review, point it at the previous report so it verifies the fixes instead of starting from zero.
  3. Present the report. Findings grouped by severity with locations; what the reviewer already fixed itself; plan deviations; and the verdict — quoted, not paraphrased into something softer. If the report does not name the anti-generosity standard as applied, tell the user.
  4. Route the findings with the user:
    • open Blockers/Majors → /increment (fix-mode), then re-run /peer-review;
    • the user may waive a Major — record the waiver and reason in the report; Blockers cannot be waived;
    • Minors/Nits → user decides: fix now or accept.
  5. Close the gate. When the REVIEW GATE checklist is genuinely satisfied, set the report status to passed.
  6. Open findings. After the gate decision, run ${CLAUDE_PLUGIN_ROOT}/standards/open-findings.md (read it now; it is conductor-side): propose follow-up tickets for findings that stay open, file only on an explicit yes, and say nothing when none are open.

Rules

  • Never soften the verdict when presenting it.
  • The reviewer's own fixes must be visible to the user — list them, they are part of the diff now.
  • Don't skip re-review after fixes: fixed code is new code.

Handoff

  • Review passed → /demo-day (QA in the real browser)
  • Findings to fix → /increment

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.