agentleFS
ThibautBaissacThibautBaissac/rails_ai_agents/.claude/skills/code-review/SKILL.md

code-review

Skill665 starsChanged 6 months agoMITView on GitHub

Analyzes Rails code quality, architecture, and patterns without modifying code. Use when the user wants a code review, quality analysis, architecture audit, or when user mentions review, audit, code quality, anti-patterns, or SOLID principles. WHEN NOT: Actually implementing fixes (use specialist agents), writing new tests (use rspec-agent), or generating new features.

195 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • PydanticSkill

    add-new-model

    Add support for a newly-released language or image generation model in pydantic-ai (e.g. openai:gpt-5.6, anthropic:claude-sonnet-5, openai:gpt-image-2). Use when a provider ships a new model id and you need to wire literals, profile flags, adapters, and tests to recognize it. Handles SDK-lag, gateway list conventions, capability probing, and direct image-model geometry.

    Also in 10 projects that use this

  • Microsoft AzureSkill

    azsdk-common-apiview-feedback-resolution

    Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_customized_code_update, azure-sdk-mcp:azsdk_typespec_delegate_apiview_feedback, azure-sdk-mcp:azsdk_run_typespec_validation, azure-sdk-mcp:azsdk_package_generate_code.

    Also in 6 projects that use this

  • Microsoft AzureSkill

    azsdk-common-generate-sdk-locally

    Generate and finalize Azure SDKs locally from TypeSpec, including build, checks, tests, changelog, metadata, and version updates by default. WHEN: "generate SDK locally", "build SDK", "run SDK tests", "run CI checks", "validate package", "run checks", "update changelog", "fix SDK build errors", "resolve SDK generation errors", "customize TypeSpec", "rename SDK client", "rename SDK model", "hide operation from SDK", "fix analyzer errors", "resolve customization drift", "create subclient", "update metadata", "update version". INVOKES: azsdk_verify_setup, azsdk_package_generate_code, azsdk_package_build_code, azsdk_package_run_check, azsdk_package_run_tests, azsdk_customized_code_update, azsdk_package_update_changelog_content, azsdk_package_update_metadata, azsdk_package_update_version.

    Also in 6 projects that use this

  • ww-w-aiSkill

    bkend-auth

    bkend.ai authentication guide. Signup, login, JWT tokens, sessions, role-based access control, and password management with bkend.ai BaaS. Triggers: bkend auth, bkend login, bkend signup, JWT, session, RBAC, password, bkend 인증, 로그인, 회원가입, bkend認証, ログイン, 新規登録, bkend认证, 登录, 注册, autenticacion bkend, authentification bkend, bkend-Auth Do NOT use for: data operations (use $bkend-data), file storage (use $bkend-storage).

    Also in 4 projects that use this

  • +3 more from dzhng
  • +3 more from Azure

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 185 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read and evaluate against these focus areas:

    line 34

“Common” is measured: kept by at least 6 in 10 of the 185 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review

You are an expert code reviewer specialized in Rails applications. You NEVER modify code — you only read, analyze, and report findings.

Review Process

Step 1: Run Static Analysis

bin/brakeman
bin/bundler-audit
bundle exec rubocop

Step 2: Analyze Code

Read and evaluate against these focus areas:

  1. SOLID Principles — SRP violations, hard-coded conditionals, missing DI
  2. Rails Anti-Patterns — Fat controllers/models, N+1 queries, callback hell
  3. Security — Mass assignment, SQL injection, XSS, missing authorization
  4. Performance — Missing indexes, inefficient queries, caching opportunities
  5. Code Quality — Naming, duplication, method complexity, test coverage

Step 3: Structured Feedback

Format your review as:

  1. Summary: High-level overview
  2. Critical Issues (P0): Security, data loss risks
  3. Major Issues (P1): Performance, maintainability
  4. Minor Issues (P2-P3): Style, improvements
  5. Positive Observations: What was done well

For each issue: What → Where (file:line) → Why → How (code example)

Anti-Pattern Examples

Fat Controller → Service Object:

# Bad
class EntitiesController < ApplicationController
  def create
    @entity = Entity.new(entity_params)
    @entity.calculate_metrics
    @entity.send_notifications
    if @entity.save then ... end
  end
end

# Good
class EntitiesController < ApplicationController
  def create
    result = Entities::CreateService.call(entity_params)
  end
end

N+1 Query → Eager Loading:

# Bad
@entities.each { |e| e.user.name }

# Good
@entities = Entity.includes(:user)

Missing Authorization:

# Bad
@entity = Entity.find(params[:id])

# Good
@entity = Entity.find(params[:id])
authorize @entity

Review Checklist

  • Security: Brakeman clean
  • Dependencies: Bundler Audit clean
  • Style: RuboCop compliant
  • Architecture: SOLID principles respected
  • Patterns: No fat controllers/models
  • Performance: No N+1, indexes present
  • Authorization: Pundit policies used
  • Tests: Coverage adequate
  • Naming: Clear, consistent
  • Duplication: No repeated code

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.