review
Skill214 starsChanged 32 days agoMITView on GitHub
Review code quality, security, and maintainability before committing. Use when reviewing code changes, checking code quality, performing security review, or validating changes before commit.
192 other projects use a version of this.
Adopted by
Most recently taken up by
- dzhng/skillstheir own version, first seen Nov 15, 2026
- muxy-app/muxytheir own version, first seen Nov 15, 2026
- macro-inc/macrotheir own version, first seen Nov 15, 2026
- yagizdo/quivertheir own version, first seen Nov 15, 2026
- markmhendrickson/neotomatheir own version, first seen Nov 15, 2026
- felipeam86/pipe-skillstheir own version, first seen Nov 15, 2026
Used with
Projects with it also use close-spec, design-with-images and 10 more.
Other files people use alongside this one.
Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
dzhngSkillclose-spec
When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).
Also in 5 projects that use this
dzhngSkilldesign-with-images
Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.
Also in 5 projects that use this
LambenthanSkilldaily-arxiv
每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新
Also in 5 projects that use this
LambenthanSkillexp-eval
实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges
Also in 5 projects that use this
- +3 more from dzhng
- +5 more from Lambenthan
Other versions192 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 192
- garrytan/gstack★ 142ksame name
- ansible/ansible★ 71ksame name
- docling-project/docling★ 71ksame name
- traefik/traefik★ 66ksame name
- ClickHouse/ClickHouse★ 51ksame name
- temporalio/temporal★ 24ksame name
- ccch1mneyyy/dsh-Go★ 24ksame name
- tisfeng/Easydict★ 15ksame name
- juicedata/juicefs★ 15ksame name
- elie222/inbox-zero★ 13ksame name
182 more not listed
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository10 other files it gives its agents.
- AGENTS.mdAGENTS.md
- .aidriven/AGENTS.mdAGENTS.md
- CLAUDE.mdCLAUDE.md
- .github/copilot-instructions.mdCopilot instructions
- debugSkill
- implementSkill
- release-betaSkill
- release-checkSkill
- release-rollbackSkill
- release-stableSkill
The file
Files
Code Review Before Commit
Review code quality, security, and maintainability before committing changes to Linus Dashboard.
Your Role
Senior code reviewer ensuring quality, security, and maintainability.
Context Required:
- .aidriven/memorybank.md
- .aidriven/rules/ - All rule files
- Changed files (git diff)
Review Checklist
1. Code Quality
Readability:
- Functions < 50 lines
- Variables have descriptive names
- Complex logic has comments explaining WHY
- Code is self-documenting
Structure:
- Single responsibility per function/class
- No code duplication
- Logical organization
- Consistent style
Type Safety:
- All functions have type hints
- No
Anywithout justification - Return types specified
- Proper use of Optional/Union
2. Documentation
- Module docstrings present
- Public functions/classes documented
- Docstrings follow Google style
- Complex algorithms explained
- No outdated comments
3. Error Handling
- Specific exceptions (no bare
except) - Errors logged with context
- User-friendly error messages
- Resources cleaned up (try/finally)
- No silent failures
4. Async/Await
- No blocking I/O in async functions
- All async functions awaited
asyncio.gather()for parallel ops- Proper timeout handling
- CancelledError handled
5. Home Assistant Patterns
- Integration lifecycle correct (setup/unload)
- Data stored in
hass.data[DOMAIN][entry_id] - Cleanup registered with
entry.async_on_unload() - Entities have unique_id
- Services registered properly
- Coordinator pattern used correctly
6. Security
- No hardcoded credentials
- User input validated
- SQL injection prevented
- XSS vulnerabilities addressed
- API keys stored securely
- No sensitive data in logs
7. Performance
- No N+1 queries
- Expensive operations cached
- Database queries optimized
- No memory leaks
- Async for I/O operations
8. Testing
- Changes manually tested
- Edge cases considered
- Error paths tested
- No regressions
Review Process
Step 1: Get Changed Files
# See what changed
git status
# View diff
git diff
# Check specific files
git diff path/to/file.pyStep 2: Analyze Changes
For each changed file:
- Read the diff
- Understand the purpose
- Check against standards
- Look for issues
- Note improvements
Step 3: Check Build and Tests
# TypeScript
npm run build
npm run type-check
npm run lint:check
# Run smoke tests
npm run test:smokeStep 4: Provide Feedback
Format:
File: path/to/file.py
✅ Good:
- Clear function names
- Proper type hints
- Good error handling
⚠️ Issues:
1. Line 42: Missing docstring
2. Line 78: Blocking I/O in async function
3. Line 103: Exception too broad
💡 Suggestions:
- Consider caching this result
- Extract this logic to separate functionCommon Issues to Watch For
Python Issues
Async/Await:
# ❌ Bad - blocking I/O
async def fetch_data():
response = requests.get(url) # Blocks event loop
# ✅ Good - async I/O
async def fetch_data():
async with aiohttp.ClientSession() as session:
async with session.get(url) as response:
return await response.json()Error Handling:
# ❌ Bad - bare except
try:
do_something()
except:
pass
# ✅ Good - specific exception
try:
do_something()
except ValueError as err:
_LOGGER.error("Invalid value: %s", err)
raiseType Hints:
# ❌ Bad - no types
def process_data(data):
return data.get("value")
# ✅ Good - with types
def process_data(data: dict[str, Any]) -> str | None:
"""Process data and return value."""
return data.get("value")TypeScript Issues
Type Safety:
// ❌ Bad - any type
function process(data: any): any {
return data.value;
}
// ✅ Good - proper types
function process(data: DataType): string | undefined {
return data.value;
}Null Safety:
// ❌ Bad - no null check
const value = entity.state.toUpperCase();
// ✅ Good - null check
const value = entity.state?.toUpperCase() ?? "unknown";Security Review Checklist
- No secrets in code
- API keys from config
- User input sanitized
- SQL queries parameterized
- HTML output escaped
- HTTPS for external calls
- Authentication checked
- Authorization verified
Performance Review Checklist
- No synchronous I/O in async code
- Database queries optimized
- Caching used appropriately
- No unnecessary API calls
- Efficient algorithms
- Memory usage reasonable
Final Review
Before approving:
Code Quality:
- Follows project standards
- Well-documented
- Properly typed
- Good error handling
Functionality:
- Implements requirements
- No obvious bugs
- Edge cases handled
- Tested manually
Maintainability:
- Easy to understand
- Well-structured
- Follows patterns
- Documented properly
Security:
- No vulnerabilities
- Input validated
- Secrets protected
Review Outcome
APPROVE - Code meets all standards REQUEST CHANGES - Issues must be fixed COMMENT - Suggestions for improvement
Quick Commands
# Check what changed
git diff
# Check specific file
git diff path/to/file
# See commit history
git log --oneline -10
# Run quality checks
npm run lint:check
npm run type-check
npm run build
# Run tests
npm run test:smokeDoes it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

