agentleFS
RBraga01RBraga01/a-team/skills/finishing-a-development-branch/SKILL.md

finishing-a-development-branch

Skill24 starsChanged 25 days agoMITView on GitHub

Complete a development branch before merge — verify tests pass, update documentation, ensure quality gate passes, and prepare a clean PR.

187 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • kntismSkill

    condition-based-waiting

    Use when tests have race conditions, timing dependencies, or inconsistent pass/fail behavior - replaces arbitrary timeouts with condition polling to wait for actual state changes, eliminating flaky tests from timing guesses

    Also in 3 projects that use this

  • MicrosoftSkill

    testing-anti-patterns

    Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies

    Also in 4 projects that use this

  • MicrosoftSkill

    root-cause-tracing

    Use when errors occur deep in execution and you need to trace back to find the original trigger - systematically traces bugs backward through call stack, adding instrumentation when needed, to identify source of invalid data or incorrect behavior

    Also in 5 projects that use this

  • +3 more from Leodorareluctant259

The file

Show its rules and text

We split this skill into the rules it gives an agent

17 rules. 0 are common, 14 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 173 edited versions we read keep these.

  • 14

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Distinctive:

    All tests must pass (no skips, no TODOs in critical paths)

    line 19
  2. Distinctive:

    If tests fail → stop and fix before continuing

    line 21
  3. Very specific:

    Run /quality-gate (code review + security review in parallel)

    line 31
  4. Very specific:

    Remove all console.log and debug statements

    line 36
  5. Distinctive:

    Remove all commented-out code

    line 37
  6. Distinctive:

    Remove all TODO/FIXME without issue references

    line 38
  7. Distinctive:

    Update CLAUDE.md or README.md if setup changed

    line 41
  8. Very specific:

    Run doc-updater agent if codemaps are out of date

    line 42
  9. Distinctive:

    Update CHANGELOG if project uses one

    line 43
  10. Distinctive:

    Write PR body with:

    line 51
  11. Distinctive:

    Test plan (checkboxes for manual verification steps)

    line 53
  12. Distinctive:

    All changes staged and committed

    line 57
  13. Distinctive:

    Commit message follows conventional format

    line 58
  14. Distinctive:

    Never merge with failing tests

    line 63
  15. Distinctive:

    Never merge with CRITICAL review findings

    line 64
  16. Distinctive:

    Never merge to main/master directly (use PR)

    line 65
  17. Distinctive:

    Never skip the quality gate

    line 66

“Common” is measured: kept by at least 6 in 10 of the 173 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Finishing a Development Branch

Complete all final steps before merging a feature branch.

Announce at start: "I'm using the finishing-a-development-branch skill."

Checklist (Complete in Order)

1. Verify Tests Pass

npm test           # or pytest, go test, cargo test
npm run test:coverage
  • All tests must pass (no skips, no TODOs in critical paths)
  • Coverage must be ≥ 80%
  • If tests fail → stop and fix before continuing

2. Verify Build

npm run build      # or go build ./..., cargo build --release
npx tsc --noEmit
  • Build must succeed with zero errors

3. Quality Gate

  • Run /quality-gate (code review + security review in parallel)
  • Block MUST be resolved before merge
  • Warn can merge with documented issue

4. Clean Up

  • Remove all console.log and debug statements
  • Remove all commented-out code
  • Remove all TODO/FIXME without issue references

5. Update Documentation

  • Update CLAUDE.md or README.md if setup changed
  • Run doc-updater agent if codemaps are out of date
  • Update CHANGELOG if project uses one

6. Prepare PR

git log --oneline [base-branch]..HEAD    # Review all commits
git diff [base-branch]...HEAD            # Review all changes

Write PR body with:

  • Summary (3-5 bullet points of what changed and why)
  • Test plan (checkboxes for manual verification steps)
  • Screenshots if UI changed

7. Final Commit

  • All changes staged and committed
  • Commit message follows conventional format
  • Branch is up to date with base

Hard Rules

  • Never merge with failing tests
  • Never merge with CRITICAL review findings
  • Never merge to main/master directly (use PR)
  • Never skip the quality gate

The branch is done when every checkbox above is checked.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.