agentleFS
Mathews-TomMathews-Tom/armory/skills/plan-review/SKILL.md

plan-review

Skill340 starsChanged 8 months agoMITView on GitHub

Pre-implementation plan audit stress-testing scope, assumptions, risks, and failure modes before code is written. Triggers on: "review this plan", "is this plan solid", "what am I missing", "challenge my assumptions", "stress-test this", "/plan-review".

43 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use plan-execute, pr-comment and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • longranger2Skill

    plan-execute

    Use when the user says "/plan-execute", "plan execute", "implement plan", or "execute plan" and provides a finalized plan file path to carry out. Claude orchestrates, Codex writes code, Claude reviews, and Codex fixes issues until the quality bar is met.

    Also in 3 projects that use this

  • BenjaminGSkill

    pr-comment

    This skill should be used when reviewing someone else's pull request and you want drafted review comments posted to GitHub — either gate / gate-wf findings (tier-marked) or pr-challenge's reviewer questions (unmarked) — each drafted through humanizer and posted as a standalone inline comment at its file:line, after one confirmation. Triggers on "post these as review comments", "comment the gate findings on the PR", "draft and post my review", "leave review comments", after a gate / gate-wf run or a pr-challenge pass on a PR you're reviewing.

    Also in 3 projects that use this

  • MicrosoftSkill

    spec-review

    Independent, multi-model review of a design or spec **before** any code is written, for the microsoft/winappcli repo. Activate when a contributor asks to "review this spec", "review my design", "review this design doc", "validate this approach", "should we build this", "spec review", "design review", or "feature review". Fans out parallel sub-agents — each doing its OWN research against the real codebase and ecosystem rather than trusting the spec — covering necessity & scope, approach & alternatives, feasibility vs reality, risks & unknowns, DX & user impact, and a different-model-family cross-check. Emits a decision-oriented recommendation (proceed / proceed-with-changes / reconsider) to stdout. This is the PRE-CODE companion to the pr-review skill (which reviews code already written); use spec-review at the design/spec stage, not on an implemented diff. Does NOT write code or edit the spec.

    Also in 3 projects that use this

  • AnthropicSkill

    office-hours

    Set up and run Claude Code office hours, including the calendar event when the champion's own calendar connector allows it. Use when a champion wants a regular time for teammates to bring problems.

    Also in 3 projects that use this

  • AWSSkill

    retro

    Conduct a retrospective on a coding session.

    Also in 5 projects that use this

  • BlockSkill

    plan

    Draft a TDD, PRD, or lightweight plan in the conversation without committing it.

    Also in 5 projects that use this

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 35 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use the requested lens: Product, Engineering, or Combined.

    line 25
  2. Distinctive:

    Use ASCII diagrams to illustrate non-obvious data flow or failure propagation where the plan involves three or more interacting components.

    line 67
  3. Distinctive:

    Use a diagram only when it clarifies a non-obvious dependency or failure.

    line 154

“Common” is measured: kept by at least 6 in 10 of the 35 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Plan Review Skill

Purpose

Execute a structured pre-implementation audit of a technical plan, proposal, or design document. The goal is to surface risks, bad assumptions, missing pieces, and scope problems before any code is written — when course corrections are cheapest.

This skill is read-only. It never modifies code. It produces a severity-tagged review document with a final ship/rethink/reject verdict.

Step 0 — Mode Selection

Use the requested lens: Product, Engineering, or Combined. When none is specified, use Combined without a configuration question. Resolve facts from the plan and repository; ask only for a material decision the evidence cannot settle.

Also assess scope size from the plan:

  • Small change (single file, ~100 lines or fewer): deliver a compressed 4-section review — Scope, Risks, Missing, Verdict. Skip the full multi-section template.
  • Standard change: execute the full review sequence below.

Full Review Sequence

1. Plan Comprehension

Read the plan and its authoritative project goal. Summarize the intended user workflow, the next useful outcome, non-goals and constraints in 2–3 sentences. Identify a mismatch between project value and technically coherent milestones before reviewing implementation detail. Do not pause for confirmation unless an unresolved contradiction changes the outcome or safety.

2. Assumption Challenge

Extract material assumptions that could change the next outcome or its safety. For each one:

AssumptionIf wrong?Supporting evidenceWhat falsifies it?

Common assumption categories to probe:

  • Data availability and shape
  • Third-party API stability and rate limits
  • Team familiarity with chosen tools
  • Performance characteristics of dependencies
  • Backward compatibility requirements
  • Deployment environment capabilities

3. Risk & Failure Mapping

For components on the next delivery path, identify demonstrated failure risks:

ComponentFailure ModeBlast RadiusRecovery Strategy

Additionally identify data flow shadow paths — side effects, async callbacks, event propagation, or cache invalidation chains that are not on the happy path but will execute in production.

Use ASCII diagrams to illustrate non-obvious data flow or failure propagation where the plan involves three or more interacting components.

4. Component-by-Component Review (Engineering Lens)

For each major component, assess:

  • Error handling strategy — Are current failures explicit and recoverable where required? Do not prescribe a registry or retry framework without a consumer.
  • Data integrity invariants — What invariants must hold? How are they enforced? What happens when they break?
  • Concurrency and race conditions — Shared state, lock ordering, optimistic vs. pessimistic strategies, idempotency guarantees.
  • Performance under load — Does the design meet evidenced workload and latency constraints? Hypothetical 10x capacity is not a gate without a source requirement.
  • Test strategy adequacy — Do focused tests and an observed interaction cover the promised behavior and affected contracts? Separate fast local/PR feedback, integration-candidate checks and broad mainline/release coverage.

This section is language- and framework-agnostic. Reference references/project-detection.md for framework-aware examples when the user's stack is known.

Skip this section when running product-lens-only mode.

5. Scope & Priority Assessment (Product Lens)

  • Necessary now vs. eventually useful — Does each milestone advance the next useful project outcome? For prerequisites and architectural expansion, name the consumer and concrete cost or risk of deferral.
  • Deferral candidates — Defer optional capability with a revisit condition. Preserve correctness, security, data integrity and expensive-to-reverse constraints of the current capability.
  • Changeability vs. speculative extensibility — Favor clear boundaries and affordable refactoring over unused frameworks, providers or deployment machinery.
  • Planning horizon — Detail actionable milestones; keep distant outcomes provisional. Missing distant execution prompts are not defects.
  • Delivery cost — Prefer one cohesive PR unless a split improves review or safe integration; examine stack depth and repeated CI/review waits.

Skip this section when running engineering-lens-only mode.

6. Integration Review

How components connect to each other and to the outside world:

  • API contracts — Request/response shapes, versioning, error codes between modules.
  • State management across boundaries — Who owns state? How is it synchronized? What happens during partial failure?
  • Migration and deployment ordering — Which components must deploy first? Are there intermediate states where the system is inconsistent?
  • Rollback compatibility — Can each deployment step be reversed independently? What data is irreversible?

7. What's Missing

Report a missing element only when a source requirement or concrete failing scenario makes it necessary for the current outcome. Consider security, data integrity, recovery, workload and operational needs at that boundary; do not turn this list into mandatory dashboards, runbooks, retries, benchmarks or extra qualification. Put optional improvements under non-blocking follow-ups, or omit them.

8. Execution Assessment

Evaluate the proposed implementation order:

  • Dependency ordering — Are prerequisites built before dependents?
  • Parallel work opportunities — Which tasks have no mutual dependency and can proceed simultaneously?
  • Risk-first vs. value-first — Address an unknown early only when it threatens the next useful outcome or an expensive-to-reverse decision.
  • Bounded experiments — Recommend a focused spike only when it can resolve that unknown more cheaply than implementation; state its decision and stop condition.
  • Integration readiness — Keep required checks before merge against the actual integration candidate. Local checks and broad post-merge coverage complement rather than replace that safeguard.

9. Verdict

Deliver exactly one of:

VerdictMeaning
ShipPlan is solid. Proceed as written.
Ship with changesViable, but specific modifications listed below are required before proceeding.
RethinkFundamental structural issues require re-planning. Itemize what must change.
RejectPlan is not viable. Explain why and what alternative direction to consider.

Include a one-paragraph rationale for the verdict.

Compressed Review (Small Changes)

For small-scope changes (single file, ~100 lines), deliver four sections only:

  1. Scope — What the change does and its boundaries.
  2. Risks — Failure modes and blast radius (brief table).
  3. Missing — Only material gaps required by this outcome.
  4. Verdict — Ship / Ship with changes / Rethink / Reject.

Interaction Protocol

  • Batch related material decisions; finish the reachable review rather than pausing after each finding.
  • Distinguish blocking defects from optional improvements. A plausible long-term benefit alone is not a blocker.
  • This skill is read-only. It does not create, modify, or delete files.
  • Use a diagram only when it clarifies a non-obvious dependency or failure.

Output Format

Return only applicable sections, severity-tagged findings with evidence and consequence, and a final verdict with rationale. Separate blocking changes from optional follow-ups. Omit empty sections and do not repeat findings in a second summary table. No finding is a valid result; do not invent work to fill a template.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.