agentleFS
Leodorareluctant259Leodorareluctant259/superpowers-zh/skills/requesting-code-review/SKILL.md

requesting-code-review

Skill5 starsChanged 8 months agoMITView on GitHub

完成任务、实现重要功能或合并前使用,用于验证工作成果是否符合要求

187 other projects use a version of this, 5 of them edited.

Adopted by

Most recently taken up by

Used with

Projects with it also use diagnosing-superpowers, heartmula and 5 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • math-incSkill

    heartmula

    Set up and run HeartMuLa, the open-source music generation model family (Suno-like). Generates full songs from lyrics + tags with multilingual support.

    Also in 9 projects that use this

  • Tommy-ywSkill

    webhook-subscriptions

    Create and manage webhook subscriptions for event-driven agent activation, or for direct push notifications (zero LLM cost). Use when the user wants external services to trigger agent runs OR push notifications to chats.

    Also in 5 projects that use this

  • john-data-chenSkill

    touchdesigner-mcp

    Control a running TouchDesigner instance via twozero MCP — create operators, set parameters, wire connections, execute Python, build real-time visuals. 36 native tools.

    Also in 7 projects that use this

  • math-incSkill

    minecraft-modpack-server

    Set up a modded Minecraft server from a CurseForge/Modrinth server pack zip. Covers NeoForge/Forge install, Java version, JVM tuning, firewall, LAN config, backups, and launch scripts.

    Also in 5 projects that use this

  • +2 more from math-inc

The file

Files
SKILL.md

请求代码审查

派遣 superpowers:code-reviewer 子代理来在问题扩散之前发现它们。审查者获得的是精心组织的评估上下文——绝不是你的会话历史。这样可以让审查者专注于工作成果而非你的思考过程,同时保留你自己的上下文以便继续工作。

核心原则: 早审查,勤审查。

何时请求审查

必须审查:

  • 子代理驱动开发中每个任务完成后
  • 完成重要功能后
  • 合并到 main 之前

可选但有价值:

  • 卡住时(换个视角)
  • 重构之前(建立基线)
  • 修复复杂 bug 之后

如何请求

1. 获取 git SHA:

BASE_SHA=$(git rev-parse HEAD~1)  # 或 origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. 派遣 code-reviewer 子代理:

使用 Task 工具,指定 superpowers:code-reviewer 类型,填写 code-reviewer.md 中的模板

占位符说明:

  • {WHAT_WAS_IMPLEMENTED} - 你刚完成的内容
  • {PLAN_OR_REQUIREMENTS} - 预期功能
  • {BASE_SHA} - 起始提交
  • {HEAD_SHA} - 结束提交
  • {DESCRIPTION} - 简要说明

3. 处理反馈:

  • Critical 问题立即修复
  • Important 问题在继续之前修复
  • Minor 问题记录下来稍后处理
  • 如果审查者有误,用技术理由反驳

示例

[刚完成任务 2:添加验证功能]

你:让我在继续之前请求代码审查。

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[派遣 superpowers:code-reviewer 子代理]
  WHAT_WAS_IMPLEMENTED: 会话索引的验证和修复功能
  PLAN_OR_REQUIREMENTS: docs/superpowers/plans/deployment-plan.md 中的任务 2
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: 添加了 verifyIndex() 和 repairIndex(),支持 4 种问题类型

[子代理返回]:
  优点:架构清晰,测试真实
  问题:
    Important:缺少进度指示器
    Minor:报告间隔使用了魔法数字 (100)
  评估:可以继续

你:[修复进度指示器]
[继续任务 3]

与工作流的集成

子代理驱动开发:

  • 每个任务完成后审查
  • 在问题叠加之前发现它们
  • 修复后再进入下一个任务

执行计划:

  • 每批(3 个任务)后审查
  • 获取反馈,修复,继续

临时开发:

  • 合并前审查
  • 卡住时审查

红线

绝不要:

  • 因为"很简单"就跳过审查
  • 忽略 Critical 问题
  • 带着未修复的 Important 问题继续推进
  • 对合理的技术反馈进行争辩

如果审查者有误:

  • 用技术理由反驳
  • 展示证明其可行的代码/测试
  • 要求澄清

参见模板:requesting-code-review/code-reviewer.md

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.