agentleFS
JBSommelingJBSommeling/claude-config/.agents/skills/code-review/SKILL.md

code-review

Skill0 starsChanged 29 days agoMITView on GitHub

Conducts code review — inline or via dispatched subagent. Use before merging any change, after completing major features, or when reviewing code written by yourself, another agent, or a human.

194 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • PydanticSkill

    add-new-model

    Add support for a newly-released language or image generation model in pydantic-ai (e.g. openai:gpt-5.6, anthropic:claude-sonnet-5, openai:gpt-image-2). Use when a provider ships a new model id and you need to wire literals, profile flags, adapters, and tests to recognize it. Handles SDK-lag, gateway list conventions, capability probing, and direct image-model geometry.

    Also in 9 projects that use this

  • transitive-bullshitSkill

    compare-screenshots

    Compare screenshots against the intended design, distinguishing approved references from historical baselines. Use for iterative implementation matching, before/after visual review, objective image telemetry, or checking a lone capture for flat, empty, or badly framed content.

    Also in 5 projects that use this

  • Microsoft AzureSkill

    azsdk-common-apiview-feedback-resolution

    Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_customized_code_update, azure-sdk-mcp:azsdk_typespec_delegate_apiview_feedback, azure-sdk-mcp:azsdk_run_typespec_validation, azure-sdk-mcp:azsdk_package_generate_code.

    Also in 6 projects that use this

  • Microsoft AzureSkill

    azsdk-common-generate-sdk-locally

    Generate and finalize Azure SDKs locally from TypeSpec, including build, checks, tests, changelog, metadata, and version updates by default. WHEN: "generate SDK locally", "build SDK", "run SDK tests", "run CI checks", "validate package", "run checks", "update changelog", "fix SDK build errors", "resolve SDK generation errors", "customize TypeSpec", "rename SDK client", "rename SDK model", "hide operation from SDK", "fix analyzer errors", "resolve customization drift", "create subclient", "update metadata", "update version". INVOKES: azsdk_verify_setup, azsdk_package_generate_code, azsdk_package_build_code, azsdk_package_run_check, azsdk_package_run_tests, azsdk_customized_code_update, azsdk_package_update_changelog_content, azsdk_package_update_metadata, azsdk_package_update_version.

    Also in 6 projects that use this

  • +4 more from dzhng
  • +2 more from Azure

The file

Show its rules and text

We split this skill into the rules it gives an agent

13 rules. 0 are common, 13 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 184 edited versions we read keep these.

  • 13

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Do tests cover the change adequately?

    line 18
  2. Distinctive:

    When you flag a structural problem, propose the move — not just the problem.

    line 46
  3. Distinctive:

    Reuse the canonical helper: instead of a bespoke near-duplicate.

    line 53
  4. Distinctive:

    Prefer the remedy that removes moving pieces over one that spreads the same complexity around.

    line 57
  5. Distinctive:

    If you have one structural problem and ten nits, the structural problem *is* the review.

    line 71
  6. Distinctive:

    Before merge to main → dispatch

    line 96
  7. Distinctive:

    After completing major feature → dispatch

    line 97
  8. Distinctive:

    When stuck and want fresh perspective → dispatch

    line 98
  9. Distinctive:

    After any refactor, list the code that is now unreachable — then ask before deleting: "Should I remove these now-unused elements: [list]?" …

    line 109
  10. Distinctive:

    Don't rubber-stamp. "LGTM" without evidence of review helps no one.

    line 123
  11. Distinctive:

    Don't soften real issues. Quantify problems when possible.

    line 124
  12. Distinctive:

    Don't accept "I'll clean it up later" — require cleanup before merge.

    line 125
  13. Distinctive:

    No regression tests with bug fix PRs

    line 134

“Common” is measured: kept by at least 6 in 10 of the 184 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Review

Approval standard: Approve when the change definitely improves overall code health, even if it isn't perfect. Don't block because it isn't how you would have written it.

Core principle: Review early, review often.

The Five-Axis Review

1. Correctness

  • Does it match the spec or task requirements?
  • Are edge cases handled (null, empty, boundary values)?
  • Are error paths handled (not just happy path)?
  • Do tests cover the change adequately?

2. Readability

  • Are names descriptive and consistent with project conventions?
  • Is control flow straightforward?
  • Could this be done in fewer lines without sacrificing clarity?
  • Are abstractions earning their complexity?
  • Any dead code artifacts (unused variables, commented-out blocks)?

3. Architecture

  • Does it follow existing patterns or introduce a justified new one?
  • Does it maintain clean module boundaries?
  • Is the abstraction level appropriate?

4. Security

  • Is user input validated and sanitized?
  • Are secrets kept out of code, logs, and version control?
  • Is auth checked where needed?
  • Are SQL queries parameterized?
  • Is external data treated as untrusted?

5. Performance

  • Any N+1 query patterns?
  • Any unbounded loops or unconstrained data fetching?
  • Any missing pagination on list endpoints?

Structural Remedies

When you flag a structural problem, propose the move — not just the problem. Reach for a named restructuring:

  • Replace a chain of conditionals with a typed model or an explicit dispatcher.
  • Collapse duplicate branches into a single clearer flow.
  • Separate orchestration from business logic so each reads on its own.
  • Move feature-specific logic out of a shared module into the package that owns it.
  • Reuse the canonical helper instead of a bespoke near-duplicate.
  • Make a type boundary explicit so downstream branching disappears.
  • Delete a pass-through wrapper that adds indirection without clarifying the API.

Prefer the remedy that removes moving pieces over one that spreads the same complexity around.

Severity Labels

PrefixMeaningAuthor Action
(none)Required changeMust address before merge
Critical:Blocks mergeSecurity vulnerability, data loss, broken functionality
Nit:Minor, optionalAuthor may ignore
Optional:SuggestionWorth considering but not required
FYIInformationalNo action needed

Lead with what matters. Order findings by leverage: correctness and security first, then structural regressions, then everything else. A few high-conviction comments beat a long list. If you have one structural problem and ten nits, the structural problem is the review.

Review Modes

Inline Review (quick check during development)

Review the current changes directly in this session:

  1. Context — Understand intent before looking at code
  2. Tests first — Tests reveal intent and coverage gaps
  3. Implementation — Walk through with five axes in mind
  4. Categorize — Label every finding with severity
  5. Verify — Check tests pass, build succeeds

Dispatched Review (formal pre-merge)

Spawn a code-reviewer subagent for independent review. The reviewer gets git context, not your session history — keeps it focused on the work product.

Steps:

  1. Get git range: BASE_SHA=$(git rev-parse origin/main) and HEAD_SHA=$(git rev-parse HEAD)
  2. Dispatch code-reviewer agent with: description of changes, requirements/spec, BASE_SHA, HEAD_SHA
  3. Act on feedback: fix Critical immediately, fix Important before proceeding, note Minor for later

When to dispatch vs. inline:

  • Quick changes during development → inline
  • Before merge to main → dispatch
  • After completing major feature → dispatch
  • When stuck and want fresh perspective → dispatch

Acting on Feedback

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with technical reasoning)

Dead Code Hygiene

After any refactor, list the code that is now unreachable — then ask before deleting: "Should I remove these now-unused elements: [list]?" Don't leave dead code lying around, and don't silently delete what you're unsure about.

Change Sizing

~100 lines changed  → Good. Reviewable in one sitting.
~300 lines changed  → Acceptable if it's a single logical change.
~1000 lines changed → Too large. Split it.

Rules

  • Don't rubber-stamp. "LGTM" without evidence of review helps no one.
  • Don't soften real issues. Quantify problems when possible.
  • Don't accept "I'll clean it up later" — require cleanup before merge.
  • Separate refactoring from feature work in the diff.
  • Large PRs (1000+ lines): ask the author to split.

Red Flags

  • PRs merged without any review
  • "LGTM" without evidence of actual review
  • Security-sensitive changes without security-focused review
  • No regression tests with bug fix PRs
  • Skipping review because "it's simple"
  • Ignoring Critical issues or proceeding with unfixed Important issues

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.