agentleFS
HugoLopes45HugoLopes45/design-skills/skills/implementation-review/SKILL.md

implementation-review

Skill1 starsChanged 3 months agoMITView on GitHub

Verify the shipped interface against the designed one, in a real browser with hostile inputs — real responsive behavior, keyboard, network failures, extreme data, zoom, localization, perceived performance. Use after a design is implemented, before release, when "it matches the mock" is claimed, or when a UI works in the demo and nowhere else.

6 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 6 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run the real app, not a storybook.

    line 12

“Common” is measured: kept by at least 6 in 10 of the 6 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Implementation Review

The product users get is the code, not the design file. This review runs on the shipped interface, in a real browser, with hostile inputs. It exists because design intent degrades at implementation time in predictable places; the checklist below is those places. Design-review judged the proposal; this judges reality.

Setup

Run the real app, not a storybook. Use the app's real data path (seeded database, staging API), because most of what follows only breaks with real asynchrony and real content.

The passes

Real content. Replace demo data with hostile data: a 120-character name, an amount of 1 234 567,89, zero items, one item, 10 000 items. Truncation, wrapping, overflow, and alignment failures live here. If the design only holds with the demo dataset, it isn't implemented; it's staged.

Localization stress. German labels run 30-50% longer than English: inject them into every button, tab, and table header. Then: RTL direction if the product ships it, non-Latin scripts in user-generated fields, local date/number/currency formats, plural forms beyond singular/plural. A layout that only survives in English is an English prototype, not a shipped interface.

Real viewport. Actual devices or DevTools device mode at 320px, 375px, 768px, plus the awkward in-between widths. Horizontal scroll anywhere is a failure. Then browser zoom at 200%: text must reflow, nothing may clip or overlap. 100dvh behavior with mobile browser chrome, keyboard-open resize on forms.

Real network. DevTools throttled to slow 3G and offline. Does every loading state actually appear, or does the UI blank? Does a failed request show the designed error with its recovery action, or a console stack trace and a spinner forever? Double-submit while the first request is in flight: what happens?

The state matrix, live. Take the feature's declared matrix from interaction-design and trigger each state for real: empty account, revoked permission, expired session, stale cache, partial load. Every declared state must be reachable and match what was designed. A state that can't be triggered can't have been tested.

Keyboard and assistive tech. The full pass from the accessibility skill, on the shipped code: Tab order, focus visibility, Escape behavior, focus return, one VoiceOver run of the changed flow, prefers-reduced-motion actually honored.

Perceived performance. Layout shift on load (skeletons hold the space or they don't), input latency on typing, animation frame drops on a mid-range device. Interaction to visual feedback over 100ms feels broken regardless of what the profiler says.

Design/code drift. Diff the shipped screen against the proposal: spacing values, type sizes, colors, radii. Drift is either a bug to fix or a decision to write back into the design and tokens. Silent drift is how the system stops being true.

Reporting

Each finding: where, the trigger to reproduce, what was designed, what shipped, severity. Blockers are anything that loses user data, dead-ends a flow, or fails an accessibility gate. Everything else ships behind a written follow-up. "Works on my machine with the demo data" is not a pass condition; it's the null result.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.