agentleFS
HenryQWHenryQW/skills/review-checkpoint/SKILL.md

review-checkpoint

Skill1 starsChanged 4 months agoApache-2.0View on GitHub

Run blocker-only branch reviews through a native read-only reviewer subagent. Direct review requests are read-only; explicit fix loops and coordinating workflows may apply deterministic in-scope fixes.

The file

We split this skill into the rules it gives an agent

4 rules. About 0 are common, 0 are distinctive, and 4 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈0

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 4

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Use one native read-only reviewer subagent as the branch-diff gate.

    line 8
  2. Very specific:

    Stop when the budget is spent, a finding repeats after its targeted fix, or a later finding contradicts an accepted one.

    line 28
  3. Very specific:

    No actionable blocker -> PASS.

    line 42
  4. Very specific:

    When manifest_path is set, record pass, blocker, or tooling-failure events through:

    line 46

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review Checkpoint

Use one native read-only reviewer subagent as the branch-diff gate. Review is read-only unless fix_loop is explicitly authorized or selected by a coordinating workflow.

Inputs

  • mode: review_only (direct default) or fix_loop (explicit fix/coordinator default).
  • max_iterations: default 3.
  • review_base: optional caller-provided base ref.
  • manifest_path: optional and only for Shipyard's integration review; child reviews keep isolated state in their handoffs.

Memory

Direct invocation owns $agent-memory; nested Workbench or Shipyard invocation defers it to the caller. Capture only accepted durable review rules or reusable root causes.

Findings and authorization

  • Classify findings as spec_blocker (acceptance or unrequested behavior), standards_blocker (repository rules), safety_blocker (data, secrets, security, or forbidden paths), test_blocker (missing or misleading validation), or non_actionable.
  • A blocker is actionable only when deterministic, in scope, and fixable without a product decision. Cosmetic, speculative, stale, broad, unclear, contradictory, or out-of-scope findings are non_actionable.
  • review_only never edits. fix_loop fixes only actionable findings and each iteration must reduce that set. Do not loop on non-actionable findings.
  • Stop when the budget is spent, a finding repeats after its targeted fix, or a later finding contradicts an accepted one. Record contradictions as non_actionable: contradictory semantics.

Review loop

  1. Require a clean worktree except local .context/progress.md and a named local branch. Resolve review_base, base_sha, and head_sha; the reviewed branch does not need an upstream.
  2. For the current (base_sha, head_sha), spawn exactly one native read-only reviewer subagent with fork_turns=none, choosing the least-cost sufficient reviewer role under repository instructions. Do not use an external review service or substitute a local self-review.
  3. Give the reviewer the absolute worktree, branch, base and head SHAs, reproducible diff refs, task requirements, repository instructions, and validation evidence. Require it to inspect the actual diff and relevant callers/tests, make no edits or state changes, and return only PASS or blocker findings with taxonomy, file/line evidence, impact, and the smallest credible fix.
  4. Validate each finding against scope and current HEAD; reclassify unsupported findings as non_actionable.
  5. The final gate is the latest completed subagent review with no later commit. If no reviewer subagent is available or it fails without a result, return BLOCKED with the tooling failure.

Append compact review history to .context/review-events.jsonl; do not create per-review folders.

Complete or fix

  • No actionable blocker -> PASS.
  • Actionable blockers in review_only -> BLOCKED with findings and no edits.
  • In fix_loop, apply the smallest fix, inspect the diff, run the smallest relevant check, commit inspected files, and return to Step 1 for the new HEAD.

When manifest_path is set, record pass, blocker, or tooling-failure events through:

python3 <shipyard_dir>/scripts/manifest.py --manifest <manifest_path> set-review --file <event_file>

A passing integration event must contain status:"PASS", current branch, base_sha, and exact reviewed head_sha; return PASS only after the manifest accepts it.

Output

Return PASS or BLOCKED with mode, reviewer role, reviewed base/head SHAs, checks, and unresolved actionable blockers.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.