agentleFS
GustavoGutierrezGustavoGutierrez/engineering-skills/skills/4r-code-review/SKILL.md

4r-code-review

Skill0 starsChanged 5 months agoMITView on GitHub

Trigger: 4R code review, review this change, review agent code, pre-commit review, is this done, quality gate before commit. Run a Risk/Readability/Reliability/Resilience review on a completed change before declaring it done.

The file

We split this skill into the rules it gives an agent

8 rules. About 0 are common, 7 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈7

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use this skill when a coding task is reported complete and BEFORE declaring it done, committing, pushing, or opening a PR — especially when …

    line 23
  2. Distinctive:

    Use it to run a systematic, stack-agnostic review across four dimensions — Risk, Readability, Reliability, Resilience — that classifies …

    line 25
  3. Very specific:

    Do NOT use this skill to write the feature, design architecture from scratch, or audit non-code artifacts (use reviewer for PRDs, specs, …

    line 27
  4. Distinctive:

    Scope the diff: Run git diff / git diff --staged (and git status) to get exactly what changed.

    line 31
  5. Distinctive:

    Confirm intent match: Verify the change does what the task asked AND ONLY that.

    line 33
  6. Distinctive:

    Gather evidence: Run the test suite / linter / build when available.

    line 35
  7. Distinctive:

    Never approve a change with a Blocker in Risk or Resilience.

    line 44
  8. Distinctive:

    Before returning the review, verify:

    line 87

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

4R Code Review

When to Use

Use this skill when a coding task is reported complete and BEFORE declaring it done, committing, pushing, or opening a PR — especially when the change was produced wholly or partly by a coding agent.

Use it to run a systematic, stack-agnostic review across four dimensions — Risk, Readability, Reliability, Resilience — that classifies findings by severity, surfaces fixable defects, and returns an explicit accept/block decision.

Do NOT use this skill to write the feature, design architecture from scratch, or audit non-code artifacts (use reviewer for PRDs, specs, and API contracts). This skill reviews a code diff, not prose.

Operating Workflow

  1. Scope the diff. Run git diff / git diff --staged (and git status) to get exactly what changed. Review the diff and its blast radius, not the whole repo.
  2. Tier the review. Match effort to risk (see Decision Rules). Do not burn a deep 4R pass on a one-line doc typo; do not shortcut a change that touches auth, data, or money.
  3. Confirm intent match. Verify the change does what the task asked AND ONLY that. Flag edits outside the intended scope, stray files, and unrequested behavior changes.
  4. Run the 4R passes. Evaluate each dimension against references/4r-dimensions.md. Prioritize the AI failure patterns listed there — agent code passes the eye test and fails differently than human code.
  5. Gather evidence. Run the test suite / linter / build when available. Treat "looks correct" as unproven until executed. Record commands and results.
  6. Classify and decide. Tag every finding with severity, score each R 0–2, and return one verdict: Approve / Approve with follow-up / Request changes / Escalate.

Core Rules

  • Evidence over intention: tests run, errors handled, limits set, and observability must be VISIBLE in the change, not assumed.
  • Code that looks correct is not evidence that it is correct. Trace the unhappy paths explicitly.
  • Complexity is a budget. A change that adds branches, state, or abstraction must justify the cost; reject or simplify accidental or AI-inflated complexity.
  • Be specific and actionable. Never say "security is missing" — name the file, line, failure mode, and the fix direction.
  • Never approve a change with a Blocker in Risk or Resilience. A residual risk must be explicit, bounded, and proportional.

The 4R Dimensions

RCentral questionCovers
RiskDoes this add disproportionate risk to security or production?Auth, secrets, trust boundaries, input validation, injection, blast radius, rollback.
ReadabilityCan another engineer maintain this without rebuilding the author's intent?Naming, structure, duplication, complexity budget, AI slop.
ReliabilityIs there real evidence it works on normal AND edge inputs?Tests that catch bugs, edge cases, error handling, timeouts, correctness.
ResilienceWhen it fails, does the system recover or cascade?Retries with backoff, fallback, graceful degradation, observability, isolation.

Full per-dimension checklists, AI-specific failure patterns, and acceptance criteria are in references/4r-dimensions.md — read it before the 4R passes.

Decision Rules

SituationAction
Diff is trivial (docs, comments, formatting)Quick pass: intent match + Risk scan only; skip deep 4R.
Diff touches auth, secrets, payments, data, or infraFull 4R + mandatory Escalate consideration; no Blockers allowed.
Agent-generated logic, new integration, or 2+ filesFull 4R; prioritize AI failure patterns and test quality.
Tests absent where change warrants themReliability ≤ 1; Request changes unless risk is low AND justified in writing.
Blocker in Risk or ResilienceBlock. Do not approve regardless of other scores.
Change exceeds reviewer's authority or domainEscalate to specialized/human review.

Severity

SeverityMeaning
🔴 BlockerProbable vulnerability, data loss, critical regression, plausible cascade, unbounded risk in a sensitive zone.
🟠 HighMissing tests on a critical path, absent timeout, wrong retry, excessive complexity in core logic, weak observability at a critical point.
🟡 MediumImprovable readability, bounded uncovered edge case, documentable debt without immediate impact.
🔵 LowNaming, minor structure, non-critical simplification.

Scorecard

Score each R 0–2 (0 = insufficient, 1 = acceptable with reservations, 2 = solid). Merge rule: minimum 1 per dimension, no 0 in Risk or Resilience, target average ≥ 1.5. Any security Blocker or plausible cascade invalidates the aggregate until fixed.

Output Contract

Produce the report in assets/4r-review-report.md. Required sections: Context, one block per R (verdict Pass/Concern/Block + findings table), a severity-tagged findings list, the 0–2 scorecard, and a Final Decision (status + residual risk + required actions before merge + follow-ups). End with one explicit sentence: whether the change may be committed/pushed or must return to iteration.

Quality Checklist

Before returning the review, verify:

  • Review is based on the actual diff, with tests/linter/build run when available.
  • Intent match confirmed: change does what was asked and nothing extra.
  • All four R dimensions evaluated; AI failure patterns checked on agent code.
  • Every finding cites a file/line, the failure mode, and an actionable fix.
  • Severity assigned by impact; scorecard filled; merge rule applied.
  • No Blocker left in Risk or Resilience before any Approve.
  • Final decision is explicit and unambiguous.

References

  • references/4r-dimensions.md — per-dimension checklists, AI failure patterns, acceptance criteria. Read before the 4R passes.
  • assets/4r-review-report.md — report template. Fill for every review.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.