agentleFS
BrentRectorBrentRector/claude-skills/skills/review/SKILL.md

review

Skill6 starsChanged 43 days agoMITView on GitHub

Use when asked for a code review, architecture review, performance review, or duplication/efficiency analysis of a diff, branch or PR (or a whole subsystem audit), including the read-only review of a finished branch before it is enqueued to land - runs the four review dimensions (architecture, full code review, performance, duplication and efficiency) as parallel agents, requires a concrete failure scenario for every finding, adversarially verifies each finding before reporting it, and sweeps every confirmed defect for its siblings.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, design-with-images and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +3 more from dzhng
  • +5 more from Lambenthan

The file

Show its rules and text

We split this skill into the rules it gives an agent

15 rules. 0 are common, 4 are distinctive, and 11 are very specific to this project.

  • 0

    Common

    Most of the 157 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 11

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    No argument: local diff against the default branch (git symbolic-ref refs/remotes/origin/HEAD, never assume main), staged and unstaged.

    line 23
  2. Very specific:

    Read references/target-triage-calibration.md before reviewing a PR that already carries a review, or a branch in its branch form.

    line 42
  3. Distinctive:

    Before spending judgment, run whatever the repo already mechanizes: the build, the linters/analyzers, the test suite scoped to the change, …

    line 47
  4. Distinctive:

    Never skip Full code review, nor Duplication and efficiency for new files.

    line 56
  5. Very specific:

    Read references/target-triage-calibration.md (the triage table) before skipping Architecture, Performance or Duplication and efficiency.

    line 61
  6. Distinctive:

    Read CLAUDE.md/README first.

    line 65
  7. Very specific:

    Read references/target-triage-calibration.md before Step 4 for what each level changes.

    line 68
  8. Very specific:

    Read references/dimensions.md before launching the Step 5 agents: it holds the criteria to hand each agent and when each specialist applies.

    line 83
  9. Distinctive:

    No scenario, no finding. "This could be cleaner" or "consider X" is a style opinion, not a defect.

    line 94
  10. Very specific:

    Read references/verification-and-siblings.md before spawning the Step 6 skeptics.

    line 104
  11. Very specific:

    Read references/verification-and-siblings.md before the Step 7 sweep.

    line 111
  12. Very specific:

    Read references/report-and-scale.md before writing the Step 8 report and before posting to a PR.

    line 118
  13. Very specific:

    Read references/report-and-scale.md before an audit-sized run.

    line 125
  14. Very specific:

    Read references/standards-and-hooks.md before Step 2 when the repo carries engineering standards.

    line 131
  15. Very specific:

    Read references/standards-and-hooks.md before Step 2 to read the repo's Review rules section.

    line 138

“Common” is measured: kept by at least 6 in 10 of the 157 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review

Four independent review dimensions, run in parallel, followed by an adversarial verification pass that tries to kill every finding before it reaches the author. The output is a short list of defects that survived an honest attempt to refute them, each with a scenario that reproduces it.

The premise: a plausible-but-wrong finding costs more than a missed one. It sends the author (or the next agent) to rewrite working code, and it erodes trust in every later review. So this skill is built to filter, not to generate volume. An empty review is a valid result.

Triage and calibration ideas from carlymr/carlys-claude-skills.

Detail lives in references/; each step says when to read which file.

Step 1 - Establish the target

  • No argument: local diff against the default branch (git symbolic-ref refs/remotes/origin/HEAD, never assume main), staged and unstaged. PR: gh pr diff, gh pr view. Branch or path: diff against the merge base. "Audit" / "be comprehensive" / a subsystem name: whole-source mode (see Scale).
  • A PR that already carries a review: diff only the commits since, open with Incremental review - changes since <timestamp>, never re-raise an answered finding; no new commits, say so and stop.
  • Branch form (a fleet's finished branch, before it is enqueued to land): ONE branch, ONE read-only reviewer, run when the implementer reports DONE, over <default>...HEAD. Write every confirmed finding to a findings file (its scenario, repro, code site and severity: critical, high, medium, low or info, calibrated, never raised to make it block) through the project's one writer, and compute the verdict from the file under the blocking severities the dispatch names (by default critical, high and medium; critical and high at the round after the last finisher; a finding with no or an unknown severity blocks). Each non-blocking finding is a LEAD: recorded, written into the branch's report, never dropped. Never edit the branch, and never edit or repair a findings file the writer refuses as torn: stop and say so. A finisher answers EACH blocking finding — fixed at the root with a regression test, or refuted with evidence written beside it — before the branch is enqueued. A RE-REVIEW reads ONLY the finisher's diff since the head the last round reviewed, plus its answers; the earlier content is reviewed and is not re-opened unless the diff touches it. The landing step never reviews and never fixes (agent-fleet references/landing.md).

Empty diff → say so and stop.

Read references/target-triage-calibration.md before reviewing a PR that already carries a review, or a branch in its branch form.

Step 2 - Run the free checks first

Before spending judgment, run whatever the repo already mechanizes: the build, the linters/analyzers, the test suite scoped to the change, and any invariant checkers (Semgrep rules, architecture tests, custom scripts named in the project instructions). Anything a tool already catches needs no reviewer. And when the review later finds a defect class a rule could catch, propose the rule, not only the instance.

Step 3 - Triage: which dimensions apply

Skip dimensions that clearly cannot apply, and say which were skipped and why.

  • Never skip Full code review, nor Duplication and efficiency for new files.

A genuinely trivial diff (typo, version bump, comment) gets a direct single-pass review with no agents; state that a full review was not warranted.

Read references/target-triage-calibration.md (the triage table) before skipping Architecture, Performance or Duplication and efficiency.

Step 4 - Calibrate: two independent axes

  • Read CLAUDE.md/README first; an author's statement beats inference. Set scale and consequence independently; if unstated assume early users / standard, say so, and pass both axes to every agent.

Read references/target-triage-calibration.md before Step 4 for what each level changes.

Step 5 - The four dimensions, as parallel agents

Launch one agent per selected dimension in a single message so they run concurrently. Give each the diff (or subsystem), the changed-file list, the PR description, the calibration, any project review rules (see Project hooks), and its criteria below. Each agent reads surrounding code as needed - a diff alone hides most defects.

  • The four dimensions are Architecture, Full code review, Performance, Duplication and efficiency.
  • Specialist agents (silent-failure-hunter, pr-test-analyzer, type-design-analyzer, comment-analyzer) launch in the same message when the change matches and go through the same Step 6 skeptic.
  • A fixed time limit in a test is a finding; a performance finding names an input size.
  • A change to I/O, storage, sorting or concurrency code whose tests miss a failure path it can reach (a status it can return, a refused write or sync, a crash point, contention) is a finding (engineering-standards section 5).

Read references/dimensions.md before launching the Step 5 agents: it holds the criteria to hand each agent and when each specialist applies.

What every finding must carry

[SEVERITY] path/to/file.ext:L<start>-L<end> - <title>
Scenario: <inputs / state>  ->  <actual wrong result>  (expected: <correct result>)
Why: <the mechanism, pointing at the exact line>
Fix: <approach, and whether it is local or structural>

No scenario, no finding. "This could be cleaner" or "consider X" is a style opinion, not a defect; drop it unless the calibration explicitly asks for suggestions. For duplication, the scenario is the divergence: change rule R in place A, and path B still does the old thing.

Step 6 - Adversarial verification

  • Agent output is candidates: spawn a skeptic per candidate to REFUTE it, running the scenario when cheap. Uncertain means refuted; only survivors are reported; a null result is valid.
  • Then de-duplicate, apply the calibration, rank Critical, Warning, Suggestion.

Read references/verification-and-siblings.md before spawning the Step 6 skeptics.

Step 7 - Sweep for siblings

  • For each survivor search the other arm of the same dispatch, the paired function, the copied neighbor, the same idiom elsewhere; report siblings under the parent and say how the sweep was done.

Read references/verification-and-siblings.md before the Step 7 sweep.

Step 8 - Report

  • Nothing survives: say so plainly. Offer to file survivors in the project's tracker.
  • Posting is confirm-first: ask before posting to a PR; never approve or request changes unless asked.

Read references/report-and-scale.md before writing the Step 8 report and before posting to a PR.

Scale

  • A diff gets one finder per dimension and one skeptic; an audit gets several finders, 3-5 skeptics per finding and a completeness critic.

Read references/report-and-scale.md before an audit-sized run.

Standards

The bar is the engineering-standards skill; every rule there is a finding category here, even when every test passes.

Read references/standards-and-hooks.md before Step 2 when the repo carries engineering standards.

Project hooks

A repository adds a ## Review rules section to CLAUDE.md (or .claude/review.md): honor its extra dimensions, banned rules, mechanical checks and tracker.

Read references/standards-and-hooks.md before Step 2 to read the repo's Review rules section.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.