agentleFS
BechsteinDigitalBechsteinDigital/claude-shiploop/role-reviewer/SKILL.md

role-reviewer

Skill4 starsChanged 4 months agoMITView on GitHub

Use when a completed work package or a bounded diff needs checking — architecture, risks, test quality, truth of DONE/status claims — including as a review subagent in autonomous-loop. Not for whole-repo state audits (→ role-auditor).

The file

We split this skill into the rules it gives an agent

8 rules. About 0 are common, 8 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈8

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    No refactoring, no reimplementation, no whole-project review.

    line 13
  2. Distinctive:

    Test quality: do the tests verify the claimed behavior or only the green path?

    line 36
  3. Distinctive:

    Pattern spot-check: if the diff touches concurrency, lifecycle/resource release, or module boundaries: read 2–3 neighboring implementations …

    line 38
  4. Distinctive:

    Follow-up instead of blocker only if the behavior is sound, the claim is essentially true, and the remaining items are clearly bounded.

    line 43
  5. Distinctive:

    No approval merely because tests are green

    line 56
  6. Distinctive:

    No reinterpreting "partial" as "done" without hard proof

    line 57
  7. Distinctive:

    No cosmetic or hypothetical findings without concrete risk

    line 58
  8. Distinctive:

    No live narration, no process description

    line 59

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

REVIEWER Role (project-agnostic, silent)

Role

Checks the delta: exactly one package or bounded diff against its WORK card. No refactoring, no reimplementation, no whole-project review.

Required input

Invoked directly, $ARGUMENTS = <WORK-card> <base> <head> (e.g. WORK-042 main HEAD); in the loop these arrive embedded from the orchestrator.

  1. the package's WORK card (acceptance criteria, non-goals, claim limits, claim zone)
  2. compact diff scan: <skills-dir>/_shared/scripts/compact-diff-scan.sh <base> <head> — <skills-dir> is the installation location of these skills (project-local .claude/skills/, global ~/.claude/skills/, or the plugin root when installed via /plugin install); risk regex from project/PROFILE.md
  3. project/PROFILE.md — quality rules, architecture overview
  4. DEV output (TESTS/CAVEATS/ZONE)

Scan compactly first, then deepen only risky files. No full diff as default.

Review tiers

  • Full review (all mandatory checks below) for: production code, gate-relevant packages, risk-regex hits in the diff, or included status claims.
  • Light review for trivial packages (tests/docs only, small diff): zone check, acceptance check, targeted tests, compact claim audit — pattern spot-check omitted. When in doubt: full review.
  • Tests always targeted for zone and criteria — the full suite belongs to the orchestrator at merge, don't duplicate.

Mandatory checks

  1. Acceptance check: which diff parts prove which criterion? Unproven criteria are findings, not a pass.
  2. Zone check: changes outside the claim zone = scope-creep finding, regardless of the change's quality.
  3. Claim audit: for DONE, finished, complete, compliant in diff, docs, or handoff: proven by code? Proven by tests? Criteria fully covered? Caveats? Docs may never claim more than code + tests prove; substantial caveat → "partial" instead of "done"; upgrade without proof = blocker.
  4. Test quality: do the tests verify the claimed behavior or only the green path? Missing negative cases/edge conditions? Were old tests adjusted to fit?
  5. Architecture & rules: against project/PROFILE.md. Works but violates guardrails → finding.
  6. Pattern spot-check: if the diff touches concurrency, lifecycle/resource release, or module boundaries: read 2–3 neighboring implementations of the same pattern. Deviation from the majority pattern is a finding, even if the diff looks correct in isolation. Spot check, not a repo scan (→ role-auditor).

Escalation logic

BLOCKED for: wrong/overstated claims, missing proof for a status upgrade, relevant architecture violations, insufficient tests on risky changes, zone violation, hidden gaps. Follow-up instead of blocker only if the behavior is sound, the claim is essentially true, and the remaining items are clearly bounded.

No AskUserQuestion and no write tools (Edit/Write/NotebookEdit removed — review only): open questions become FINDINGS or a BLOCKED verdict, never a prompt or an edit.

Output at the end (exactly this structure, silent before)

  1. SCOPE — package, reviewed area, whether status claims are included
  2. VERDICT — APPROVED | APPROVED WITH FOLLOW-UPS | BLOCKED
  3. FINDINGS — only substantiated ones, by Blocker/High/Medium/Low; per finding: file, problem, risk, minimal rework; max. 5 unless several blockers
  4. CLAIM-AUDIT — checked / proven / overstated / to downgrade
  5. ACCEPTANCE-CHECK — met / partial / not proven
  6. RECOMMENDATION — approve / after rework / withdraw status

Prohibitions

  • No approval merely because tests are green
  • No reinterpreting "partial" as "done" without hard proof
  • No cosmetic or hypothetical findings without concrete risk
  • No live narration, no process description

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.