pr-review
Skill3.5k starsChanged 4 days agoMITView on GitHub
Review a Wikipedia iOS pull request or branch the way this team reviews — triage findings against the Phabricator ticket and the diff, check the repo-specific bug patterns below, preview every comment before anything is posted, then post only the comments the user picks as inline GitHub review comments. Also handles re-reviews after the author pushes. Use when someone says "review PR 6369", "code review <PR URL>", "review this branch", "re-review", "check if the PR was updated", or asks whether to approve a PR.
195 other projects use a version of this.
Trending
Steady talk.about the whole repository
Most recently taken up by
- IntelRealSense/librealsensetheir own version, first seen Nov 16, 2026
- realsenseai/librealsensetheir own version, first seen Nov 16, 2026
- minio/skillstheir own version, first seen Nov 16, 2026
- lumlaolao/spike-evaltheir own version, first seen Nov 16, 2026
- AshrafDurjoy/genai-shared-patternstheir own version, first seen Nov 16, 2026
- neomjs/neo-agent-skillstheir own version, first seen Nov 15, 2026
Who's talking about wikimedia/wikipedia-ios
- mobile-dev-inc/Maestro“Screenshot function only saves a single screenshot when run on multiple devices”GitHub · Nov 29, 2024 · 3 reactions
- @katkel.bsky.social“@wikimediafoundation.org’s #Wikipedia app has everything I never realized I needed! - dark mode 🌙 - …”Bluesky · Feb 11, 2025 · 1 likes
- Tim9Liu9/TimLiu-iOS“Update README URLs based on HTTP redirects”GitHub · May 19, 2016 · 1 reactions
- wikimedia/apps-android-wikipedia“[SemanticSearchV2E2] Add test cases for lexcial list vectors”GitHub · Nov 12, 2026
- dnf/hecatron“Real app (xcode): wikimedia/wikipedia-ios”GitHub · Nov 10, 2026
The biggest 5 of 22 mentions linking to the repository that our crawl found. Each line is their own headline.
See all 22
Talked about on GitHub and Bluesky (22 times).
On GitHub · 21
- Nov 29, 2024Screenshot function only saves a single screenshot when run on multiple devices — mobile-dev-inc/Maestro3 reactions · 2 comments
- May 19, 2016Update README URLs based on HTTP redirects — Tim9Liu9/TimLiu-iOS1 reaction · 2 comments
- Nov 12, 2026[SemanticSearchV2E2] Add test cases for lexcial list vectors — wikimedia/apps-android-wikipedia0 reactions
- Nov 10, 2026Real app (xcode): wikimedia/wikipedia-ios — dnf/hecatron0 reactions · 1 comment
- Jul 25, 2026Wikipedia iOS — expo/expo-brownfield-examples0 reactions · 1 comment
16 more on GitHub
- Jun 18, 2026T423933: Main Games UI — orianna-ai/wikipedia-ios0 reactions · 1 comment
- Apr 28, 2026Allow pinch to zoom when reading articles — wikimedia/apps-android-wikipedia0 reactions · 1 comment
- May 12, 2024Wikimedia — phlippieb/resume0 reactions · 4 comments
- Nov 27, 2023Add string documentation — kiwix/kiwix-apple0 reactions · 6 comments
- Sep 8, 2023Add reachability toast handler and update delegate method — wikimedia/wikipedia-ios-components0 reactions · 1 comment
- Sep 7, 2023Add SwiftUI based user menu button — wikimedia/wikipedia-ios-components0 reactions
- Aug 2, 2023Add empty Watchlist view — wikimedia/wikipedia-ios-components0 reactions
- May 23, 2023[HOLD] Native Source Editor Component - Part 2 — wikimedia/wikipedia-ios-components0 reactions · 1 comment
- Jan 10, 2023원활한 스타일 가이드 적용을 위해 SwiftLint 도입 — DeveloperAcademy-POSTECH/MacC-Team-Sandals0 reactions · 1 comment
- Dec 14, 2020T268751 Use Fulltext search in Search screen — wikimedia/wikipedia-kaios0 reactions · 2 comments
- Apr 19, 2019Incorporate search changes — wikimedia/wikipedia-ios-codemirror0 reactions
- Mar 21, 2019part of fix for undo to keep undone item onscreen — wikimedia/wikipedia-ios-codemirror0 reactions
- Oct 17, 2018Add Wikipedia to the list — jogendra/example-ios-apps0 reactions
- Dec 8, 2017Add 3 items to COPY_ATTRIBUTES which are used by iOS. — wikimedia/wikimedia-page-library0 reactions · 1 comment
- May 12, 2016Update ReadMe to add note about @loader_path/Frameworks — Carthage/Carthage0 reactions · 1 comment
- May 11, 2016Unit test target: Library not loaded: @rpath… — Carthage/Carthage0 reactions · 6 comments
On Bluesky · 1
- Feb 11, 2025@wikimediafoundation.org’s #Wikipedia app has everything I never realized I needed! - dark mode 🌙 - clicking a Wiki link in a… — @katkel.bsky.social1 likes and repost
Used with
Projects with it also use clack-cli-patterns, drag-to-reorder and 10 more.
Other files people use alongside this one.
Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
openchamberSkillclack-cli-patterns
Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.
Also in 3 projects that use this
openchamberSkilldrag-to-reorder
Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.
Also in 3 projects that use this
jtenniswoodSkillexpert-reset
Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.
Also in 3 projects that use this
CES-LtdSkilloss-pr
Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.
Also in 3 projects that use this
CES-LtdSkillpr-automation
PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".
Also in 3 projects that use this
- +7 more from openchamber
Other versions195 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 195
- Significant-Gravitas/AutoGPT★ 188ksame name
- pytorch/pytorch★ 106ksame name
- rtk-ai/rtk★ 87ksame name
- saadeghi/daisyui★ 43ksame name
- rustfs/rustfs★ 36ksame name
- dotnet/maui★ 23ksame name
- NVIDIA/Megatron-LM★ 18ksame name
- MiniMax-AI/skills★ 14ksame name
- btriapitsyn/openchamber★ 13ksame name
- openchamber/openchamber★ 13ksame name
185 more not listed
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository4 other files it gives its agents.
- .github/copilot-instructions.mdCopilot instructions
- crash-forensicsSkill
- ui-test-debuggerSkill
- ui-test-writerSkill
The file
We split this skill into the rules it gives an agent
11 rules. 0 are common, 4 are distinctive, and 7 are very specific to this project.
0
Common
Most of the 180 edited versions we read keep these.
4
Distinctive
This author's own choices. Worth a look.
7
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 14
Read only: Do not edit, commit, push or switch the user's branch.
- Distinctive: line 16
Default review state is comment-only: Use "request changes" or "approve" only when the user says so.
- Very specific: line 23
Existing comments: Read Copilot's and the other reviewers' inline comments: gh api repos/wikimedia/wikipedia-ios/pulls/<N>/comments.
- Very specific: line 24
Branch freshness: Check mergeStateStatus and whether the head is behind the base.
- Very specific: line 28
Run the code-review skill at level high on the PR (/code-review high <N>) for the first pass when it is available.
- Distinctive: line 32
Check that the PR description is still true: After later commits, test steps and descriptions often describe a design that is gone.
- Very specific: line 41
After an await, the screen can be gone.
- Very specific: line 109
No Objective-C (.m) code or helpers used from WMFComponents or WMFData.
- Very specific: line 111
No new DispatchQueue or completion handlers in new code.
- Distinctive: line 113
Every Core Data model change is a new model version with a migration test.
- Distinctive: line 156
When the user asks "was the PR updated?" or "re-review":
“Common” is measured: kept by at least 6 in 10 of the 180 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
PR Review — Wikipedia iOS
Goal: give the user a short, ranked list of real problems in the PR, so that they can decide what to post. The user owns the review. Claude finds, checks and drafts. The user picks, and Claude posts only what the user picks.
This skill comes from about 75 reviews of this repo (Aug–Nov 2026). The checklist in section 4 lists the bugs that those reviews found, and the bugs that they missed.
1. Rules
- Read only. Do not edit, commit, push or switch the user's branch. Read the PR head with
gh pr diff,git fetch origin pull/<N>/head:pr-<N>plusgit show, or a worktree. Fix code only when the user asks for fixes, and only on the user's own PR. - Post nothing until the user says so. Show a preview first. "Review it" does not mean "post it".
- Default review state is comment-only. Use "request changes" or "approve" only when the user says so.
- Write in ASD-STE100 Simplified Technical English. Short sentences, active voice, no metaphors, about a 5th-grade reading level. Do not label comments "nit".
2. Collect the context before you review
gh pr view <N> --json title,body,baseRefName,headRefName,author,commits,files,reviews,comments,mergeable,mergeStateStatus. Diff against the PR's own base (it can be arelease-candidate/*branch, notmain). For a local branch with no PR, diffmain...HEAD.- The requirements. Find the Phabricator ticket (
T\d+in the title, branch or body). Read it withcurl -s "https://phabricator.wikimedia.org/api/maniphest.search" -d 'constraints[ids][0]=<id>'or the web page. Read the PR's test steps too. The ticket, a PM decision and the test steps overrule a finding: do not report intended behavior as a bug. - Existing comments. Read Copilot's and the other reviewers' inline comments:
gh api repos/wikimedia/wikipedia-ios/pulls/<N>/comments. Do not repeat them. Copilot often finds lifetime,try?and concurrency bugs. If you agree with one of its comments, say so in the preview and do not post a copy. - Branch freshness. Check
mergeStateStatusand whether the head is behind the base. When it is, suggest a short general comment: "Please merge the latest main." Do not invent a reason for it.
3. Find the problems
- Run the
code-reviewskill at levelhighon the PR (/code-review high <N>) for the first pass when it is available. Then filter its findings with the rules in this section and section 5. Without it, read every changed hunk and the callers of each changed symbol yourself. - Only lines the PR changes. A bug that also exists on the base branch is not a finding for this PR. List it separately at the end as "existing bug, not from this PR", or leave it out.
- Check each finding before you report it. Read the caller. Trace the value. Compile a small sample when the behavior of the language is the question. When the user asks, build, run the unit tests, and run the app on the simulator (see the
runskill and CLAUDE.md "Build and Test"). Mark a finding "not confirmed" when you could not check it. - Ask "does the PR do what the ticket asks?" Missing requirements are findings too (category
incomplete-implementation). - Check that the PR description is still true. After later commits, test steps and descriptions often describe a design that is gone. QA then follows steps that cannot work.
4. Checklist: bugs found in this repo before
Async work, lifetimes and re-entry
- An
actoris re-entrant at everyawait. A "check, then insert" or "check cancellation, then save" across anawaitcan run twice, or save after a cancel. Look atawait context.performand persist steps that followTask.checkCancellation(). - Cancellation is cooperative. Code after the last check still writes. A cancelled refresh can still set
@Publishedstate (for exampleisVisible = false) after a newer refresh set it. - A
Taskthat is not stored cannot be cancelled when the screen closes. - Buttons stay enabled while an async action runs. A double tap on Done calls the completion two times, and the coordinator pops two screens.
- After an
await, the screen can be gone. Check thatpresentedViewControlleris still the expected controller before you present on it. - A weak reference in a queued draw or callback can be released early in Release builds only.
try?on a save, then continue as if it succeeded. The UI closes and the source of truth changes, but nothing was saved.- A timeout that cancels a task, then awaits
task.value, still waits for calls that ignore cancellation (for exampleperformDecodableGET). - Network requests that do not depend on each other run one after another inside a time budget. Use a
TaskGroup.
UIKit lifecycle and presentation
viewWillDisappearwithisMovingFromParentis also true for an interactive Back swipe that the user cancels. UseviewDidDisappearfor "the user left".viewWillDisappearruns only on the top controller of a navigation stack. A sheet that is dismissed with another screen on top does not call it on the root.viewDidAppearimpressions log again on each return. Check that a "log if needed" closure has the guard that its name promises..overFullScreendoes not takesupportedInterfaceOrientationsfrom the presented controller.WMFComponentNavigationControlleralready hasforcePortrait.overrideUserInterfaceStyle = .lightdoes not changeWMFAppEnvironment.current.theme. Colors from the app theme (tints, nav bar appearance,theme.colors.linkon alerts) stay dark.
SwiftUI and WMFComponents
WMFFont.for(...)ignores.dynamicTypeSize(...)caps. UseWMFFont.for(_:sized:). A cap modifier affects only children.- A fixed
compatibleWith: .largefont on a button stops Dynamic Type.CapsuleButtonStylehas a fixed 46 pt height and clips large or two-line titles. GeometryReaderhas no intrinsic height and collapses in aListrow or a self-sizingVStack.- An asset without
"template-rendering-intent": "template"ignores.foregroundColor. - An
AttributedStringwith its own foreground color overrides.foregroundColor. @ObservedObject var appEnvironmentthat nothing reads re-renders the view on each theme change.- Modifiers that do nothing:
.padding(.top, 0)in aVStack(spacing: 0), a branch that setstitleView = nilwhen nothing set it. Removing.padding(.bottom, 8)puts buttons on the edge on devices without a bottom safe area (iPhone SE). - Two flexible views (
Spacer()and.frame(maxHeight: .infinity)) share the free height, so the button floats up on tall screens. - Removing
.scrollPosition(id:)breaks code that moves the pager by setting the ID, and VoiceOver paging. - A computed property that builds a constant gradient or array on each
bodyevaluation.
Accessibility and localization
- Two conditional buttons (Submit, then Next) remove the VoiceOver-focused element. Check on a device. The Simulator has no VoiceOver.
Image(uiImage:)inside a button label needs.accessibilityHidden(true).- State that only icons show (correct/incorrect dots) needs an
accessibilityValue. - Directional images need
language-directionvariants or.flipsForRightToLeftLayoutDirection. uppercased()ignores the language (Turkish İ, Greek accents). UselocalizedUppercaseoruppercased(with:)with the content's locale.- Error
localizedDescription, or an enum that conforms toLocalizedErrorwith noerrorDescription, shows English or generic text to users. - A literal year (
2026) in strings or URLs that the next campaign reuses.
WMFData, Core Data and the API
- MediaWiki returns HTTP 200 with an
errorsbody. A decoder that reads onlyqueryturns the error into an empty success. Theerrorsarray needserrorformat=htmlin every parameter dictionary. - An object inserted into the context before
try? encodestays in the context as an orphan row and gets saved. - Merge policies that differ between methods that write the same entity.
- Two rows that point at one
CDPagethrough a to-one inverse (titlesFoo_barandFoo bar). Deduplicate after normalizing the title. - Fetches with no
fetchLimitthat load a year of page views to keep 20. - The same report fetched and decoded from Core Data several times on the main thread. Build it once and pass it.
- Display titles (
normalizedForDisplay, precomposed Unicode) used to rebuild a database title. - Comparison of sets as ordered arrays (deselect and reselect looks like a change).
- Lists merged per language one after another instead of sorted by date.
Analytics (TestKitchen / instruments)
- The same
action,actionSourceandelementIdfor two different actions (save and unsave). - One surface logs
actionSourcein two spellings ("EmptyForYouCard"and"feed_empty"), so impression and click cannot join. - Impression deduplication that keeps only the last key logs again on scroll back.
- A funnel stopped in
viewWillDisappearends when the user opens an article from it. - Logging the old value (the language switched away from) instead of the new one.
- A changed logging ID for existing events (for example
""to"end") that the PR does not say. - A new tap target with no click event, when the analytics spec covers that screen.
Tests and CI
- A new branch of code with no test. The fixture JSON does not contain the new fields, so the new path never runs.
- Tautological tests that compare a wrapper to the call it wraps.
- Assertions that pass only when the simulator locale is English.
waitUntilloops with no timeout hang the suite until the CI job timeout. Race them againstTask.sleep.- Hand-written lists of enum cases in tests. Make the enum
CaseIterable. - Tests that set
WMFDataEnvironment.currentwithoutWMFDataTestFixturefailscripts/lint-wmfdata-test-fixtures.sh. The lint matches onlywithConfiguredEnvironment(, not the trailing-closure form. - Controllers that read
WMFDataEnvironment.currentstores in tests that should inject them. Other suites swap and release those stores. - Workflows: a failed early step skips later steps through the implicit
success(). A count or gate that passes when the scheme was not compiled at all. - A test target that no longer compiles after a merge from main (a new required init parameter).
Repo rules (CLAUDE.md)
- Callbacks to coordinators typed
@MainActor @Sendable () -> Void. - Icons through
WMFIcon/WMFSFSymbolIcon. Colors throughWMFColorandWMFTheme. Fonts throughWMFFont. - No Objective-C (
.m) code or helpers used from WMFComponents or WMFData. @unchecked Sendableandnonisolated(unsafe)need a comment that is still true.- No new
DispatchQueueor completion handlers in new code. - Removing a
WMFLocalizedStringleaves translations inWikipedia/Localizations/*.lproj, andTWNStringsTestsfails on plural orphans. - Every Core Data model change is a new model version with a migration test.
- Few comments. No doc comment that only repeats the name. Delete commented-out code. Replace literals such as content group kind
3with the enum case. - Dead code left behind after a refactor (a helper with no caller, a branch that cannot run).
5. What is not a finding
- Behavior that the ticket, a PM decision or the test steps ask for.
- Product tradeoffs. Ask them as questions to the user, not as bugs.
- Bugs that exist on the base branch (list them apart, see section 3).
- Code in other features or slides that the PR does not touch. On Year in Review slide tickets, review only that slide.
- A suggestion that breaks an architecture rule, for example reuse of an Objective-C helper from a package.
- Style-only remarks when the user asked for "high and medium only".
6. Preview format
Show this in chat. Do not post.
- One line: what the PR does, and whether it does what the ticket asks.
- A numbered table, most severe first:
#, severity (high / medium / low),file:line, one-line summary, "in diff" yes/no, "confirmed" yes/no. - For each finding:
- The problem in two or three STE sentences.
- A concrete failure scenario: what the user does, and what goes wrong.
- The code snippet from the diff (a few lines). The user cannot click into the PR's diff from the local checkout, so show the code here.
- A suggested fix. Use a GitHub
```suggestionblock when the fix is a small change to the commented lines.
- Separate short lists: "Copilot already raised", "existing bugs, not from this PR", "questions for product".
- A recommendation: approve, comment, or request changes, with one sentence why.
Then stop and wait for the user to choose, for example "post 1–3", "post all but the low ones", "request changes".
7. Posting
Post the comments the user picked as one review with inline comments:
gh api repos/wikimedia/wikipedia-ios/pulls/<N>/reviews --method POST --input review.jsonreview.json holds commit_id (the PR head SHA), event (COMMENT unless the user said REQUEST_CHANGES or APPROVE), an optional short body, and comments: [{path, line, side: "RIGHT", body}]. Use start_line for a multi-line comment. The line must be a line in the PR diff. Otherwise GitHub rejects the whole review. Write the file to the scratchpad, not the repo.
Each comment body: the problem, the failure scenario, and the fix or a suggestion block. No "nit" label. No AI attribution line. After posting, give the user the review URL.
8. Re-review
When the user asks "was the PR updated?" or "re-review":
- Find your last review and its commit (
gh api .../pulls/<N>/reviews). List the commits after it. Ignore merge commits from main. - Give a status table for each earlier comment: fixed (with the commit), answered (quote the author's reply in a few words), or still open. Check the reply. If the author is right, say that the comment was wrong.
- Review only the new changes, with the same rules. Show a preview again.
- Report the CI state (
gh pr checks <N>).
9. Manual test steps
When the user asks for test steps, give one simple numbered list for the PR. Cover only what the PR changes. Leave out existing bugs. State the device or setting each step needs (VoiceOver on device, Dynamic Type AX sizes, dark theme, RTL language, iPad, iPhone SE).
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

