agentleFS
Sign inStart free
vscarpentervscarpenter/gsd-task-manager/.agents/skills/source-command-qcheck/SKILL.md

source-command-qcheck

Skill40 starsChanged 39 days agoMITView on GitHub

Skeptical staff-engineer code review of changed files against coding-standards.md.

The file

We split this skill into the rules it gives an agent

3 rules. About 0 are common, 1 is distinctive, and 2 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈1

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Use this skill when the user asks to run the migrated source command qcheck.

    line 8
  2. Distinctive:

    Run git status and git diff first to see what has changed.

    line 14
  3. Very specific:

    Do not rewrite the code. Return a structured list of findings, organized by file, with file:line — issue — fix.

    line 32

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

source-command-qcheck

Use this skill when the user asks to run the migrated source command qcheck.

Command Template

Review all changed files in this session as a skeptical staff engineer for the gsd-taskmanager codebase. Apply the full coding-standards.md and AGENTS.md rules.

Run git status and git diff first to see what has changed. Then evaluate each changed file against:

  1. Standards compliance — The limits in coding-standards.md Part 3 (functions ≤40 lines, files ~400 lines, ≤3 nesting levels, no magic numbers), descriptive naming.
  2. Type safety — All function signatures typed, no any without justification, Zod validation at boundaries (user input, import, MCP tool inputs).
  3. TDD evidence — Were tests written first? Check git log if uncertain. Each new behavior should have a behavior-named test.
  4. Test quality — Positive AND negative cases. Coverage ≥80% for changed files. Independent tests (no shared mutable state). Mocks at boundaries, not deep.
  5. Error handling — Typed errors, no swallowed exceptions, toast.error() from sonner instead of window.alert().
  6. Project-specific gotchas:
    • PocketBase: client_updated_at (not updated) in sort/filter, _superusers admin endpoint, 100ms push throttle, batch lookups not N+1.
    • Schema: .safeParse() (not .parse()) on user input paths; import uses .strip(), export uses .strict().
    • Tests: bun run test (not bun test); localStorage.removeItem(key) (not clear()).
    • UI: toast.error() (not alert()); WCAG AA baseline from CLAUDE.md Design Context.
  7. Security — Input validation, no committed secrets, parameterized queries, least privilege.
  8. Observability — Structured logging via lib/logger.ts, no console.* in production paths, no PII in logs.
  9. Exit checklist — Every box for the task's tier in coding-standards.md Part 7 "Tiered Exit Checklists".

Distinguish blocking issues from suggestions. Prefix non-blocking comments with nit: or suggestion:.

Do not rewrite the code. Return a structured list of findings, organized by file, with file:line — issue — fix.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

Check your setup, free