rtl-review
Skill2.4k starsChanged 7 days agoApache-2.0View on GitHub
Review checklist for Vortex RTL changes under hw/rtl, hw/dpi, hw/unittest and hw/scripts. Use together with code-review whenever a diff touches SystemVerilog, an interface, VX_gpu_pkg, a library module or the synthesis flow.
Trending
More talk lately.thin dataabout the whole repository
Who's talking about vortexgpgpu/vortex
- A Hacker News story“Open source RISC-V GPGPU”Hacker News · Nov 30, 2021 · 207 points
- A Hacker News story“Vortex RISC-V Gpgpu”Hacker News · Oct 22, 2021 · 3 points
- hughperkins/VeriGPU“Network on a Chip (NoC) implementation”GitHub · Apr 7, 2022 · 1 reactions
- vortexgpgpu/mesa“Clarifying current gfx status and some graphic driver issues”GitHub · Nov 10, 2026
- Luminous-Dynamics/symthaea“docs(computers): define shared phone laptop CPU GPU frontier”GitHub · Oct 22, 2026
The biggest 5 of 13 mentions linking to the repository that our crawl found. Each line is their own headline.
See all 13
Talked about on GitHub and Hacker News (13 times).
On GitHub · 11
- Apr 7, 2022Network on a Chip (NoC) implementation — hughperkins/VeriGPU1 reaction · 3 comments
- Nov 10, 2026Clarifying current gfx status and some graphic driver issues — vortexgpgpu/mesa0 reactions
- Oct 22, 2026docs(computers): define shared phone laptop CPU GPU frontier — Luminous-Dynamics/symthaea0 reactions
- Sep 15, 2026Support Vortex RISC-V GPGPU — vishruth-thimmaiah/segfault260 reactions · 1 comment
- Jul 7, 2026Assigment 4 Unable to Locate Files — vortexgpgpu/vortex_tutorials0 reactions
6 more on GitHub
- May 9, 2026Vortex 相关 — cisen/blog0 reactions
- Mar 4, 2026Add Vortex GPGPU — VLSIDA/HighTide0 reactions
- Oct 21, 2025Conflicting names between Matrix Jobs — Udit8348/gha-workflows0 reactions
- Oct 18, 2025[GPGPU] SIMT-based accelerator thread — squeakbug/soc-build0 reactions
- Oct 16, 2025Build PoCL for vortex from source — vortexgpgpu/pocl0 reactions · 2 comments
- Oct 12, 2024Any link_design equivalent or alternative? — YosysHQ/yosys0 reactions · 2 comments
On Hacker News · 2
- Nov 30, 2021Open source RISC-V GPGPU207 points · 58 comments
- Oct 22, 2021Vortex RISC-V Gpgpu3 points
In this repository4 other files it gives its agents.
- AGENTS.mdAGENTS.md
- CLAUDE.mdCLAUDE.md
- code-reviewSkill
- simx-reviewSkill
The file
We split this skill into the rules it gives an agent
2 rules. About 0 are common, 1 is distinctive, and 1 is very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈1
Distinctive · estimate
This author's own choices. Worth a look.
1
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 54
No blanket verilator lint_off.
- Distinctive: line 57
No comment that names SimX, the runtime, a task, a PR or a fix.
≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Reviewing Vortex RTL
Load docs/coding_guidelines_verilog.md, docs/hardware_library.md and
AGENTS.md §4–§6 first. Each item below is a rule from those documents or a
failure the project has had; cite the rule in the finding.
Contracts
- Interfaces (
hw/rtl/interfaces/): a new or changed signal or modport changes every master and slave. Find every instantiation (grep -rn "<name>_if") and check each one drives or consumes it. VX_gpu_pkgstructs: a field change moves every packed slice that indexes it, the trace macros that print it and the SimX mirror. Check widths that depend onVX_CFG_*at the extremes the toml allows (1 lane, max lanes, XLEN 64).VX_types.toml: a CSR, DCR, opcode or memory-map value is shared with SimX, the runtime, the kernel library and LLVM. All change together.VX_CFG_*come fromVX_config.tomlonly; noifndef/definefallback in RTL.
Handshakes and ownership
- valid/ready:
validmust not depend combinationally onreadyof the same interface; data holds whilevalid && !ready; nothing is dropped or duplicated on a stall. Look for a fire condition that ignoresready. - The module that drives an interface registers it at its own output (
*_OUT_BUF,VX_elastic_buffer, a bus slice); no consumer or routing parent re-registers an interface it does not own (guidelines §4). - Reset: every state register that gates
validresets; a partial reset is stated and safe. - Arbiters and round-robin: check fairness under a held request, and that a grant cannot change while the winner is stalled unless the protocol allows it.
- Tags and IDs: a response tag is wide enough for every outstanding request (MSHR, bank, port index), for read and write paths alike.
Library and memories
hw/rtl/libs/is shared IP. A change there needs an equivalence argument for every existing user, or a new parameter that keeps the old behavior.- Memories go through
VX_dp_ram/VX_sp_ram; their address must stay computable by the RAM fold (guidelines §11).VX_dp_ramandVX_sp_ramevolve together. - Assertions (
RUNTIME_ASSERT) qualify onvalidso X or idle data cannot fire them.
Style rules that hide bugs
begin/endon every branch and loop; generate blocks labelledg_*.- No blanket
verilator lint_off;UNUSED_*per signal. - One port or parameter per line in declarations and instantiations.
TRACEarguments comma-separated.- No comment that names SimX, the runtime, a task, a PR or a fix.
Timing and area
- A change to a pipeline, arbiter, queue, interface or datapath can add logic
levels: the PR shows Beacon (
ci/logic_gate.py -b <dut> --against <parent>) clean, or the reason a unit got deeper. Baselines underci/baselines/synthesis/are re-recorded by a human running the gate's--update-baseline, never by an agent or CI, and never edited. - FPU latency changes move
C_Latency,VX_CFG_*_LATENCYand SimX together. - A new DUT or a renamed one is updated in both
hw/syn/{xilinx,yosys}/dut/catalog.mk.
Lockstep with SimX
- A change that moves cycles (pipeline depth, arbitration, queue depth, cache
or memory behavior) lands with the SimX timing-model change, and a
model_paritycase exercises it. Never widen a parity tolerance to absorb a gap. - A change that should not move cycles says which parity or perf case shows that it did not.
Coverage
- RTL coverage is
xrt, not onlyrtlsim, for anything at the AFU or host surface (hw/rtl/afu/). - A bug fix adds the case that failed before it (
docs/bug_fixes.md§4).
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

