agentleFS
vllm-projectvllm-project/router/.agents/skills/precheck-pr/SKILL.md

precheck-pr

Skill504 starsChanged 34 days agoApache-2.0View on GitHub

Contributor self-review for vllm-project/router. Use before implementing a contribution and before opening a PR to establish human intent, decide whether a PR is needed, and verify scoped evidence. Does not post or change files.

1 other project uses a version of this, 1 of them edited.

Adopted by

Most recently taken up by

  • Other versions1 project uses a version of this.

    Word for word · 0

    None found.

    Edited · 1

    1. vllm-project/vllm-omni★ 7.6k31% same

    Wrote their own version · 0

    None found.

    How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.

The file

We split this skill into the rules it gives an agent

7 rules. About 0 are common, 7 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈7

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run this gate before implementing a contribution and again before submission if its intent or scope has changed.

    line 10
  2. Distinctive:

    Before submission, verify that the PR description answers all four required questions in the PR template, or provides public-safe …

    line 28
  3. Distinctive:

    Do not treat a plausible diagnosis or an unexecuted reproducer as verified failure evidence.

    line 46
  4. Distinctive:

    Keep the answers and their source in the self-review report.

    line 50
  5. Distinctive:

    Read CONTRIBUTING.md and the repository's development instructions.

    line 56
  6. Distinctive:

    Run the applicable repository checks and the regression or measurement that demonstrates the intended outcome.

    line 60
  7. Distinctive:

    Stop after the contributor report.

    line 67

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Contributor pre-check

Contributor intent gate

Run this gate before implementing a contribution and again before submission if its intent or scope has changed. It applies to contributor self-review, not independent review of somebody else's PR or automated review selection.

The human contributor must explicitly answer these four questions:

  1. What outcome do you want to achieve?
  2. What is the highest-leverage variable for that outcome?
  3. How will this work move that variable?
  4. Whose customer or user needs does this address, and what are those needs?

Reuse explicit human answers already supplied for this task or in its issue; do not ask the contributor to repeat them. An agent must not invent answers, infer approval from a diff, or fill gaps with its own rationale. Ask the human for any missing or materially ambiguous answers and wait before implementing or submitting the contribution. Read-only investigation may continue to make the questions concrete.

Before submission, verify that the PR description answers all four required questions in the PR template, or provides public-safe references to the human's explicit answers. Blank sections, unchanged placeholders, and agent-written guesses do not satisfy the gate. Missing or ambiguous answers block submission and readiness for review; ask the human and wait. This is a contributor workflow requirement, not a claim that GitHub or CI mechanically enforces the template.

Once the answers are clear, ask whether achieving the outcome actually needs a PR. Prefer an existing capability, configuration change, documentation or support answer, or no change when that meets the need. Documentation changes may themselves need a PR. If no PR is needed, stop the submission workflow and explain the smaller next step. If a PR is needed, connect its narrow scope and validation plan to the human's stated outcome and variable.

For a bug fix, establish an actual failure: record expected versus observed behavior, the affected revision and environment, and supporting evidence such as a minimal reproducer, failing regression test, or observed failure trace. Do not treat a plausible diagnosis or an unexecuted reproducer as verified failure evidence. If the failure is not established, report the evidence gap and continue investigation rather than claiming a confirmed fix.

Keep the answers and their source in the self-review report. Do not copy private task conversations into a public issue or PR; share an intent summary only within the audience and information-sharing scope the human authorized.

Pre-submit self-review

  1. Read CONTRIBUTING.md and the repository's development instructions. Freeze the target base and proposed head revision.
  2. Inspect the complete proposed diff. Keep changes focused on the agreed outcome and preserve unrelated work.
  3. Run the applicable repository checks and the regression or measurement that demonstrates the intended outcome. Record commands, revisions, environment, expected and actual results, and checks that could not run.
  4. Report intent completeness, PR necessity, bug evidence when applicable, changed scope, validation, and remaining blockers. Missing human intent blocks implementation/submission; missing evidence must not become a pass.

Stop after the contributor report. This skill does not modify files, open PRs, post comments, or authorize publication. Maintainer review and existing repository checks remain separate requirements.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.