agentleFS
tuanductrantuanductran/hr-skills/.agents/skills/dry-refactoring/SKILL.md

dry-refactoring

Skill58 starsChanged 2 months agoMITView on GitHub

Guided workflow to eliminate copy-paste duplication in packages/hr-skills-build and packages/hr-skills-ref, detected by jscpd. Extract shared functions, constants, and types into their own files instead of growing an existing one.

2 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

10 rules. About 0 are common, 2 are distinctive, and 8 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 8

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Run jscpd first — see jscpd for the exact command this repo uses:

    line 15
  2. Very specific:

    Run jscpd, scoped to packages/ only (never skills/, see the jscpd skill for why).

    line 23
  3. Distinctive:

    Read both code fragments and understand what they do — don't refactor blind.

    line 25
  4. Very specific:

    Run bun run typecheck and bun run test (repo-wide or --filter to the affected package — see turbo).

    line 28
  5. Very specific:

    Before extracting, grep -rn "export (const|function|type|interface) <name>" packages for the name you're about to reuse.

    line 51
  6. Very specific:

    Prefer a more specific name over a generic one (e.g.

    line 53
  7. Distinctive:

    If both are genuinely the same concept split across two files, that's itself a duplication signal — consolidate into one export instead of …

    line 54
  8. Very specific:

    Avoid the template/base class strategy in this codebase unless a real inheritance hierarchy already exists — this repo favors small …

    line 66
  9. Very specific:

    All call sites updated, not just the two jscpd reported — grep for other near-identical blocks jscpd's thresholds may have missed.

    line 70
  10. Very specific:

    If the duplication is between packages/hr-skills-build and packages/hr-skills-ref, check whether a changeset is needed — see changeset.

    line 73

≈ “Common” is an estimate: at least 1 in 5 of the 372,429 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

dry-refactoring

Guided workflow to eliminate copy-paste duplication in packages/* TypeScript source. Use after jscpd has produced a clone list.

Prerequisites

Run jscpd first — see jscpd for the exact command this repo uses:

bunx jscpd@5 packages --reporters ai --format typescript

Workflow

  1. Run jscpd, scoped to packages/ only (never skills/, see the jscpd skill for why).
  2. Parse each clone line to identify the two duplicated locations (file + line range).
  3. Read both code fragments and understand what they do — don't refactor blind.
  4. Decide the refactor target using the placement rules below.
  5. Extract the shared logic; update all call sites, not just the two jscpd reported.
  6. Run bun run typecheck and bun run test (repo-wide or --filter to the affected package — see turbo).
  7. Re-run jscpd to confirm the clone is gone.
  8. Repeat, highest-impact cluster first (most repeated pattern, not just the first line in the report).

Where extracted code goes in this repo

This repo separates code by surface and domain under packages/hr-skills/src/cli/, packages/hr-skills-build/src/client/, packages/hr-skills-build/src/server/, packages/hr-skills-ref/src/client/, and packages/hr-skills-ref/src/server/. Follow that structure — don't dump extracted helpers into whichever file happens to be open:

  • Duplicated logic used by 2+ files in the same domain folder (e.g. two files under src/server/validation/) → new file in that same folder, e.g. src/server/validation/security-helpers.ts, imported by both.
  • Duplicated logic used across domain folders (e.g. src/server/build/* and src/server/evaluation/*) → src/server/shared/, alongside the existing shared/constants.ts, shared/helpers.ts, shared/schema.ts, shared/types.ts.
  • Duplicated logic across packages (hr-skills-build and hr-skills-ref both define it) → do not create a third copy in either package. Prefer keeping a single canonical definition in the package it conceptually belongs to (hr-skills-ref for skill-file parsing primitives, hr-skills-build for build/registry/CLI concerns) and importing it from the other, or promote it to a small shared internal package if both genuinely need to own it independently. Never resolve this by copy-pasting into a third location.
  • Intentional client/server duplication → each public surface must remain self-contained. If sharing a module would create a client/server import edge, keep separate surface-local implementations and test both surfaces instead.
  • Constants → their own constants.ts in the relevant folder; don't fold them into a file that already holds functions or types.
  • Types/interfaces → their own types.ts (or *.types.ts if types.ts already exists and would grow unrelated concerns) in the relevant folder — never appended to a functions file "for now."

Naming collisions

Before extracting, grep -rn "export (const|function|type|interface) <name>" packages for the name you're about to reuse. If a same-named export already exists elsewhere in the monorepo:

  • Prefer a more specific name over a generic one (e.g. parseSkillFrontmatter over parse) rather than renaming the existing export and risking unrelated churn.
  • If both are genuinely the same concept split across two files, that's itself a duplication signal — consolidate into one export instead of two similarly-named ones.

Refactoring strategies

Extract function — duplicate is a block of logic → shared function, called from both places.

Extract module — duplicate spans multiple files in the same or related domains → shared file per the placement rules above, imported by all call sites.

Extract constant — duplicate is repeated literal data or config → named constant in the domain's constants.ts.

Extract type/interface — duplicate or near-duplicate shape appears in two files → single definition in the domain's types.ts, both files import it.

Avoid the template/base class strategy in this codebase unless a real inheritance hierarchy already exists — this repo favors small composable functions and Valibot schemas (see valibot) over class hierarchies.

Tips

  • All call sites updated, not just the two jscpd reported — grep for other near-identical blocks jscpd's thresholds may have missed.
  • Tests still pass after refactoring (bun run test), and bun run typecheck is clean.
  • The extracted abstraction has a clear, descriptive name — see naming collisions above.
  • If the duplication is between packages/hr-skills-build and packages/hr-skills-ref, check whether a changeset is needed — see changeset.
  • Format with Biome after refactoring (bun run format or let lefthook catch it on commit) — see biome.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.