agentleFS
timothywarner-orgtimothywarner-org/claude-code/.claude/skills/review-changes/SKILL.md

review-changes

Skill223 starsChanged 4 months agoMITView on GitHub

Review uncommitted local changes in the current git working tree for bugs, smells, missing tests, and CLAUDE.md voice violations. Use when the user asks to "review my changes", "look at my diff", "check my staged changes", "code review my working tree", or wants a sanity check before committing or opening a PR. Do NOT use for already-open pull requests on GitHub (that's the separate `review` command).

34 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use explore-codebase, debug-issue and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • srclightSkill

    explore-codebase

    This skill should be used when the user asks to "explore this codebase", "understand this project", "give me an overview", "how does this work", "onboard me", "walk me through the architecture", "map the codebase", or any request to understand a codebase's structure, architecture, or design.

    Also in 4 projects that use this

  • NVIDIASkill

    debug-issue

    Use when the user asks to debug, investigate, or fix a GitHub issue or supplies a repository bug report.

    Also in 4 projects that use this

  • srclightSkill

    refactor-safely

    This skill should be used when the user asks to "refactor", "rename", "move", "change a function signature", "extract a method", "delete unused code", "clean up", or any modification that could break callers or dependents. Provides a pre-change safety checklist using srclight's graph tools to assess blast radius before touching code.

    Also in 4 projects that use this

  • JetBrainsSkill

    fix-bug

    End-to-end bug fix workflow for the Exposed project. Accepts a GitHub issue (#NUMBER), YouTrack issue (EXPOSED-NUMBER), or YouTrack URL (https://youtrack.jetbrains.com/issue/EXPOSED-NUMBER). Fetches the issue, creates a failing reproducer test, commits on a new branch, implements the fix, validates, and opens a PR. Use this skill whenever the user wants to fix a bug from an issue tracker, mentions a EXPOSED issue number, or references a GitHub issue to fix.

    Also in 3 projects that use this

  • SentrySkill

    write-tests

    Write tests following project conventions. Use when adding new tests or modifying existing ones.

    Also in 3 projects that use this

  • GitHubSkill

    refactor

    Surgical code refactoring to improve maintainability without changing behavior. Covers extracting functions, renaming variables, breaking down god functions, improving type safety, eliminating code smells, and applying design patterns. Less drastic than repo-rebuilder; use for gradual improvements.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 3 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 33 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    No AWS references: Not in code, not in comments, not in docs.

    line 37
  2. Very specific:

    No console.log in shipped JS/TS: Test files and demos in segment_*/ are fine.

    line 39
  3. Distinctive:

    Azure-first for cloud examples: Never compare to other clouds.

    line 45
  4. Distinctive:

    If the diff is empty, say so and stop.

    line 62

“Common” is measured: kept by at least 6 in 10 of the 33 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review uncommitted changes

The current diff, status, and recent history are inlined below. Read them before responding.

Working tree diff

git diff HEAD

Index + working tree status

git status --short

Last 5 commits (for tone and style reference)

git log -5 --oneline

Your task

Review the changes above. Flag bugs, anti-patterns, missing tests, and any violation of this repo's voice rules. Be terse, be honest, no glazing.

Hard checks (block-on-find)

  1. No em dashes. Hyphens with spaces, commas, or periods only.
  2. Never use "ask" as a noun. "A heavy ask" is a rewrite.
  3. No AWS references. Not in code, not in comments, not in docs.
  4. No hardcoded secrets. Flag any string that looks like an API key, token, or password.
  5. No console.log in shipped JS/TS. Test files and demos in segment_*/ are fine.

Soft checks (note, don't block)

  1. Comments explain WHY, not WHAT. Code shows what; comments justify design.
  2. PowerShell-first for shell scripts. Bash is the fallback.
  3. Azure-first for cloud examples. Never compare to other clouds.
  4. Docstrings/JSDoc on every new function or PowerShell script.
  5. Idempotent re-runs where state mutation is involved.

Report format

## Blockers
- file:line - issue - proposed fix

## Soft findings
- file:line - note

## What's working
- one or two things the diff got right (keep it brief, no glazing)

If the diff is empty, say so and stop. Do not invent findings.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.