adding-mcp-tools
Skill2 starsChanged 47 days agoMITView on GitHub
Adds or changes a tool, prompt or resource in Teitunnel's MCP server (crates/mcp), including its argument schema, safety class and hints, the Backend method in core_backend.rs, the fake backend, tool-count tests and the AI agents docs. Use when AI agents need a new capability or an existing MCP tool changes behaviour.
In this repository11 other files it gives its agents.
- AGENTS.mdAGENTS.md
- CLAUDE.mdCLAUDE.md
- adding-cli-commandsSkill
- adding-doctor-checksSkill
- adding-ipc-commandsSkill
- building-uiSkill
- changing-cloudflare-resourcesSkill
- reviewing-pull-requestsSkill
- verifying-changesSkill
- writing-docsSkill
- writing-user-facing-textSkill
The file
We split this skill into the rules it gives an agent
4 rules. About 0 are common, 1 is distinctive, and 3 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈1
Distinctive · estimate
This author's own choices. Worth a look.
3
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 31
Bounded: Every tool has a timeout; list results are paginated or capped.
- Very specific: line 97
Add the name to the match in crates/mcp/src/tools.rs that routes calls to the area module.
- Very specific: line 109
Update the tool counts: assert_eq!(tools.len(), …) in crates/mcp/src/protocol_tests.rs and assert_eq!(names.len(), …) in …
- Very specific: line 120
Run pnpm verify. To try it by hand, run teitunnel mcp --help and connect an MCP client to a development build.
≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Adding an MCP tool
Teitunnel's MCP server (crates/mcp) lets AI agents use Teitunnel. It's served over stdio by
teitunnel mcp and over Streamable HTTP by teitunnel serve. Agents are powerful and can be
misled by what they read, so every tool is designed for safety first.
Rules
- Secrets never reach the agent. Tokens, keys and credentials are never arguments or
results. Captured traffic is masked (
redaction.rs) unless the server runs with--allow-secrets. - Changes wait for the person. A tool that changes something is
ToolClass::ChangeorToolClass::Destructive; inaskmode it callsctx.approve(&ApprovalRequest { … })before changing anything, and onApproval::NeedsConfirmationreturns itsneedsApprovalanswer without side effects: the server may replace that answer with an MRTR question or an "open Teitunnel" error (Heldinregistry.rs), so the tool never needs to know how the person is asked.Approval::by_person(how)tells a person's answer (app,client) frommodeorconfirmed. A Cloudflare change returns a plan and is applied withapply_planafter approval; it never calls the API directly (seechanging-cloudflare-resources). - Outside content is data. A tool whose results carry text anyone could have written
(captured traffic, comments, logs, fetched pages) ends its spec with
.with_untrusted(): the server addsuntrusted: trueand fences the text. - Errors. Bad arguments are a
ToolError(the model reads it and corrects itself); only an unknown tool is a protocol error, and the server handles that. - Bounded. Every tool has a timeout; list results are paginated or capped.
Checklist
- [ ] 1. Behaviour in crates/core, tested there
- [ ] 2. Backend method (backend.rs) with an Unsupported default
- [ ] 3. Implemented in core_backend.rs, and in FakeBackend (tools/tests.rs)
- [ ] 4. Args and result types with JsonSchema and doc comments
- [ ] 5. spec::<Args, Result>(…) in the area's tools/<area>.rs
- [ ] 6. Dispatched in tools.rs
- [ ] 7. Tests, including the tool counts
- [ ] 8. Docs: ai-agents.mdx and the product skill
- [ ] 9. pnpm verify2–3. Backend
Backend (crates/mcp/src/backend.rs) is what tools call. Add a method with a default that returns
Unsupported, so other backends keep compiling. Implement it in CoreBackend
(crates/mcp/src/core_backend.rs) by calling teitunnel_core, and in FakeBackend
(crates/mcp/src/tools/tests.rs) with deterministic data for tests.
4. Arguments and results
/// Which route, over how long.
#[derive(Debug, Deserialize, JsonSchema)]
#[serde(rename_all = "camelCase", deny_unknown_fields)]
pub(crate) struct RouteTrafficArgs {
/// The route's or share's hostname.
hostname: String,
/// Only requests under this path (`/api`), for a route with a path rule.
#[serde(default)]
path: Option<String>,
}Doc comments become the JSON schema descriptions the agent reads: make each one precise,
with units and defaults. Use deny_unknown_fields, camelCase, and validated types
(hostnames, ports) rather than free strings where the core has them.
5. The spec
spec::<RouteTrafficArgs, RouteTrafficResult>(
"route_traffic",
"Route traffic",
"What it returns and where the numbers come from.\n\
\n\
Use it for \"how much traffic does my site get?\". For single requests use traffic_list.\n\
\n\
Example: {\"hostname\": \"app.teispace.com\", \"range\": \"day\"}",
ToolClass::Read,
Hints::READ_CLOUD,
Duration::from_secs(60),
),The description is the agent's only manual. Write it as: what it does → when to use it (and
which neighbouring tool to use instead) → one example call. Pick the class honestly:
Read, Wait (blocks until something happens, bounded), Change (additive or reversible),
Destructive (removes or replaces).
6. Dispatch
Add the name to the match in crates/mcp/src/tools.rs that routes calls to the area module.
7. Tests
- A test calling the tool through the fake backend: arguments, result shape, and the error
for invalid input (see
crates/mcp/src/tools/tests.rsandcrates/mcp/src/protocol_tests.rs). - A change tool: a test that it asks for approval in
askmode and is refused inread-onlymode.tools::tests::settings(mode)turnsapproveInAppoff, so the tool's ownneedsApproval/confirmed: trueround trip is what's tested; how the server asks (app, MRTR, elicitation) is tested inprotocol_tests.rs. protocol_tests::the_tool_list_stays_smallbounds thetools/listsize and each description's length: keep descriptions to what the model needs.- Update the tool counts:
assert_eq!(tools.len(), …)incrates/mcp/src/protocol_tests.rsandassert_eq!(names.len(), …)inapps/cli/tests/mcp.rs.
8. Docs
- The tool table in
apps/web/content/docs/guides/ai-agents.mdx. - The Agent Skill users give their agents,
apps/web/public/skills/teitunnel/SKILL.md, when the tool changes how an agent should work with Teitunnel.
9. Verify
Run pnpm verify. To try it by hand, run teitunnel mcp --help and connect an MCP client to
a development build.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

