agentleFS
svyatovsvyatov/supermatt/skills/fix-findings/SKILL.md

fix-findings

Skill20 starsChanged 52 days agoMITView on GitHub

Apply every finding from the most recent review, audit, verification, or check in this session.

8 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use codex-review.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • juriwiensSkill

    codex-review

    Run code review via Codex CLI

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 1 is distinctive, and 2 are very specific to this project.

  • 0

    Common

    Most of the 7 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    No such report in this session and no finding text in the arguments: say so and stop.

    line 11
  2. Very specific:

    Before the first edit in each affected repository, discover and read its applicable AGENTS.md, CLAUDE.md, and CONTRIBUTING.md, including …

    line 12
  3. Very specific:

    Do not commit. The user commits with /commit or /ship-pr in Claude linked installs or Cursor, /supermatt:commit or /supermatt:ship-pr from …

    line 18

“Common” is measured: kept by at least 6 in 10 of the 7 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Apply the findings from the most recent review, audit, verification, lint run, test run, or other check reported earlier in this session, whatever produced it. Arguments that name findings (codes or numbers) narrow which ones; arguments that carry a finding's own text are the report, even when it came from another session. No arguments means every finding, at every severity. A finding the report left as a choice for the user: apply the option the arguments name, else the one the report recommended in so many words ("I recommend X"), worded exactly as it was offered. An option listed first or labelled "proposed" is not a recommendation. With none named, apply no option: ask the caller which one to take, and report the finding as <code>: pending, <the choice it waits on> until the caller answers. The out-of-scope deferral in step 4 is the one open choice with its own form, <code>: deferred, follow-up pending.

  1. No such report in this session and no finding text in the arguments: say so and stop. Do not go looking for problems to invent.
  2. Before the first edit in each affected repository, discover and read its applicable AGENTS.md, CLAUDE.md, and CONTRIBUTING.md, including any instructions they point to. Repeat this before touching another repository. Record absent instruction files separately from a repository whose available instructions document no checks.
  3. Fix root causes, not the symptom each finding names. Grep every caller before editing a shared function: one guard where the callers converge beats a guard in each of them.
  4. Do not expand scope. A finding is a fix, not an invitation to refactor around it. If its fix needs a schema or data migration, a new ADR, or a redesign beyond the branch's change (a new subsystem, scheduler, or cross-module restructuring), check whether the defect already exists at the merge base with the default branch. If it does, the fix is out of scope for this branch: do not apply it. Offer filing a follow-up issue and say "I recommend a follow-up issue". Until the caller chooses, report the finding as <code>: deferred, follow-up pending (this form, not pending, even when the report also left the finding as a choice), and name no issue. When the follow-up is chosen, create it with the Create an issue operation in docs/agents/issue-tracker.md, or gh issue create when that file is missing, including the defect, its evidence, and the proposed fix, then report the finding as <code>: deferred to <issue>. When it is declined, report <code>: deferred, follow-up declined. A defect introduced by this branch is still fixed on the branch, whatever the size, following the rules below. For in-scope findings, when the finding proposes a fix, apply that fix, together with any change it cannot work without, and name that change on the finding's report line. If it cannot work even so, skip the finding and say why instead of choosing another. If it works at only some of the places the finding names, apply it there and report the finding as partly fixed.
  5. For every edited repository, run its required checks and make its other required edits (a version bump, a changelog entry). Done when each edited repository has its checks run, or the report distinguishes unavailable instructions from available instructions that document no checks.
  6. Report one line per finding: <code>: fixed, <code>: partly fixed, <what is left and why>, <code>: pending, <the choice it waits on>, <code>: deferred, follow-up pending, <code>: deferred to <issue>, <code>: deferred, follow-up declined, or <code>: skipped, <why>. Then one line per edited repository with the checks run. Say plainly when a finding was wrong.

Do not commit. The user commits with /commit or /ship-pr in Claude linked installs or Cursor, /supermatt:commit or /supermatt:ship-pr from the Claude plugin, $commit or $ship-pr in Codex, or /skill:commit or /skill:ship-pr in OMP.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.