agentleFS
sumithrsumithr/sumo-qa/skills/sumo-qa-deciding-approach/SKILL.md

sumo-qa-deciding-approach

Skill7 starsChanged 40 days agoApache-2.0View on GitHub

Use first after using-sumo-qa on any QA intent. Loads classifications + approaches (the two needed to route), then reasons over the user's intent to pick the canonical approach and routes to the matching sub-skill (which loads any further catalogues on demand).

The file

We split this skill into the rules it gives an agent

6 rules. About 0 are common, 2 are distinctive, and 4 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 4

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read the user's intent verbatim and any supplied target paths.

    line 24
  2. Very specific:

    Call sumo_qa_load_classifications() and sumo_qa_load_approaches(), this router's own loads (see *Catalogue responsibilities*).

    line 25
  3. Distinctive:

    If a real ambiguity remains (e.g.

    line 30
  4. Very specific:

    When routing to sumo-qa-suggesting-external-skill, next_action ALSO carries entry_kind: "qa" (the conversion entry supplies "conversion".

    line 46
  5. Very specific:

    STOP. Reply in plain English, e.g.

    line 129
  6. Very specific:

    STOP cases have no handoff: no-tests-recommended, and recommend-removal (surface the deletion recommendation — file + reachability evidence …

    line 144

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Deciding the QA approach

This hop is silent. It is internal orchestration: no announcement, checklist, status, taxonomy label, or routing payload reaches the user. Routed: the next skill's answer is the first thing they read. STOP: a short plain-English answer (decision + evidence).

Output discipline (mandatory)

Inherits the global discipline from using-sumo-qa: output discipline (never surface internal taxonomy labels — say "behaviour change in pricing", not "Classification: business_logic_change"), output economy (spend output on findings not framing; no preamble or self-narration; one question per turn; no closing pleasantries), knowledge authority hierarchy, internal scaffolding stays internal, and specialty-tool fit.

The Iron Law

SHAPE FIRST, then REACHABILITY. Decide single-change vs repo-wide vs no-tests-recommended before picking a per-change approach — wrong shape means wrong-shaped tests. When the shape is single-change, check reachability/load-bearing before picking a test-writing approach — orphan code routes to recommend-removal, not test scaffolding.

When to Use

using-sumo-qa routes here on every QA-shaped intent; this skill ALWAYS runs before any other QA skill. Even simple intents pass through — no-tests-recommended and verify-existing exist for cases that don't merit new tests.

Checklist

Work through these in order as private reasoning. Never render them in chat: no numbered tracker, no [DONE] statuses, no step narration. If the host has a task primitive, keep this hop off it; a visible router checklist is the leak this skill exists to prevent.

  1. Read the user's intent verbatim and any supplied target paths.
  2. Call sumo_qa_load_classifications() and sumo_qa_load_approaches(), this router's own loads (see Catalogue responsibilities).
  3. Reason about classification: which single catalogue entry is the PRIMARY one? Decide it by the executable-behaviour rule, not path; cite the words internally. Then run the grounded security-relevance pass (see using-sumo-qa) on ORDINARY work too, not only explicit security requests: if the change ALSO touches auth/authorisation, secrets, input sanitisation, rate limiting, audit logging, or a security-relevant config/dependency movement, note internally that security_change co-applies (it does NOT replace the primary classification) so the routed sub-skill carries that grounded gap forward — no parallel taxonomy; not grounded → don't add it. The routing payload still emits the single primary classification.
  4. Reason about shape: single change vs repo-wide / strategy ask vs config tweak vs docs-only? Strategy-shaped asks ("audit", "strategy", "pyramid", "rollout") route to strategy-orchestration — do NOT force per-change output.
  5. Run the removability gate BEFORE picking a test-writing approach. If the user named target paths and the code is orphaned — zero internal callers, zero CI/workflow refs, zero README/docs refs, no entry-point declaration (pyproject [project.scripts], package.json scripts, etc.) — set the approach to recommend-removal regardless of natural classification, and surface the reachability evidence in the rationale. If reachability is genuinely ambiguous (external cron, hand-invoked tooling, public CLI), ask ONE clarifying question.
  6. Pick the approach. Security-test requests or material grounded security gaps needing deeper evidence route to security-focused-qa; simple gaps stay as test/review/static/dynamic/config/dependency actions. The catalogue is authoritative; use n/a only when no catalogue approach fits and capture the non-canonical surface in rationale.
  7. If a real ambiguity remains (e.g. user said "test the thing" with no paths and no domain), ask ONE clarifying question. Otherwise, do not ask.
  8. Return INTERNALLY using the Routing-payload shape below — routing data the next skill consumes, NOT user output. Route to the named sub-skill silently (security testing: via its bundle); it produces what the user sees. On STOP, answer in plain English instead.

Process Flow

See the Checklist above.

Routing-payload shape

Return exactly these fields internally:

{classification, approach, rationale, next_action: {skill}}

Never emit this object (as JSON or as Classification: / Approach: lines): it is inter-skill data, and a host that echoes it shows raw taxonomy instead of an answer.

  • next_action.skill is NEVER n/a: use a real sumo-qa skill name, or none only for the STOP cases (approach is no-tests-recommended or recommend-removal).
  • When routing to sumo-qa-suggesting-external-skill, next_action ALSO carries entry_kind: "qa" (the conversion entry supplies "conversion"; the skill never infers the mode).
  • classification is n/a only for strategy-orchestration, recommend-removal (action is universal, not change-shaped), or non-canonical external-skill intents. Every catalogue classification uses its verbatim entry (test_change, docs_change, config_change, data_migration, …) — never n/a.
  • approach is n/a only when no canonical approach fits and routing goes to sumo-qa-suggesting-external-skill; strategy intents use approach: "strategy-orchestration". Capture non-canonical detail in rationale — never null or invented values.

Anti-patterns:

  • BAD: classification: "n/a" for a test_change intent (mutation-testing follow-up, raise coverage, strengthen weak assertions). USE: classification: "test_change".
  • BAD: next_action.skill: "n/a" for a STOP case. USE: next_action.skill: "none".

Routing table (approach → next skill)

ApproachNext skill
strategy-orchestrationsumo-qa-strategising
tdd-scaffoldsumo-qa-implementing-with-tdd
regression-firstsumo-qa-implementing-with-tdd
coverage-first-then-refactorsumo-qa-implementing-with-tdd
strengthen-test-coveragesumo-qa-strengthening-tests
closed-loop-gap-fixsumo-qa-closing-qa-gaps
triage-test-failuresumo-qa-triaging-test-failures
security-focused-qasumo-qa-security-testing (one bundle call, below)
verify-existingsumo-qa-reviewing-before-merge
no-tests-recommended(stop — no sub-skill needed)
recommend-removal(stop — propose deletion, no sub-skill)
spike-first-then-testssumo-qa-preparing-for-work (deliverable mode)
n/a (no canonical approach fits; intent involves a non-native tool/surface)sumo-qa-suggesting-external-skill

Catalogue responsibilities (lazy-load contract)

This router's own loads are load_classifications + load_approaches (step 2). Every other catalogue is the routed sub-skill's, loaded on demand; for security testing the handoff itself is one bundle call that enters the skill with its catalogues:

  • sumo-qa-implementing-with-tdd / sumo-qa-strengthening-tests → load_techniques.
  • sumo-qa-reviewing-before-merge → one load_skill_context bundle.
  • sumo-qa-creating-test-plan → load_standards + load_rules + load_techniques + load_principles.
  • sumo-qa-preparing-for-work → load_standards + load_rules + load_techniques.
  • sumo-qa-strategising → load_principles + load_classifications.
  • sumo-qa-answering-testing-question → load_principles + load_techniques.
  • sumo-qa-security-testing → enter via sumo_qa_load_skill_context(skill_name="sumo-qa-security-testing", mode="bundle", classification="security_change", catalogues="techniques") INSTEAD of its skill tool, never both; on an error, call sumo_qa_security_testing.

The router never loads principles: the skill citing one loads it.

Fallback to external skills

When no canonical approach fits, decide whether the intent involves a tool, framework, or QA surface sumo-qa's native skills don't cover — Playwright/Cypress E2E, accessibility audits, k6/Locust load tests, Pact contract tests, flaky-test quarantine. If yes → return classification: "n/a", approach: "n/a", next_action: {skill: "sumo-qa-suggesting-external-skill", entry_kind: "qa"} with the inferred surface in the rationale. If no (it fits a native sub-skill on closer look) → continue native routing.

sumo-qa-suggesting-external-skill drives external-skill search/install/handoff via sumo-qa MCP tools, with [y/N] confirmation before install.

Red Flags

ThoughtReality
"This is obviously TDD"Maybe. Read the user's words and inferred classification first. "Refactor" implies behaviour-preserving — that's coverage-first-then-refactor, not tdd-scaffold.
"I'll skip loading the catalogues this once"Catalogue is the source of truth. Inventing approaches from training data is the failure mode this skill exists to prevent.
"User said 'design our strategy' — I'll still scaffold tests"Strategy asks route to strategy-orchestration. Don't force per-change output.
"Description says docs-only change but I'll add tests anyway"Inert prose: no-tests-recommended is honest senior-QA; tests waste signal. Runtime by the executable-behaviour rule is not.
"Mutation testing follow-up needs new prod code"No — that's strengthen-test-coverage. Production code stays unchanged.
"A test is failing — that's a bug, route to regression-first"Only if the CAUSE is already known to be a product defect. An unknown-cause or flaky failure routes to triage-test-failure first — it may be a test, fixture, environment or timing issue.
"I'll show the routing object / checklist so the user sees my reasoning"Never. The payload, taxonomy labels, "Picking the QA approach…", [DONE] steps, and ANY sentence that names or previews the handoff ("Routing to…", "I'm routing you to…", "the next step will…") are internal state. Route silently; on STOP, answer in plain English.
"I'll ask the user 3 clarifying questions to be sure"Ask ONE if needed; infer the rest.
"User named a file and asked for tests — scaffold" / "orphan code is just no-tests-recommended"Check reachability FIRST. Orphan code (zero callers/CI/docs refs + no entry-point declaration) → recommend-removal — NOT scaffolding, and NOT no-tests-recommended (docs/typos, behaviour-less change). Scaffolding tests on dead code is wasted signal.

Examples

Good

(Every scenario starts by loading classifications + approaches. Every "Internally return" object below is never written into the reply.)

User: "create a test plan for refactoring the pricing pipeline".

  • Internally: refactor of pricing logic — behaviour-preserving, so characterization tests pin behaviour before any code moves.
  • Route to sumo-qa-creating-test-plan (which loads its own catalogues and grounds any principle citation in user-facing output).

User: "audit our test coverage across the repo and design where to invest QA effort next quarter".

  • Internally return {classification: "n/a", approach: "strategy-orchestration", rationale: "Repo-wide QA strategy ask, not a single change-shaped intent.", next_action: {skill: "sumo-qa-strategising"}}.

User: "add end-to-end browser tests with Playwright for checkout".

  • Internally return {classification: "n/a", approach: "n/a", rationale: "Playwright E2E is a non-canonical external QA surface.", next_action: {skill: "sumo-qa-suggesting-external-skill", entry_kind: "qa"}}.

User: "this test keeps failing in CI but passes locally — what's going on?".

  • Internally: a failing/flaky test whose CAUSE is unknown — diagnosis precedes any fix. Not regression-first (presumes a known defect), not closed-loop-gap-fix (no named gap yet).
  • Internally return {classification: "test_change", approach: "triage-test-failure", rationale: "Unknown-cause failure; classify and name the smallest isolation step before any fix.", next_action: {skill: "sumo-qa-triaging-test-failures"}}.

User: "Help me write tests for ./install.sh — nothing references it, no CI uses it, no docs mention it, no entry point points at it."

  • Reachability gate fires: zero callers/CI/docs refs, no entry-point declaration → orphaned.
  • Internally return {classification: "n/a", approach: "recommend-removal", rationale: "install.sh orphaned — no callers/CI/docs/entry-point refs; recommend deletion over scaffolding tests on dead code.", next_action: {skill: "none"}}.
  • STOP. Reply in plain English, e.g. "Delete install.sh: nothing calls it, no CI job runs it, and no docs or entry point mention it." No sub-skill handoff, no payload fields or labels.

Bad

User: "create a test plan for refactoring the pricing pipeline". Pick tdd-scaffold because "test plan" sounds like adding tests. Wrong — refactor needs characterization tests first. SHAPE FIRST was violated by ignoring "refactoring" in the intent.

Next skill in the chain

Route to exactly ONE skill. For approach routes, use the Routing table above. Intent-shaped routing on top of that:

  • "plan QA for this story" → sumo-qa-preparing-for-work; a formal test plan with entry/exit criteria → sumo-qa-creating-test-plan.
  • generic "how do I test X" → sumo-qa-answering-testing-question; test-data-shaped → sumo-qa-finding-test-data.
  • an unknown-cause failing or flaky test ("why does this keep failing", "red in CI, green locally") → triage-test-failure → sumo-qa-triaging-test-failures (diagnose before any fix).
  • work with 3+ independent dispatchable tasks → sumo-qa-planning-qa-rollout.

STOP cases have no handoff: no-tests-recommended, and recommend-removal (surface the deletion recommendation — file + reachability evidence + supplanting alternative if known — in the user-facing reply, as plain prose with no taxonomy labels or payload fields).

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.