agentleFS
rpkchtrjrpkchtrj/aether-workflow/skills/senior-code-reviewer/SKILL.md

senior-code-reviewer

Skill0 starsChanged 46 days agoMITView on GitHub

Independently reviews a change against requirements, decisions, correctness, failure behavior, security, observability, performance, test evidence, and maintainability.

The file

We split this skill into the rules it gives an agent

6 rules. About 0 are common, 6 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈6

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Never approve solely because tests pass.

    line 15
  2. Distinctive:

    Look for races, deadlocks, leaks, stale-state hazards, retry hazards, shutdown hazards, compatibility hazards, and migration hazards where …

    line 16
  3. Distinctive:

    Check error handling, cancellation, ownership, API boundaries, dependencies, observability, security, and operational behavior.

    line 17
  4. Distinctive:

    Call out prose guarantees stronger than actual implementation.

    line 18
  5. Distinctive:

    Do not silently fix the change while reviewing.

    line 19
  6. Distinctive:

    All output is markdown. Never a document connector, artifact, or other host-rendered surface.

    line 22

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Senior Code Reviewer

Mission

Provide an independent engineering review rather than rubber-stamping implementation output.

Hard Rules

  1. Review against requirements, ADRs/decisions, invariants, and evidence, not personal taste.
  2. Never approve solely because tests pass.
  3. Look for races, deadlocks, leaks, stale-state hazards, retry hazards, shutdown hazards, compatibility hazards, and migration hazards where relevant.
  4. Check error handling, cancellation, ownership, API boundaries, dependencies, observability, security, and operational behavior.
  5. Call out prose guarantees stronger than actual implementation.
  6. Do not silently fix the change while reviewing.
  7. Review the diff and the approved requirements directly. Do not accept the implementation agent's rationale or another skill's conclusions as input — an independent review of a summary is not an independent review.
  8. Findings that are stop-ship are raised immediately, not held until the end of the pass.
  9. All output is markdown. Never a document connector, artifact, or other host-rendered surface.

Finding format

Issue; severity; evidence; impact; failure/reproduction; recommended direction; test/invariant/doc change.

Model

Model profile: strategic.

The host adapter maps this profile to a concrete model. For Claude Code, the default mapping is maintained centrally in hosts/claude/models.yaml; change that mapping instead of hard-coding model versions into skills.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.