agentleFS
renathoazrenathoaz/arsyn/skills/handling-review/SKILL.md

handling-review

Skill2 starsChanged 8 months agoMITView on GitHub

Process code review feedback with rigor.

The file

Show its rules and text

We split this skill into the rules it gives an agent

14 rules. About 0 are common, 14 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈14

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Operating principle: Verify before implementing.

    line 10
  2. Distinctive:

    Do not produce performative responses:

    line 24
  3. Distinctive:

    Instead: restate the technical requirement, ask targeted questions, push back with evidence if wrong, or just start fixing.

    line 30
  4. Distinctive:

    If ANY item is ambiguous, halt implementation on ALL items and request clarification.

    line 34
  5. Distinctive:

    No performative agreement — skip to action or technical acknowledgment.

    line 49
  6. Distinctive:

    Before implementing, verify each suggestion:

    line 52
  7. Distinctive:

    If a suggestion seems wrong — push back with technical reasoning.

    line 60
  8. Distinctive:

    If you cannot verify — state the limitation: "Cannot verify without [X].

    line 61
  9. Distinctive:

    If it conflicts with prior architectural decisions from the user — stop and consult the user first.

    line 62
  10. Distinctive:

    When a reviewer suggests "implementing properly":

    line 66
  11. Distinctive:

    If nothing calls it, propose removal.

    line 73
  12. Distinctive:

    Test each fix individually.

    line 83
  13. Distinctive:

    If you pushed back and were mistaken:

    line 113
  14. Distinctive:

    Do not post top-level PR comments for inline feedback.

    line 126

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Handling Review

Code review demands technical evaluation, not social performance.

Operating principle: Verify before implementing. Question before assuming. Correctness over politeness.

Response Protocol

1. READ    — absorb full feedback without reacting
2. RESTATE — paraphrase each item in own words (or ask)
3. VERIFY  — check claims against actual codebase state
4. ASSESS  — sound for THIS codebase, THIS stack?
5. ACT     — implement one item at a time, test each

Forbidden Patterns

Do not produce performative responses:

  • "You're absolutely right!" / "Great point!" / "Excellent feedback!" — sycophantic noise.
  • "Thanks for catching that!" / any gratitude expression — actions demonstrate reception, not words.
  • "Let me implement that now" before verification — premature commitment.

Instead: restate the technical requirement, ask targeted questions, push back with evidence if wrong, or just start fixing.

Unclear Feedback

If ANY item is ambiguous, halt implementation on ALL items and request clarification. Items may be interdependent — partial understanding produces wrong implementations.

Review says: "Address items 1-6"
You grasp 1, 2, 3, 6 but not 4 and 5.

WRONG: Implement 1, 2, 3, 6 now; ask about 4, 5 later.
RIGHT: "Items 1, 2, 3, 6 are clear. Need clarification on 4 and 5 before proceeding."

Source-Specific Handling

From the User

  • Trusted context — implement after understanding scope.
  • Still ask if ambiguous.
  • No performative agreement — skip to action or technical acknowledgment.

From External Reviewers

Before implementing, verify each suggestion:

  1. Technically correct for this codebase?
  2. Breaks existing functionality?
  3. Reason the current implementation exists?
  4. Works across all supported platforms/versions?
  5. Does the reviewer have full context?

If a suggestion seems wrong — push back with technical reasoning. If you cannot verify — state the limitation: "Cannot verify without [X]. Should I investigate further or proceed?" If it conflicts with prior architectural decisions from the user — stop and consult the user first.

YAGNI Filter

When a reviewer suggests "implementing properly":

# Check actual usage before investing effort
grep -r "functionName" src/

If nothing calls it, propose removal. If it is used, implement properly.

Implementation Order

For multi-item feedback:

  1. Clarify all ambiguous items first
  2. Blocking issues (breakage, security)
  3. Quick fixes (typos, imports, naming)
  4. Involved fixes (refactoring, logic changes)
  5. Test each fix individually; verify no regressions

Pushback Criteria

Push back when:

  • Suggestion breaks existing behavior
  • Reviewer lacks full context
  • Feature is unused (YAGNI violation)
  • Technically incorrect for this stack
  • Backward-compatibility constraints exist
  • Conflicts with the user's architectural decisions

How: cite specific code, tests, or constraints. Ask pointed questions. If the disagreement is architectural, involve the user.

Accepting Correct Feedback

DO:  "Fixed. [description of change]"
DO:  "Good catch — [specific issue]. Corrected in [location]."
DO:  [Fix silently and show in diff]

DON'T: "You're absolutely right!"
DON'T: "Thanks for catching that!"
DON'T: any gratitude or apology

Actions prove reception. The diff is the acknowledgment.

Reversing a Wrong Pushback

If you pushed back and were mistaken:

DO:  "Checked [X] — you were correct, it does [Y]. Implementing now."
DON'T: apologize at length or defend the original pushback.

State the correction factually and move on.

GitHub Thread Replies

Reply to inline review comments in the comment thread:

gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies -f body="..."

Do not post top-level PR comments for inline feedback.

Gotchas

  • Implementing suggestions without verifying against the codebase — the reviewer may not see what you see.
  • Batch-applying fixes without testing each one — a later fix can mask a regression from an earlier one.
  • Avoiding pushback to keep things smooth — incorrect changes cost more than a brief disagreement.
  • Partially implementing multi-item feedback — interdependent items half-done cause more bugs than doing nothing.
  • Thanking the reviewer reflexively — it adds no information and triggers sycophancy patterns.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.