review-presto-pr
Skill17k starsChanged 41 days agoApache-2.0View on GitHub
Review a Presto pull request, commits, or local changes for code quality, style, correctness, and performance. Use when the user asks for a "code review", wants to "review commits", "review the last N commits", "review my changes", or "review the branch". Only use this skill when working in a Presto repository (prestodb/presto). Do not use for other projects.
Trending
Steady talk.about the whole repository
Who's talking about prestodb/presto
- Meta Open Source“ELI5: Presto”YouTube · Oct 27, 2022 · 13k views
- TechnoFunctionalLearning“DBeaver: How to Connect DBeaver with PrestoDB”YouTube · Mar 4, 2024 · 424 views
- Presto Foundation“From Ingestion to Insights: Building a Data Lakehouse Pipeline for GitHub Analytics (Hands-On)”YouTube · Oct 16, 2026 · 240 views
- Presto Foundation“Presto Community Sync Call #1 | April 2026 | Open Data Lakehouse Query Engine”YouTube · Apr 23, 2026 · 160 views
- Presto Foundation“Presto 0.299 Released | Latest Version | Open Data Lakehouse Query Engine | Open Source”YouTube · Sep 1, 2026 · 152 views
The biggest 5 of 95 mentions linking to the repository that our crawl found. Each line is their own headline.
See all 95
Talked about on GitHub, Stack Overflow, YouTube, Hacker News, Bluesky and the web (95 times).
On GitHub · 43
- Oct 25, 2020add support for temp tables — trinodb/trino52 reactions · 15 comments
- Jun 9, 2021Support hudi mor table — trinodb/trino20 reactions · 12 comments
- Feb 19, 2021Support for Trino DB — jOOQ/jOOQ15 reactions · 34 comments
- Mar 5, 2019Parallel read in jdbc-based connectors — trinodb/trino14 reactions · 21 comments
- Oct 14, 2021Support Hudi path filter and MoR queries — trinodb/trino10 reactions · 19 comments
38 more on GitHub
- Sep 15, 2023Enhance AggregationFuzzer to verify results against Presto — facebookincubator/velox9 reactions · 20 comments
- Nov 15, 2024(Do not review) feat: TopNRank optimization — facebookincubator/velox7 reactions · 13 comments
- Oct 8, 2024Tracking: Better Query Engine compatibility — lakekeeper/lakekeeper7 reactions · 1 comment
- Mar 29, 2022[SPARK-38506][SQL] Push partial aggregation through join — apache/spark7 reactions · 6 comments
- Jan 23, 2019TIMESTAMP behaviour does not match sql standard — trinodb/trino7 reactions · 2 comments
- Jan 30, 2019Implement contains function for IP address — trinodb/trino6 reactions · 9 comments
- May 1, 2026[EPIC] Merge EnforceDistribution + EnforceSorting into a single EnsureRequirements rule for correctness and idempotency — apache/datafusion5 reactions · 5 comments
- Dec 19, 2023Setting up Presto to use as source of truth for Fuzzers — facebookincubator/velox5 reactions · 2 comments
- Mar 20, 2023Eliminate `Distinct` in Aggregations — crate/crate5 reactions · 2 comments
- Mar 12, 2019Fault tolerance for long running queries — trinodb/trino5 reactions · 13 comments
- Apr 24, 2026Optimize multiple max_by/min_by aggregations on the same ordering column — facebookincubator/velox4 reactions
- Sep 12, 2025[Prestissimo] Connector Config Clean Up — facebookincubator/velox4 reactions · 2 comments
- Jul 2, 2024Document Unicode version supported in Velox — facebookincubator/velox4 reactions · 7 comments
- Nov 8, 2022Support distinct — facebookincubator/velox4 reactions · 4 comments
- Feb 8, 2022Add support for khyperloglog functions — trinodb/trino4 reactions · 1 comment
- Apr 18, 2020More https://trino.io/resources.html — trinodb/trino4 reactions
- Apr 14, 2020Add approx_most_frequent aggregation function — trinodb/trino4 reactions · 6 comments
- Jan 24, 2019Incorporate WorkProcessor in operators — trinodb/trino4 reactions · 3 comments
- Sep 2, 2018Add presto connector for H3 — uber/h34 reactions · 2 comments
- Jul 17, 2025feat: Add TopNRank optimization — facebookincubator/velox3 reactions · 19 comments
- Jun 19, 2024For each agg function with input param Column<T>, support aggregation for Column<Array<T>> — trinodb/trino3 reactions · 11 comments
- Feb 27, 2024Support Optimizer rewriting of queries using Materialized Views — trinodb/trino3 reactions · 4 comments
- May 19, 2022Enable the regex functions to be interrupted — trinodb/trino3 reactions · 9 comments
- Dec 28, 2021Support hive scalar function — trinodb/trino3 reactions
- Sep 14, 2021Add support for LIKE operator — facebookincubator/velox3 reactions · 7 comments
- Feb 22, 2020Query resilience to failures — trinodb/trino3 reactions · 6 comments
- Dec 20, 2019Provide an optional caching mechanism for file statistics in Hive connector — trinodb/trino3 reactions · 5 comments
- Apr 25, 2019Add Apache Phoenix connector — trinodb/trino3 reactions · 13 comments
- Jan 25, 2019Efficient Adaptive Partial Aggregations — trinodb/trino3 reactions · 5 comments
- Apr 6, 2025Unexpected collisions in Presto checksum aggregate function over maps — facebookincubator/velox2 reactions · 2 comments
- Nov 4, 2020Make query result HTTP compression configurable — trinodb/trino2 reactions
- Sep 18, 2019Add ST_Length(SphericalGeography) — trinodb/trino2 reactions · 7 comments
- Apr 10, 2019Resolve tables/schemas case-insensitively in JDBC connectors — trinodb/trino2 reactions
- Jan 28, 2019Roles PR — trinodb/trino2 reactions · 7 comments
- Apr 3, 2018Add Presto example — prometheus/jmx_exporter2 reactions · 12 comments
- Sep 10, 2026feat(cudf): Serve KvikIO reads through AsyncDataCache — facebookincubator/velox1 reaction · 4 comments
- May 21, 2026Fix release note checker to match PR template format — prestodb/presto-release-tools1 reaction · 7 comments
- Jan 14, 2026feat: Add DistinctFromArgTypesGenerator to block array(IPADDRESS) — facebookincubator/velox1 reaction · 2 comments
On Stack Overflow · 29
- Feb 20, 2017Generate interval from variable in Presto42 votes
- Apr 7, 2017Issues with JSON_EXTRACT in Presto for keys containing ' ' character24 votes
- Nov 24, 2017How to convert result of Presto `ST_Distance` to meters?8 votes · 2 answers
- May 29, 2017Presto Interpreter in Zeppelin on EMR7 votes
- Mar 17, 2024Java process RSS & MALLOC_ARENA_MAX relation6 votes
24 more on Stack Overflow
- Oct 15, 2021using snowflake JDBC driver with Presto4 votes
- Apr 8, 2015How to get started (Build) Presto on Windows4 votes · 2 answers
- Mar 6, 2024Blazor Server WebApp - High memory usage under Linux3 votes
- Aug 30, 2021Unrecognized connection property 'url' when using Presto JDBC in Spark SQL3 votes · 3 answers
- Dec 20, 2018Can you use a column for the timezone parameter of AT TIME ZONE in Presto / Athena?3 votes
- Jul 9, 2017Reference to a field of a row object3 votes
- Mar 13, 2022Presto on (Py)Spark - setup2 votes
- Apr 23, 2020Visitor and Listener at a time in Antlr 42 votes
- Apr 1, 2020Does presto support adding data sources dynamically?2 votes
- Jun 18, 2019Unable to create Hive table using Presto from a CSV File2 votes
- Mar 24, 2019Accessing Kafka stream's KTable underlying RocksDB memory usage2 votes
- Sep 19, 2018Cast to Timestamp in Java2 votes
- Feb 16, 2018SQL sort by group2 votes
- Dec 19, 2017Last observation carried forward / ignore nulls in lag2 votes
- Apr 26, 2024Question on Presto-Prestissimo ExchangeSource1 vote
- Mar 24, 2021Cannot parse UTC date in Athena1 vote · 2 answers
- Sep 2, 2020Presto Coordinator does not have support for High Availability1 vote
- Nov 29, 2019How to get JDBC connection id?1 vote
- Jan 18, 2019Cassandra question v3.11.3 ... select count(*) from table11 vote
- Sep 17, 2018Query results difference between EMR-Presto and Athena1 vote
- Aug 14, 2018Prestodb cassandraType is null error1 vote
- Jul 9, 2018Using Facebook presto-parser1 vote
- Mar 2, 2017Cannot connect Tableau to presto on emr1 vote
- Sep 10, 2016Presto hdfs local reads and preaggregation1 vote
On YouTube · 19
- Oct 27, 2022ELI5: Presto — Meta Open Source13k views · 4 comments
- Mar 4, 2024DBeaver: How to Connect DBeaver with PrestoDB — TechnoFunctionalLearning424 views
- Oct 16, 2026From Ingestion to Insights: Building a Data Lakehouse Pipeline for GitHub Analytics (Hands-On) — Presto Foundation240 views · 1 comment
- Apr 23, 2026Presto Community Sync Call #1 | April 2026 | Open Data Lakehouse Query Engine — Presto Foundation160 views
- Sep 1, 2026Presto 0.299 Released | Latest Version | Open Data Lakehouse Query Engine | Open Source — Presto Foundation152 views
14 more on YouTube
- Aug 21, 2026Keeping a Pulse on the Cluster: Monitoring Presto at Petabyte Scale (Hands-On Workshop) — Presto Foundation145 views · 1 comment
- Jan 14, 2023prestodb/presto - Gource visualisation — Gourcer143 views
- Jul 1, 2026Presto 0.298 Released | Latest Version | Open Data Lakehouse Query Engine | Open Source — Presto Foundation96 views
- Jul 23, 2026Leveraging Presto for High-Performance Analytics with Agentic AI | Sylus Case Study — Presto Foundation91 views
- May 28, 2026Presto Community Sync Call #2 | May 2026 | Open Data Lakehouse Query Engine — Presto Foundation88 views
- Oct 1, 2026Presto Community Sync Call #6 | September 2026 | Open Data Lakehouse Query Engine — Presto Foundation79 views
- Jun 25, 2026Presto Community Sync Call #3 | June 2026 | Open Data Lakehouse Query Engine — Presto Foundation77 views
- Sep 18, 2026Data Benchmarking with Presto : TPC-H & TPC-DS from Scratch (Hands-On Workshop) — Presto Foundationsays it tested it68 views
- Aug 27, 2026Presto Community Sync Call #5 | August 2026 | Open Data Lakehouse Query Engine — Presto Foundation62 views
- Oct 4, 2026Hands-On Workshop Announcement (Register Now) | From Ingestion to Insights | GitHub Analytics — Presto Foundation59 views
- Jul 30, 2026Presto Community Sync Call #4 | July 2026 | Open Data Lakehouse Query Engine — Presto Foundation52 views
- Aug 24, 2026Build Presto & Prestissimo (Presto C++) from Source (Hands On WorkShop) | Get Started with Presto — Presto Foundation44 views
- Jul 31, 2026Hands-On Workshop Announcement (Register Now) | Monitoring Presto at Petabyte Scale — Presto Foundation39 views · 1 comment
- Oct 27, 2026Presto Community Sync Call #7 | October 2026 | Open Data Lakehouse Query Engine — Presto Foundation9 views
On Hacker News · 2
- Sep 7, 2019Presto-Distributed SQL query engine for big data7 points · 2 comments
- May 9, 2018Presto: Distributed SQL query engine for big data2 points
On Bluesky · 1
- Oct 4, 2025🛢️ Presto - високопродуктивний розподілений рушій #SQL для аналітики великих даних. Дозволяє виконувати інтерактивні запити до петабайтів… — @andriikuznietsov75.bsky.social1 likes and repost
On the web · 1
- Nov 4, 2026GitHub - prestodb/presto: Sitio oficial del motor de ... - GitHot — githot.net
The file
Show its rules and text
We split this skill into the rules it gives an agent
21 rules. About 0 are common, 12 are distinctive, and 9 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈12
Distinctive · estimate
This author's own choices. Worth a look.
9
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 14
Before proceeding, verify this is a Presto repository:
- Very specific: line 21
If this is not a Presto repository, inform the user and do not proceed with this skill.
- Distinctive: line 27
Ask to review the current branch
- Very specific: line 88
Verify adherence to Presto style guidelines for Java code:
- Very specific: line 100
Verify adherence to Velox style guidelines in https://github.com/facebookincubator/velox/blob/main/CODING_STYLE.md for any C++ code changes.
- Distinctive: line 106
Before accepting new patterns or mechanisms, ask:
- Distinctive: line 122
No data structures that can grow without bounds?
- Distinctive: line 124
Not introducing expensive calls in performance-sensitive areas?
- Distinctive: line 142
Keep it generic: Avoid adding hooks for specific vendor infrastructure or proprietary systems
- Distinctive: line 145
Ask: "Would an open-source connector author find this interface reasonable and understandable?"
- Distinctive: line 155
Do they preserve query semantics?
- Very specific: line 166
@ConfigDescription: Every new @Config setter must have a @ConfigDescription so the property is self-documenting for operators - Very specific: line 171
Follow RESTful conventions (proper use of GET/POST/PUT/DELETE, resource-based URLs)
- Very specific: line 176
If the code is implementing a SQL function or operator change which is available in Presto Java then ensure the logic of the native code is …
- Distinctive: line 178
Ensure the PR has e2e tests using Native and HiveQueryRunners that verify the C++ implementation against the Java implementation for a …
- Distinctive: line 180
Check usage of smart pointers and RAII for resource management.
- Distinctive: line 181
Check for buffer overflows in any memory copies or array accesses.
- Distinctive: line 182
Ensure that exceptions are caught appropriately and that error messages are informative.
- Very specific: line 183
Ensure correct use of VELOX_CHECK_* vs VELOX_USER_CHECK_*.
- Distinctive: line 196
If multiple new tests cover overlapping scenarios, prefer the most comprehensive one
- Very specific: line 246
Always begin your review with: [review-pr skill]
≈ “Common” is an estimate: at least 1 in 5 of the 372,429 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
Presto PR Review Skill
Overview
This skill guides thorough code reviews for Presto pull requests, following the project's contribution guidelines and best practices.
Prerequisites
Before proceeding, verify this is a Presto repository:
# Check for Presto-specific markers
test -f pom.xml && grep -q "com.facebook.presto" pom.xmlIf this is not a Presto repository, inform the user and do not proceed with this skill.
How to Invoke
The user will typically:
- Provide a GitHub PR URL (github.com/prestodb/presto)
- Ask to review the current branch
- Point to specific commits to review
Review Process
1. Checkout the PR Code
First, fetch and checkout the PR so the code is available locally for browsing:
# For a GitHub PR URL, checkout the PR branch
gh pr checkout <pr-number>
# Or if given a branch name
git fetch origin <branch-name>
git checkout <branch-name>This ensures the code is available locally for the user to browse and cross-check during the review.
2. Gather Context
First, understand what changed and check for proper process:
Size and process checks:
- Large changes should have an RFC
- Very large PRs should be split when practical to keep review manageable; consider generated files separately
- Medium changes should have an associated GitHub issue
First, understand what changed:
# Compare against the PR's base branch, not a hardcoded branch name.
# Most PRs target master, but release/edge branches are cut from release
# tags (e.g. release-0.290 off the 0.290 tag), so determine the base first.
# For a GitHub PR, ask gh for the base branch:
BASE=$(gh pr view <pr-number> --json baseRefName --jq .baseRefName)
# Otherwise fall back to the default branch, or the merge-base if comparing
# against a release branch:
BASE=${BASE:-$(git remote show origin | sed -n 's/.*HEAD branch: //p')}
git diff "$BASE"...HEAD --stat
git log "$BASE"..HEAD --oneline
# For a specific commit
git show <commit> --statUsing "$BASE"...HEAD (three dots) diffs against the merge-base, which is
correct even when the base branch has advanced or was created from a release tag.
Advancing Velox: It is preferred that PRs updating the Velox git submodule are restricted to updating the submodule only. They should only include code and test changes in presto-native* modules needed for building and passing tests for the updated Velox code. Features that require subsequent presto-native* module changes should be implemented in a separate PR after the Velox update is merged. Conversely, PRs that implement new features in presto-native* modules should not include Velox submodule updates.
3. Code Style Checklist
Verify adherence to Presto style guidelines for Java code:
- Line length: Aim for 180 characters, but acceptable to exceed if breaking the line would look awkward
- Naming: No abbreviations (use
positionCountnotpositionCnt). This applies everywhere including lambda parameters (operator ->notop ->,pipeline ->notp ->,stage ->nots ->) - Static imports: Using
format(),toImmutableList(),requireNonNull,checkArgument - Import ordering: Presto enforces strict import ordering via checkstyle. Imports must be alphabetically ordered, with static imports grouped separately. No unused or wildcard imports
- Immutability: Preferring Guava immutable collections (
ImmutableList,ImmutableMap) - Fields: Declared
finalwhen possible - Class structure: Fields before methods, ordered by access level (public -> private)
- Nullability: Using
@Nullableannotation where appropriate - Validation: Constructor arguments validated with
requireNonNullandcheckArgument
Verify adherence to Velox style guidelines in https://github.com/facebookincubator/velox/blob/main/CODING_STYLE.md for any C++ code changes.
4. Code Safety and Quality
IMPORTANT: Follow existing conventions
Before accepting new patterns or mechanisms, ask:
- Is there an existing pattern in the codebase that does something similar?
- Can this build on top of existing infrastructure instead of creating something new?
- Why can't the existing approach be extended?
There is a tendency to want to redo everything from scratch. Push back on this - often existing mechanisms can be extended or reused. New abstractions should be a last resort, not a first instinct.
Evaluate changes through three axes:
Code Quality & Maintainability:
- Does the code follow existing conventions?
- Is it implemented cleanly with appropriate interfaces?
- Would doing everything this way make the codebase hard to maintain?
Code Safety:
- Thread safe?
- No data structures that can grow without bounds?
- Memory usage is accounted for?
- Not introducing expensive calls in performance-sensitive areas?
- Feature flags for risky new features?
User Friendliness:
- Config options have understandable names and descriptions?
- New features have documentation?
- Release notes added for user-visible changes?
Also look for:
- Resource management: Try-with-resources for closeable resources
- Error handling: Appropriate exception types, meaningful messages
- Logging: Appropriate log levels, no sensitive data logged
5. Presto-Specific Concerns
For SPI Changes (presto-spi module)
SPI changes require extra scrutiny:
- No new dependencies: The SPI must remain dependency-free to avoid forcing connectors to pull in unwanted libraries
- Keep it generic: Avoid adding hooks for specific vendor infrastructure or proprietary systems
- Simplicity over flexibility: A simple SPI that covers common cases is better than a complex one that handles every edge case
- Backwards compatibility: Changes should not break existing connector implementations
- Ask: "Would an open-source connector author find this interface reasonable and understandable?"
For Connector Changes
- Does it properly implement the SPI interfaces?
- Are metadata operations efficient (avoid N+1 queries)?
- Is split generation parallelizable?
- Are pushdowns implemented correctly?
For Planner/Optimizer Changes
- Are optimization rules correct and complete?
- Do they preserve query semantics?
- Are there potential infinite loops in rule application?
- Is cost estimation impacted?
For Execution Changes
- Is memory tracking correct?
- Are operators properly handling yield signals?
- Is data processed in a streaming fashion where possible?
- Are there potential deadlocks in exchange operations?
For Configuration Changes
@ConfigDescription: Every new@Configsetter must have a@ConfigDescriptionso the property is self-documenting for operators@ConfigSecuritySensitive: Annotate setters for passwords, secrets, tokens, or other sensitive values so they are masked in logs and diagnostics- New config properties should be documented (see the Documentation section) with their default values
For New HTTP Endpoints
- Follow RESTful conventions (proper use of GET/POST/PUT/DELETE, resource-based URLs)
- Consistent with existing endpoint patterns in the codebase
- Proper error responses and status codes
For presto-native* Module Changes
- If the code is implementing a SQL function or operator change which is available in Presto Java then ensure the logic of the native code is consistent with it. Focus on logic errors, off-by-one, null/empty handling, boundary conditions, integer overflow, floating point edge cases (NaN, Inf, negative zero). Ensure the PR has e2e tests using Native and HiveQueryRunners that verify the C++ implementation against the Java implementation for a variety of inputs, including edge cases.
- Ensure that presto_protocol changes included in the PR are not manually written. Any edit to a generated .h/.cpp in presto-native-execution/presto_cpp/presto_protocol directory (they have a // DO NOT EDIT header) should come with a matching change to a .yml, special/, or mustache source or a java class serialization annotation.
- Check usage of smart pointers and RAII for resource management. Ensure that raw pointers are not used unless absolutely necessary and are properly managed. If raw pointers are needed then check memory safety: Use-after-free, double-free, leaks, dangling pointers/references and ownership issues.
- Check for buffer overflows in any memory copies or array accesses. Ensure that all buffer sizes are properly checked.
- Ensure that exceptions are caught appropriately and that error messages are informative. The error message should try to include suggestions to fix user errors and should not include internal details that are not useful to users.
- Ensure correct use of VELOX_CHECK_* vs VELOX_USER_CHECK_. VELOX_CHECK_ should be used for internal consistency checks that indicate a bug if they fail, while VELOX_USER_CHECK_* should be used for validating user input and providing informative error messages.
6. Test Coverage
Verify:
- New code has corresponding tests
- Bug fixes include regression tests
- Edge cases are tested
- Tests are deterministic (no
Thread.sleep, no random values) - Integration tests if behavior changes cross module boundaries
Avoid test duplication:
- If multiple new tests cover overlapping scenarios, prefer the most comprehensive one
- Example: If test A covers scenarios X, Y, Z and test B only covers X, Y - just keep test A
- Each test should add distinct value; don't add tests just for coverage numbers
Require negative test cases:
- Feature flags: Test that behavior is correct when the feature is disabled
- Access control: Test that denied permissions actually block access (not just that granted permissions work)
- Validation: Test that invalid inputs are properly rejected
- Error paths: Test that failures are handled gracefully, not just the happy path
7. Documentation
Documentation is required for:
- New SPI interfaces or changes: Update the Developer Guide
- New session properties: Document in connector or relevant module docs
- New config properties: Document with clear descriptions that operators can understand
- Release notes: Required for user-visible changes
Also check:
- Javadoc where it adds value (complex interfaces, non-obvious behavior) - not required everywhere
- Comments for complex logic
- README updates if user-facing behavior changes
8. Commit Structure
Presto uses Conventional Commits. PR titles must follow this format:
<type>[(scope)]: <description>Types: feat, fix, docs, refactor, perf, test, build, ci, chore, revert, misc
Common scopes: parser, analyzer, planner, spi, scheduler, connector, function, operator, native, docs
Examples:
feat(connector): Add support for dynamic catalog registrationfix: Resolve memory leak in query executorfeat!: Remove deprecated configuration options(breaking change)
Verify:
- PR title follows conventional commit format
- Each commit passes tests independently
- Body explains what and why (not how)
- Related issues referenced (e.g.,
Resolves: #1234)
Output Format
IMPORTANT: Output the review directly in the conversation for the user to read. Do NOT post comments directly to GitHub - the user will decide what feedback to share.
Always begin your review with: [review-pr skill]
Structure your review as:
<!-- Reviewed using review-pr skill -->
## High-Level Overview
A brief 2-3 sentence summary of what this change accomplishes at a conceptual level. Focus on the "what" and "why" - what problem does this solve and what is the approach? This should be understandable by someone unfamiliar with the specific code.
## In-Depth Overview
A detailed explanation of the implementation:
- What components/modules are modified and why
- Key classes, interfaces, or methods introduced or changed
- How the pieces fit together
- Any notable design decisions or trade-offs made
## Change Flow Diagram
**Include when applicable** - especially for changes involving:
- Multiple components interacting
- New request/response flows
- Data transformations or pipelines
- State machines or lifecycle changes
Use ASCII diagrams or Mermaid syntax:
┌──────────────┐ ┌──────────────┐ ┌──────────────┐ │ Component A │───>│ Component B │───>│ Component C │ └──────────────┘ └──────────────┘ └──────────────┘
Or for more complex flows, use Mermaid:
```mermaid
graph LR
A[Analyzer] --> B[Planner]
B --> C[Optimizer]
C --> D[Executor]Skip this section for simple changes (single-file bug fixes, documentation updates, minor refactors).
Summary
Brief overall assessment of the PR quality, readiness for merge, and any high-level concerns.
Highlights
Things done well in the PR.
Issues Found
Critical
Issues that must be fixed before merging.
Suggestions
Improvements that would make the code better but aren't blocking.
Nits
Minor style or formatting issues.
Questions
Clarifications needed from the author.
Testing Recommendations
Additional tests that should be considered.
## Running Checks
```bash
# Check code style
./mvnw checkstyle:check -pl <module-name>
# Compile to catch type errors
./mvnw compile -pl <module-name>
# Run tests
./mvnw test -pl <module-name> -Dtest=<TestClass>Common Issues to Watch For
- Incorrect imports:
com.facebook.presto.spi.QueryIdvscom.facebook.presto.execution.QueryId - Missing null checks: Especially in connectors handling external data
- Unclosed resources: Iterators, streams, connections
- Hardcoded values: Magic numbers, hardcoded paths
- Backwards compatibility: Breaking changes to public APIs
- Security: SQL injection, command injection, XSS in Web UI
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

