agentleFS
prathakmalikprathakmalik/agent-standards-kit/skills/review-changes/SKILL.md

review-changes

Skill0 starsChanged 4 months agoMITView on GitHub

Reviews a set of code changes (a diff, a branch, or staged/uncommitted work) for correctness, edge cases, security, performance, and consistency with the repo's conventions. Use when the user asks to review changes, review a PR, check a diff, or sanity-check work before committing. Trigger phrases: "review my changes", "review this PR", "check this diff before I commit".

34 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use explore-codebase, debug-issue and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • srclightSkill

    explore-codebase

    This skill should be used when the user asks to "explore this codebase", "understand this project", "give me an overview", "how does this work", "onboard me", "walk me through the architecture", "map the codebase", or any request to understand a codebase's structure, architecture, or design.

    Also in 4 projects that use this

  • NVIDIASkill

    debug-issue

    Use when the user asks to debug, investigate, or fix a GitHub issue or supplies a repository bug report.

    Also in 4 projects that use this

  • srclightSkill

    refactor-safely

    This skill should be used when the user asks to "refactor", "rename", "move", "change a function signature", "extract a method", "delete unused code", "clean up", or any modification that could break callers or dependents. Provides a pre-change safety checklist using srclight's graph tools to assess blast radius before touching code.

    Also in 4 projects that use this

  • JetBrainsSkill

    fix-bug

    End-to-end bug fix workflow for the Exposed project. Accepts a GitHub issue (#NUMBER), YouTrack issue (EXPOSED-NUMBER), or YouTrack URL (https://youtrack.jetbrains.com/issue/EXPOSED-NUMBER). Fetches the issue, creates a failing reproducer test, commits on a new branch, implements the fix, validates, and opens a PR. Use this skill whenever the user wants to fix a bug from an issue tracker, mentions a EXPOSED issue number, or references a GitHub issue to fix.

    Also in 3 projects that use this

  • SentrySkill

    write-tests

    Write tests following project conventions. Use when adding new tests or modifying existing ones.

    Also in 3 projects that use this

  • GitHubSkill

    refactor

    Surgical code refactoring to improve maintainability without changing behavior. Covers extracting functions, renaming variables, breaking down god functions, improving type safety, eliminating code smells, and applying design patterns. Less drastic than repo-rebuilder; use for gradual improvements.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

5 rules. 0 are common, 5 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 33 edited versions we read keep these.

  • 5

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Before committing or opening a PR.

    line 16
  2. Distinctive:

    When asked to review a diff, branch, or file set.

    line 17
  3. Distinctive:

    Verify call sites when a signature changes — a local edit can break a distant caller.

    line 34
  4. Distinctive:

    If the diff is large, review by theme, not file-by-file noise.

    line 36
  5. Distinctive:

    Don't invent problems to seem thorough.

    line 37

“Common” is measured: kept by at least 6 in 10 of the 33 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

review-changes

A rigorous, constructive review of proposed changes. Prioritize code health over politeness, but be specific and actionable.

When to use

  • Before committing or opening a PR.
  • When asked to review a diff, branch, or file set.

What to inspect

  • Logic & edge cases: off-by-one, null/undefined, empty collections, error paths, race conditions.
  • Security: unsanitized input, injection, secrets in code, missing authz checks.
  • Performance: accidental O(n^2), N+1 queries, unnecessary work in hot paths.
  • Consistency: does it follow existing patterns in this repo? (Check neighboring files.)
  • DRY/clarity: duplication that should be extracted; names that mislead.

How to respond

Structure the review as:

  1. Summary — 1-2 sentences on the impact of the change.
  2. Blocking issues — bugs or security flaws that must be fixed.
  3. Suggestions — refactors, perf, style (non-blocking).
  4. Positives — call out genuinely good solutions.

Rules

  • Verify call sites when a signature changes — a local edit can break a distant caller.
  • Cite exact files/lines. Prefer a concrete fix over a vague concern.
  • If the diff is large, review by theme, not file-by-file noise.
  • Don't invent problems to seem thorough. "Looks good, here's why" is a valid result.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.