agentleFS
patrickbdevaneypatrickbdevaney/hermes-max/skills/workflow-critic/SKILL.md

workflow-critic

Skill1 starsChanged 6 months agoMITView on GitHub

After a hard subtask goes green, run a bounded red-team review of the diff against the spec and tests to catch silent-wrong patches.

The file

We split this skill into the rules it gives an agent

3 rules. About 0 are common, 0 are distinctive, and 3 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈0

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    If the critic finds a REAL defect: the builder fixes it and re-verifies.

    line 28
  2. Very specific:

    If MONITOR_ENABLED=true and MONITOR_BASE_URL are configured (a small LFM2.5-class model on a second endpoint), the reviewer delegate MAY …

    line 39
  3. Very specific:

    If delegation is unavailable, fall back to a self-review checklist (the 4 questions above) plus deep_verify — the execution-grounded layer …

    line 44

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<!-- TRIGGERS WHEN: After a hard subtask goes green, run a bounded red-team review of the diff against the spec and tests to catch silent-wrong patches. -->

Green isn't always correct. ~20% of patches pass shallow tests but are semantically wrong.

A passing test suite proves the tests pass — not that the code is right. For non-trivial subtasks, run ONE bounded critic pass before you move on, to catch the silent-wrong-answer class.

Gate by difficulty: skip the critic on trivial/easy changes (it's not worth the your inference host inference); run it on subtasks the difficulty signal flags MEDIUM/HARD, or anything irreversible/high-stakes.

The pass (builder → validator, bounded)

  1. The subtask must already be GREEN (verify passed + checkpointed) before critiquing.
  2. Spawn ONE isolated reviewer sub-agent via Hermes delegation (review is reversible — subagent_auto_approve covers it). Give it: the diff, the spec/DEFINITION OF DONE, and the tests. Its job is to RED-TEAM, not to edit. Ask it specifically:
    • Does the diff actually satisfy the spec, or just the tests?
    • Are the tests meaningful, or do they pass trivially / miss the real behavior and edge cases?
    • What input would break this? (off-by-one, empty/None, concurrency, error paths)
    • Any silent-wrong behavior the green gate wouldn't catch?
  3. Ground the critique in EXECUTION, not opinion: prefer mcp_hermes_max_verify_deep_verify(path, difficulty="hard") (property + mutation) over the reviewer's say-so. Surviving mutants / failing property tests are concrete, trustworthy signals.
  4. If the critic finds a REAL defect: the builder fixes it and re-verifies. Bound this to 1–2 rounds — if it's still wrong after that, it's a stuck signal (workflow-stuck-detect-reset), not an infinite critic loop. Re-checkpoint once green again.
  5. Record a critic_rejected event to observability when the critic rejects a patch.

Bounds (your inference host)

ONE critic pass, ONE reviewer, ≤2 fix rounds. This is review-only — NOT a swarm, and NEVER on the edit path (keep editing single-threaded; see workflow-subagent-isolation). Samples compete for the one GPU.

Optional fast monitor model

If MONITOR_ENABLED=true and MONITOR_BASE_URL are configured (a small LFM2.5-class model on a second endpoint), the reviewer delegate MAY run there to keep the critic cheap. Default OFF — two models share the one memory bus, so measure your inference host contention before adopting it.

Graceful degradation

If delegation is unavailable, fall back to a self-review checklist (the 4 questions above) plus deep_verify — the execution-grounded layer is the part that actually catches silent-wrong code.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

Reviews can't be read right now.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.