agentleFS
nshopiknshopik/dream-team/skills/review-bench/SKILL.md

review-bench

Skill2 starsChanged 19 days agoMITView on GitHub

Benchmarks qa-review on one pull request, and any other code reviewer the user names against it: runs each reviewer headless several times, builds a verified findings ledger from qa-review warm-up runs, grades every run against the frozen ledger, and prints a score table of mean quality, run-to-run sd, criticals found and noise tiers. Use when the user asks to benchmark, score, rank or compare code reviewers, review commands, models or effort levels against qa-review, or to measure a reviewer's recall on a pull request.

The file

Show its rules and text

We split this skill into the rules it gives an agent

16 rules. About 0 are common, 3 are distinctive, and 13 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈3

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 13

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Read <skill-dir>/METHODOLOGY.md and the usage header of <skill-dir>/run.sh before step 1.

    line 16
  2. Very specific:

    Run every run.sh call with Bash run_in_background.

    line 18
  3. Very specific:

    Run run.sh calls on one <out> one at a time: wait for each to finish before the next.

    line 19
  4. Very specific:

    Before step 3 and before reporting, check every <out>/<run>/marks.txt exists and is non-empty.

    line 21
  5. Very specific:

    Read baseRefOid and headRefOid from gh pr view <n> -R <owner>/<repo> --json baseRefOid,headRefOid.

    line 29
  6. Very specific:

    Use git merge-base <baseRefOid> <headRefOid> as <base-sha>, <headRefOid> as <head-sha>.

    line 31
  7. Very specific:

    Run git checkout --detach <head-sha> in the clone.

    line 32
  8. Very specific:

    Write <out>/qa-high.txt as qa-high:lenses model=<model-id> /dream-team:qa-review {base}.

    line 40
  9. Very specific:

    Delete <out>/qa-high-r{1..3}/marks.txt and <out>/qa-max-r{1,2}/marks.txt.

    line 52
  10. Distinctive:

    No reviewer named → skip to step 6.

    line 59
  11. Very specific:

    Write each reviewer as a <PREFIX>[:lenses] model=<model-id> [effort=<e>] [shown=<name>] <prompt> line in a file under <out>.

    line 62
  12. Very specific:

    Write a version in a prefix as 4-6, never 4.6.

    line 64
  13. Very specific:

    Write the prompt so the reviewer reviews <base-sha>..<head-sha>.

    line 66
  14. Very specific:

    After each run.sh call from step 3 on:

    line 79
  15. Distinctive:

    Check each against the code: drop one that is refuted, pre-existing, already a row, or a duplicate of another candidate.

    line 82
  16. Distinctive:

    Only minor candidates survive → bump nothing.

    line 86

≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

review-bench

<skill-dir> below is this skill's base directory, as the harness prints it.

  • Read <skill-dir>/METHODOLOGY.md and the usage header of <skill-dir>/run.sh before step 1.
  • run.sh runs, grades and scores; this skill covers the calls it cannot make.
  • Run every run.sh call with Bash run_in_background.
  • Run run.sh calls on one <out> one at a time: wait for each to finish before the next; use P for parallel runs, and parallel grades on a frozen ledger, inside one call.
  • Before step 3 and before reporting, check every <out>/<run>/marks.txt exists and is non-empty; if one is not, rerun the same run.sh command, which regrades only the ungraded runs.

1. Pick the pull request

  • Pick a pull request in a public repo whose diff holds real defects and fits one review run.
  • Clone the repo outside the output directory and fetch the head: git fetch origin pull/<n>/head.
  • Read baseRefOid and headRefOid from gh pr view <n> -R <owner>/<repo> --json baseRefOid,headRefOid.
  • Use git merge-base <baseRefOid> <headRefOid> as <base-sha>, <headRefOid> as <head-sha>.
  • Run git checkout --detach <head-sha> in the clone; step 5 checks candidates against it.
  • Pick an output directory <out> outside the clone; every step below uses the same one.

2. Warm up the ledger

  • Name a qa-review reviewer file <out>/qa-<effort>.txt and its prefix qa-<effort>, so its run directories read qa-high-r1, qa-max-r1.
  • <model-id> below is a full model ID, such as claude-opus-4-8, never an alias such as opus.
  • Write <out>/qa-high.txt as qa-high:lenses model=<model-id> /dream-team:qa-review {base}.
  • Write <out>/qa-max.txt as qa-max:lenses model=<model-id> /dream-team:qa-review {base}.
  • Run N=3 EFFORT=high <skill-dir>/run.sh <clone> <base-sha> <head-sha> <out>/qa-high.txt <out>.
  • Then run N=2 EFFORT=max <skill-dir>/run.sh <clone> <base-sha> <head-sha> <out>/qa-max.txt <out>.
  • These five runs are the warm-up; no stop rule ends it earlier or later.
  • A warm-up run with early-exit and a non-zero exit= in stats.txt → delete <out>/<run> and rerun its command before step 3.
  • The score tables these calls print grade against a growing ledger; they are not results.

3. Freeze the ledger

  • Set "frozen": true in <out>/ledger.json; leave version at 1.
  • Delete <out>/qa-high-r{1..3}/marks.txt and <out>/qa-max-r{1,2}/marks.txt.
  • Rerun the step 2 qa-high.txt command to regrade all five; the warm-up runs stay scored runs.
  • The frozen ledger lacks a critical or an important row → drop this pull request and go back to step 1 with another and a new <out>.

4. Run each reviewer the user named

  • No reviewer named → skip to step 6; the table holds qa-review alone.
  • qa-review at another effort → <out>/qa-<effort>.txt per step 2, run with EFFORT=<effort>.
  • A reviewer named later → reuse the same <out> and run steps 4 to 6.
  • Write each reviewer as a <PREFIX>[:lenses] model=<model-id> [effort=<e>] [shown=<name>] <prompt> line in a file under <out>; prefix is ASCII letters, digits and -, unique per reviewer.
  • Write a version in a prefix as 4-6, never 4.6.
  • :lenses only for a reviewer whose subagents each return a report.
  • Write the prompt so the reviewer reviews <base-sha>..<head-sha>; {base} alone is a base ref only to qa-review; another reviewer may read a bare SHA as one commit.
  • An external reviewer whose review runs on another model, such as /vllm-review on pi → add shown=<that model>, such as shown=qwen3-coder; model= still sets the Claude session's model.
  • A reviewer differing only in model or effort needs its own prefix, such as qa-opus-4-6, and its own model= or effort= field; one run.sh call can hold all such reviewers.
  • A reviewer whose prompt and plugin have not run on this pull request → run N=1, check its report.md covers the pull request's files, then rerun with N=3; the rerun skips the first run.
  • A reviewer whose prompt and plugin already ran on this pull request → run N=3 in one call.
  • run.sh grades each new run against the frozen ledger and prints the score table.

5. Promote candidates

After each run.sh call from step 3 on:

  • List grep -h ^Candidate <out>/*/marks.txt.
  • Check each against the code: drop one that is refuted, pre-existing, already a row, or a duplicate of another candidate.
  • A non-minor candidate survives → add every surviving candidate as a row per METHODOLOGY "Ledger file", and bump version by one.
  • Only minor candidates survive → bump nothing; they wait for the next bump.
  • Any other row change (severity, plausible) also bumps version by one.
  • On a bump, read each earlier run's report.md or lenses/*.md against the new rows only, per METHODOLOGY "Grading a run"; add the IDs each report or lens earns to its own scored line; existing marks stand.
  • Rescore: cat <out>/*/marks.txt > <out>/marks.txt, then python3 <skill-dir>/score.py <out>/ledger.json <out>/marks.txt.

6. Read and report

  • Reviewers in one tier are not ranked; their order is noise.
  • With 3 runs a reviewer's sd is often 3 to 7 points; a mean gap inside that is not a result.
  • Compare scores only within one ledger version.
  • early-exit in a run's stats.txt scores 0; name the run.
- **Ledger:** <score.py summary line>; pending candidates: <n or none>
- **Table:**
  <score.py table as a markdown table, its columns and values verbatim>
- **Reading:** <tiers in words; gaps within sd called noise; rejected claims and $/run beside
  quality; a multi-lens reviewer's rejected claims are raw lens claims>
- **Early exits:** <runs with their reviewer and model, or none>

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.