agentleFS
neeraj181-dotneeraj181-dot/ClaudeSkills/.claude/skills/code-reviewer/SKILL.md

code-reviewer

Skill0 starsChanged 3 months agoApache-2.0View on GitHub

Perform thorough, constructive code reviews — analyze changed code for correctness, security, performance, maintainability, test coverage, naming, error handling, and edge cases. Provides actionable feedback organized by severity, with specific file references and suggested improvements. Distinguishes blocking issues from style preferences. Works across any language and framework. Use when the user wants a code review of recent changes, a PR, or a specific set of files.

188 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use git-doc-updater, git-precommit and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • u9401066Skill

    git-doc-updater

    Auto-check and update key documentation before Git commits to keep docs in sync with code. Triggers: docs, 文檔, 更新文檔, sync docs, release, 發布.

    Also in 5 projects that use this

  • u9401066Skill

    git-precommit

    Orchestrate pre-commit workflow including Memory Bank sync, README/CHANGELOG/ROADMAP updates. Triggers: GIT, gc, push, commit, 提交, 準備 commit, 要提交了, git commit, pre-commit, 推送.

    Also in 5 projects that use this

  • JeffallanSkill

    shopify-expert

    Builds and debugs Shopify themes (.liquid files, theme.json, sections), develops custom Shopify apps (shopify.app.toml, OAuth, webhooks), and implements Storefront API integrations for headless storefronts. Use when building or customizing Shopify themes, creating Hydrogen or custom React storefronts, developing Shopify apps, implementing checkout UI extensions or Shopify Functions, optimizing performance, or integrating third-party services. Invoke for Liquid templating, Storefront API, app development, checkout customization, Shopify Plus features, App Bridge, Polaris, or Shopify CLI workflows.

    Also in 5 projects that use this

  • JeffallanSkill

    spec-miner

    Reverse-engineering specialist that extracts specifications from existing codebases. Use when working with legacy or undocumented systems, inherited projects, or old codebases with no documentation. Invoke to map code dependencies, generate API documentation from source, identify undocumented business logic, figure out what code does, or create architecture documentation from implementation. Trigger phrases: reverse engineer, old codebase, no docs, no documentation, figure out how this works, inherited project, legacy analysis, code archaeology, undocumented features.

    Also in 6 projects that use this

  • +4 more from u9401066
  • +4 more from Jeffallan

The file

We split this skill into the rules it gives an agent

6 rules. 0 are common, 6 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 160 edited versions we read keep these.

  • 6

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read the actual code: Do not review from summaries or assumptions.

    line 15
  2. Distinctive:

    Read the full diff or changed files.

    line 26
  3. Distinctive:

    Check for logic errors:

    line 33
  4. Distinctive:

    Check for security issues:

    line 46
  5. Distinctive:

    Check for performance issues:

    line 56
  6. Distinctive:

    If tests are included:

    line 78

“Common” is measured: kept by at least 6 in 10 of the 160 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Reviewer

Act as a senior engineer doing a thoughtful code review — thorough, constructive, and focused on what matters.

Core principle: review for the team, not for yourself. A good code review catches real problems, suggests improvements, and teaches — without being pedantic about style preferences. Block real issues; suggest improvements for the rest.

Two hard rules:

  1. Read the actual code. Do not review from summaries or assumptions.
  2. Distinguish blocking issues from suggestions. A missing null check is blocking; a different variable name is a suggestion.

Work through the phases in order.


Phase 1 — Understand the change

Before reviewing:

  • Read the full diff or changed files.
  • Understand the purpose — what problem does this change solve?
  • Understand the scope — how many files, how much code, what areas of the system.
  • Understand the context — related issues, prior discussions, design decisions.

Phase 2 — Correctness review

Check for logic errors:

  • Edge cases — empty input, null, zero, boundary values, concurrent access.
  • Off-by-one errors — loop boundaries, array indexing.
  • Error handling — errors caught and handled appropriately.
  • State management — state transitions are correct.
  • Race conditions — concurrent operations handled safely.
  • Null/undefined — all potentially-null values checked.
  • Return values — functions return what their signature promises.
  • Conditional logic — conditions match the intended behavior.

Phase 3 — Security review

Check for security issues:

  • Input validation — user input sanitized before use.
  • Injection — SQL, NoSQL, command, XSS, path traversal.
  • Authentication/authorization — access controls present and correct.
  • Secret exposure — no secrets in code, logs, or output.
  • Data exposure — sensitive data not returned unnecessarily.

Phase 4 — Performance review

Check for performance issues:

  • N+1 queries — database queries in loops.
  • Unnecessary work — computations done but results unused.
  • Missing caching — expensive operations repeated without caching.
  • Large payloads — unnecessary data fetched or returned.
  • Blocking operations — synchronous operations that should be async.

Phase 5 — Maintainability review

Assess code quality:

  • Readability — can you understand what the code does and why?
  • Naming — variable, function, and class names communicate purpose.
  • Function size — functions do one thing, are reasonably sized.
  • Complexity — deeply nested logic, complex conditionals.
  • Duplication — repeated patterns that could be extracted.
  • Comments — explain why, not what.
  • Magic values — constants used instead of hardcoded numbers/strings.

Phase 6 — Test review

If tests are included:

  • Test correctness — do tests actually verify the behavior?
  • Edge cases tested — boundary conditions, error cases covered.
  • Test isolation — tests don't depend on each other.
  • Test clarity — test names describe what's being tested.
  • Missing tests — critical code paths without tests.

Phase 7 — API and interface review

Check:

  • API design — endpoints are intuitive, consistent.
  • Breaking changes — backwards compatibility maintained or migration path provided.
  • Type contracts — types match actual usage.
  • Documentation — public APIs documented.

Phase 8 — Organize feedback

Classify every finding:

  • 🔴 Block — must be fixed before merge (bugs, security issues, data loss risk).
  • 🟠 Strong suggestion — should be addressed (significant improvement, potential bug).
  • 💡 Suggestion — worth considering (cleaner approach, better pattern).
  • ⚪ Nit — style, naming, minor preference (non-blocking).
  • ✅ Positive — good pattern, well-written code (acknowledge good work).

Acknowledge what's done well. A review that only lists problems is demoralizing and less effective.

Phase 9 — Final report

# Code Review Summary
# Change Overview
# Blocking Issues
# Strong Suggestions
# Suggestions
# Nits
# Positive Observations
# Test Assessment
# Overall Assessment

For each finding:

  • File and line — exact location
  • Category — block/suggestion/nit
  • Issue — what's wrong or could be improved
  • Suggested fix — specific code change or approach

Guardrails, always: read the actual code; distinguish blocking issues from suggestions; acknowledge good work; be specific with feedback (file, line, what to change); keep feedback actionable; don't block on style preferences; focus on correctness, security, and maintainability; explain why something should change; and don't review code you haven't read.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.