agentleFS
motola10motola10/claude-code-base/.claude/skills/reviewing-codebases/SKILL.md

reviewing-codebases

Skill1 starsChanged 5 months agoMITView on GitHub

Meta-skill describing HOW to perform a framework-aware code review with this Standards Library: detecting the stack, loading standards in the correct precedence order (framework → general → custom, custom wins), citing rule IDs, and mapping severities to a verdict. Use when running a review and you need the procedure — invoked by the code-reviewer, qa-agent, and architect-agent, or directly when reviewing any codebase.

The file

We split this skill into the rules it gives an agent

1 rule. About 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈1

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use the agent's report format (Code Review / QA Validation / Architecture Review).

    line 70

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Reviewing Codebases — Method

This is the shared procedure every review agent follows. The framework standards (<framework>-standards), general-standards, and custom-standards are the content; this skill is the method.

1. Detect the stack

Inspect manifests and config to determine which framework standard(s) apply:

SignalStandard(s) to load
pyproject.toml, requirements.txtpython-standards
FastAPI app / APIRouterpython-standards + fastapi-standards
package.json with server deps (NestJS/Express/Fastify), no Reactnodejs-standards (+ typescript-standards if TS)
package.json with reactreact-standards + typescript-standards
next.config.*, app/ dirreact-standards + typescript-standards + nextjs-standards
tsconfig.jsontypescript-standards (alongside the runtime standard)
go.modgo-standards
pom.xml, build.gradlejava-standards
Cargo.tomlrust-standards

Composite stacks layer — load the base and the overlay (FastAPI→Python; Next.js→React+TS; TS Node backend→Node.js+TS). A monorepo may need several stacks at once.

2. Load standards in precedence order

  1. The detected framework standard(s) (base before overlay).
  2. general-standards (always — cross-cutting baseline).
  3. custom-standards LAST. It holds project overrides + additions and is authoritative on conflict. When a finding is driven by a custom override, say so and cite the framework rule it replaces.

On overlap between framework and general, the stricter rule wins. custom-standards wins over everything.

3. Review against the rules

Walk the changed/target code against each loaded standard's rule areas — quality, security, performance, framework idioms, error handling, testing, docs. For every finding:

  • Cite the rule ID (PY-SEC-1, REACT-HOOK-1, GEN-TEST-2, …). A finding with no rule ID is an opinion, not a standard violation — mark it clearly as a suggestion.
  • Give file:line and a specific, actionable fix. Never "improve this."
  • Note whether the rule is MUST / SHOULD / MAY.

4. Map severity → verdict

Rule strength / domainSeverityGate
MUST/MUST NOT on security or data integrityCriticalBlocks
Other MUST/MUST NOT (by impact)Critical / WarningBlocks if it risks correctness
SHOULD without written justificationWarningShould fix
MAY / stylisticSuggestionNice to have

A review is blocked if any Critical remains. Prioritize security above all.

5. Report

Use the agent's report format (Code Review / QA Validation / Architecture Review). Always:

  • Lead with Critical issues, then Warnings, then Suggestions.
  • Include Positive Observations — reviews aren't only fault-finding.
  • Make every claim evidence-based (path, line, rule ID). Don't assume test/build results — run them (QA) or state you didn't.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.