agentleFS
MicrosoftKnown publishermicrosoft/AzureTRE/.github/skills/tre-code-review/SKILL.md

tre-code-review

Skill237 starsChanged 38 days agoMITView on GitHub

Reviews Azure TRE pull requests for security, correctness, release metadata and validation gaps. Use when reviewing a PR or selecting its checks, including whether a PR bot command adds useful evidence.

The file

We split this skill into the rules it gives an agent

9 rules. About 0 are common, 8 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈8

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read the changed implementation and affected callers.

    line 11
  2. Distinctive:

    Check versions and release notes against the current base using root contribution requirements.

    line 12
  3. Distinctive:

    Check that changelog claims match the implementation.

    line 15
  4. Distinctive:

    Check public network access, private endpoints, DNS and routing against the intended workspace boundaries.

    line 24
  5. Distinctive:

    Check managed identities and RBAC roles, scopes and inherited access.

    line 25
  6. Distinctive:

    Read the PR bot commands, command implementation and workflow routing when selecting a command.

    line 35
  7. Very specific:

    Use skip_deployment only when reusing a suitable, successfully deployed environment is justified and the changed behaviour does not require …

    line 51
  8. Distinctive:

    Before recommending a run that exposes deployment secrets to PR code, examine changed workflows, actions, scripts, Makefile targets and …

    line 55
  9. Distinctive:

    Keep suggestions within explanatory review text.

    line 66

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Azure TRE code review

Establish the scope

  1. Identify the current PR head SHA, base branch and changed paths. Recheck the head if it changes during review.
  2. Read the changed implementation and affected callers. Load the front-end or bundle procedure when relevant.
  3. Check versions and release notes against the current base using root contribution requirements.
  4. Examine checks for the assessed commit. Inspect run attempts and jobs before treating a successful status as executed validation.

Check that changelog claims match the implementation. For bundle inputs, inspect all affected lifecycle actions. For asynchronous UI changes, inspect pending requests and stale-response handling. Do not report a historical example as a current defect without checking the code.

State actionable findings with a file location, the failing condition and its consequence. Rank findings by impact. Distinguish a code defect from an unperformed test or an outstanding GitHub approval gate. If checks or logs are inaccessible, state the missing evidence.

Review security and coordination

For network or identity changes, apply the security baseline:

  • List new or widened outbound hosts and firewall rules. Assess data-export paths, including shared Azure endpoints serving other tenants or subscriptions.
  • Check public network access, private endpoints, DNS and routing against the intended workspace boundaries.
  • Check managed identities and RBAC roles, scopes and inherited access. Use the bundle security checks for affected bundles.

For concurrent or message-driven changes, trace overlapping operations, persistence/dispatch ordering, duplicate delivery and recovery after interruption. If reviews repeatedly find failures in the same design, reassess its coordination and recovery model before adding more locks or retries.

Mocked tests can exercise selected interleavings but do not establish real queue, database or distributed-lock behaviour. Identify the concurrency and redelivery scenarios exercised, and state where integration evidence is missing.

Recommend validation

Recommend checks that address the changed behaviour. Recommend a PR bot command only when it adds useful evidence or a maintainer needs an explicit waiver. Otherwise, explain why no command is useful.

Read the PR bot commands, command implementation and workflow routing when selecting a command. Inspect the selected tests in e2e_tests rather than inferring coverage from a suite name.

Change or validation needRecommendation to consider
Build, deployment and basic API/resource health/test <assessed-sha>
Workspace and service provisioning covered by extended tests/test-extended <assessed-sha>
Entra ID behaviour covered by the AAD suite/test-extended-aad <assessed-sha>
Core shared-service behaviour/test-shared-services <assessed-sha>
Workspace backup behaviour/test-backups <assessed-sha>
Airlock lifecycle behaviour/test-airlock <assessed-sha>
E2E provides no useful evidence after assessing build and deployment impactNo new run, or /test-force-approve for maintainer consideration if a waiver is needed

A missing targeted E2E test is not sufficient reason to waive /test: it also validates build and deployment. UI component or browser checks can still be necessary after backend E2E passes. Explain what the selected suite covers and what remains untested.

For an all-documentation PR, the bot classifies .md files and root mkdocs.yml as documentation. /test then marks the smoke check successful without deployment or tests. Identify this as a waiver. /test-force-approve also records success without executing tests and does not validate the change.

Use skip_deployment only when reusing a suitable, successfully deployed environment is justified and the changed behaviour does not require rebuilding or redeployment. It is supported by /test and /test-extended. State the environment evidence and validation omitted.

PR comment commands use workflow definitions from the default branch. They do not exercise changes to those definitions in the PR. Where workflow execution matters, recommend a separate run of deploy_tre_branch.yml from a trusted upstream branch containing the changes, with the required maintainer approval.

Before recommending a run that exposes deployment secrets to PR code, examine changed workflows, actions, scripts, Makefile targets and dependencies used by that run. Posting a recommendation does not authorise dispatching it.

Communicate the recommendation

Where the review surface permits, include a descriptive validation section with:

  • The assessed head SHA and relevant changed components.
  • Observed local checks and CI jobs, with links where available.
  • The suggested command or the reason no new run is useful.
  • Its coverage, justification and any waiver or remaining validation.

Keep suggestions within explanatory review text. Never place an executable slash command on the first line of a standalone PR comment. A maintainer decides whether to post it.

GitHub Copilot code review does not guarantee a custom overview format or a recommendation on every review. Use the supported feedback surface and record absent recommendations during evaluation. Do not create a separate comment, request another review or trigger automation merely to force that output.

Apply the root reporting rules. Keep required reviews, branch rules and merge readiness distinct from technical findings.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.