agentleFS
matusbumatusbu/claude-code-test-automation-skills/.claude/skills/test-design-review/SKILL.md

test-design-review

Skill0 starsChanged 6 months agoMITView on GitHub

Review test design quality for code changes against the defined test strategy. Use when reviewing a feature branch, commit, or uncommitted changes to ensure new or modified tests are well-designed, placed at the correct test level, and conform to the architecture defined in the strategy.

2 other projects use a version of this.

Adopted by

Most recently taken up by

  • Other versions2 projects use a version of this.

    Word for word · 0

    None found.

    Edited · 0

    None found.

    Wrote their own version · 2

    1. jasonswett/llm-skills★ 194same name
    2. shalomb/agent-skills★ 3same name

    How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.

  • In this repositoryOne other file it gives its agents.

The file

We split this skill into the rules it gives an agent

12 rules. About 0 are common, 5 are distinctive, and 7 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈5

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 7

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    If $scope is "uncommitted" or "unstaged": analyze uncommitted changes (git diff HEAD)

    line 19
  2. Very specific:

    If $scope is "last-commit": analyze the most recent commit (git diff HEAD~1 HEAD)

    line 20
  3. Very specific:

    If $scope matches pattern "last-N-commits": analyze last N commits from HEAD

    line 21
  4. Very specific:

    If $scope is empty or "branch": analyze diff between current feature branch and main (git diff main...HEAD)

    line 22
  5. Very specific:

    If $scope is a custom git range (e.g., "commit1..commit2"): use that range

    line 23
  6. Very specific:

    If $scope is unclear or not provided, ask the user what scope they want to analyze

    line 24
  7. Distinctive:

    Look for the test strategy definition to understand the expected design and level structure.

    line 30
  8. Very specific:

    If not found, check .claude/ directory for strategy documentation

    line 34
  9. Distinctive:

    If user mentioned a specific strategy in their prompt, use that instead

    line 35
  10. Distinctive:

    If no strategy file found, ask the user where the test strategy is defined

    line 36
  11. Distinctive:

    Check whether new or modified tests follow that pattern — are the correct abstractions used and is the defined pattern respected throughout?

    line 48
  12. Distinctive:

    Levels reviewed: only levels that had changes in the diff

    line 55

≈ “Common” is an estimate: at least 1 in 5 of the 372,429 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Test Design Review

Analyze the design quality of tests introduced or modified in a code change, and verify they conform to the defined test strategy.

Step 1: Detect scope of change

The scope defines which code changes to analyze for test design quality.

Scope options:

  • If $scope is "uncommitted" or "unstaged": analyze uncommitted changes (git diff HEAD)
  • If $scope is "last-commit": analyze the most recent commit (git diff HEAD~1 HEAD)
  • If $scope matches pattern "last-N-commits": analyze last N commits from HEAD
  • If $scope is empty or "branch": analyze diff between current feature branch and main (git diff main...HEAD)
  • If $scope is a custom git range (e.g., "commit1..commit2"): use that range
  • If $scope is unclear or not provided, ask the user what scope they want to analyze

Determine the appropriate git command and execute it to get the diff. Focus on test files introduced or modified in the diff.

Step 2: Locate test strategy

Look for the test strategy definition to understand the expected design and level structure.

Strategy location:

  • First, check if TEST_STRATEGY.md exists in the repository root
  • If not found, check .claude/ directory for strategy documentation
  • If user mentioned a specific strategy in their prompt, use that instead
  • If no strategy file found, ask the user where the test strategy is defined

Step 3: Review test design quality

Read the strategy file and identify all defined test levels. For each level, check whether a ### Design section exists with real content (not placeholder text in square brackets). Only evaluate levels that have test file changes present in the diff from Step 1 — levels with no changes are out of scope, do not report on them.

Test level conformance

  • Using ### Purpose, ### Covers, and ### Excludes as the definition of what belongs at this level, evaluate whether each new or modified test belongs here based on what it does and how it is written
  • Flag tests whose nature or granularity contradicts the level's intent — e.g. a single field validation in an E2E test, or a full flow assertion in a unit test

Framework architecture conformance — apply only to levels with a defined ### Design section

  • Identify the architectural pattern described in the ### Design section (e.g. Screenplay pattern, Page Object Model, custom actor/DSL approach)
  • Check whether new or modified tests follow that pattern — are the correct abstractions used and is the defined pattern respected throughout?
  • Flag any tests that bypass the defined pattern and interact with the system at a lower level than intended

Step 4: Report results

Provide a structured summary:

  • Scope analyzed: what test changes were reviewed
  • Levels reviewed: only levels that had changes in the diff
  • Well-designed: tests that correctly follow the strategy
  • Design issues found: specific tests with placement or design problems, with explanation of why
  • Recommendations: concrete suggestions for each issue (e.g. move to unit level, refactor to use correct actor abstraction)

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.