agentleFS
magia187magia187/premium-agent-skills/skills/adversarial-review/SKILL.md

adversarial-review

Skill0 starsChanged 2 months agoMITView on GitHub

Use when reviewing a PR, patch, or design. Attack the change as a skeptic: enumerate failure modes, missing tests, unsafe defaults, and privilege edges before approving or merging.

109 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use rethink, root-cause-analysis and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • fabioespindulaSkill

    rethink

    Reframe a plan, idea, or decision before the user commits to it. Use when the user asks to rethink, step back, pressure-test, gut-check, decide, right-size, simplify, think bigger about, or evaluate a concrete plan or decision in product, strategy, technical architecture, career, life, company direction, or personal priorities. This skill improves decision quality before action: clarify the real question, challenge assumptions, compare alternatives, calibrate ambition, classify the operating mode, surface risks, and recommend a next move. Do not use for broad future exploration without a concrete decision; that belongs to a think-big or research-style skill.

    Also in 3 projects that use this

  • MicrosoftSkill

    root-cause-analysis

    Use when a Regional Retail Manager asks I'm seeing unusual inventory movement at our Northwest stores. Can you help me understand what's happening?

    Also in 3 projects that use this

  • anasahmed07Skill

    better-auth-best-practices

    Skill for integrating Better Auth - the comprehensive TypeScript authentication framework.

    Also in 4 projects that use this

  • DockerSkill

    fix-issue

    Fix a single GitHub issue end-to-end: triage, research, write the fix, review, and create a PR. Use when asked to fix an issue: "fix issue 1234", "resolve #500", "create a PR for issue 200".

    Also in 3 projects that use this

  • MicrosoftSkill

    pull-request

    Write concise, focused pull request descriptions for Wassette — at most three sentences on the what and why, with an explicit note on any breaking public-API change and how users adapt. Use when opening or editing a Wassette pull request.

    Also in 3 projects that use this

  • juriwiensSkill

    codex-review

    Run code review via Codex CLI

    Also in 3 projects that use this

  • +2 more from microsoft

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 98 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Distinctive:

    Before merging high-risk changes (auth, payments, data deletion, public APIs).

    line 15
  2. Distinctive:

    Do not merge, push to protected branches, or dismiss required reviews without authorization.

    line 27
  3. Distinctive:

    Do not exfiltrate secrets found in the diff.

    line 28
  4. Distinctive:

    Check tests for gaps relative to those failure modes.

    line 34

“Common” is measured: kept by at least 6 in 10 of the 98 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Adversarial Review

When to use

  • Reviewing a pull request, patch diff, or proposed design.
  • The user asks for a "critical review", "threat model pass", or "what could go wrong".
  • Before merging high-risk changes (auth, payments, data deletion, public APIs).

When not to use

  • Rubber-stamping typo/docs-only PRs where risk is negligible.
  • Pairing sessions where the goal is collaborative drafting, not gatekeeping (switch to review mode when ready).
  • Replacing formal security audit/penetration test engagements.

Assumptions

  • Access to the full diff, linked issue, and ability to run or reason about tests.
  • Product/security context may be incomplete — call out assumptions explicitly.
  • Do not merge, push to protected branches, or dismiss required reviews without authorization.
  • Do not exfiltrate secrets found in the diff; follow secrets-hygiene instead.

Workflow

  1. Restate the change's purpose and trust boundaries in your own words.
  2. Hunt for failure modes: nulls, races, authz gaps, injection, unsafe defaults, partial failure.
  3. Check tests for gaps relative to those failure modes.
  4. File concrete, severity-tagged findings (blocker / should-fix / nit).
  5. Approve only when blockers are addressed or explicitly accepted by the owner.

Steps

  1. Intent check — Does the diff match the claimed purpose? Flag unrelated churn.
  2. Abuse cases — For each new input/surface: unauthenticated access, confused deputy, oversized payloads, replay, TOCTOU, and error-path leaks.
  3. Defaults & footguns — Fail-open vs fail-closed; permissive CORS; debug flags; default passwords; broad IAM.
  4. Data & teardown — Migrations, deletes, and retries: idempotency, backup/rollback, PII exposure in logs.
  5. Test gaps — Map each serious risk to a missing test; demand or add coverage for blockers.
  6. Report — Structured findings with file/line references and a clear merge recommendation.

Success criteria

  • Review names specific failure modes, not only style nits.
  • Missing tests for high-severity risks are called out.
  • Unsafe defaults and authz edges are explicitly assessed.
  • Findings are prioritized (blocker vs non-blocking).
  • No unauthorized merge or secret leakage occurred during review.

Out of scope

  • Full formal threat modeling workshops for an entire product.
  • Legal/compliance sign-off.
  • Rewriting the feature for the author unless asked.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.