agentleFS
mag123cmag123c/toktrack/.claude/skills/review/SKILL.md

review

Skill196 starsChanged 14 days agoMITView on GitHub

Multi-agent code review for Rust CLI/TUI. UX Review inactive (terminal UI — no web frontend). Code Review only. Includes Rust/clippy-specific checklist.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, daily-arxiv and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +5 more from Lambenthan
  • +3 more from dzhng

The file

We split this skill into the rules it gives an agent

3 rules. 0 are common, 3 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 156 edited versions we read keep these.

  • 3

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Run Code Review Agent only.

    line 19
  2. Distinctive:

    If there are clippy warnings, FAIL before starting review (should have been caught by verify).

    line 74
  3. Distinctive:

    Do not run UX Review Agent (TUI project)

    line 86

“Common” is measured: kept by at least 6 in 10 of the 156 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review (toktrack override)

Follows the global /review multi-agent pattern, with the following overrides:

Override: UX Review Inactive

This project is a terminal TUI app — do not run the UX Review Agent. Run Code Review Agent only.

Override: Code Review Checklist Extension

In addition to the global checklist, append the following to the Code Review Agent prompt:

Critical (PLAN gate)

CategoryItems
PLAN assumption refutationDoes the diff falsify the [agent-inferred]/[unverified-gate] assumptions from the PLAN (falsified → P1+, carry to wrap)

Author Review Gate (P0 — Identity / Matrix)

This repo is OSS and the reviewer is the author (receiving PRs). Generic code health is covered by Rust/TUI/clippy below; this section examines product-specific risks that only the author can validate. Perspective SSOT: session memory feedback_review_perspective.md.

TierCategoryItems
rejectIdentity ① ultra-fastAdding latency·blocking IO·synchronous network to hot path/startup → reject
rejectIdentity ② persistent cache / data preservationRisk of cache·history loss or corruption → reject. backward-compat·graceful degradation are the means to uphold this
ruthlessIrreversiblebreaking change · data migration · public behavior change
ruthlessEnvironment/state matrix (contributors test only their own machine)OS(paths·home·file locks·Windows) / source schema version(forward new-schema+backward old-format, new source·parser PRs require old-version·unknown-schema fixture) / data shape(empty·large·corrupt·partial·permissions) / locale·TZ·DST / concurrency(read race while source file is being written) / terminal(width·color·TERM) / first-run vs upgrade migration
bias to YESOther features·ideasStars are the goal — acceptance bias. But if it taxes either core(weighing down hot path·startup·cache paths), request location·approach adjustment only. additive/opt-in/lazy/behind a flag = welcome
lenientStyle·naming preferencesLinter takes precedence, bikeshed prohibited (uniform strictness = contributor friction → star loss)
signalDirection/growth fit (not a gate)Beyond code quality·conventions, every contribution(issue·PR) also gets a direction-fit verdict in the review output: strengthens wedge (persistent cache/data preservation) / neutral (additive) / dilutes focus (e.g. feature-parity chasing) + 1–2 lines of rationale. Weigh holistically: maintenance cost vs value, real value to target users(AI CLI heavy users), contribution to project direction. Never a reject reason — the two identities above remain the only gates, bias-to-YES stands

Rust-specific

CategoryItems
SafetyMinimize unsafe usage, comment with justification
OwnershipUnnecessary .clone(), to_string(), to_owned()
Erroranyhow/thiserror pattern consistency, no unwrap() (tests excluded)
PerformanceUnnecessary allocation, Vec vs iterator chain, Box<dyn> vs generic
SIMDCheck fallback branch in simd-json parsing path
ConcurrencyCheck shared mutable state in rayon parallel path

TUI-specific

CategoryItems
Widgetratatui Widget trait implementation consistency
ThemeUse theme.rs semantic colors (no hardcoded colors)
LayoutHandle terminal resize (Rect boundary check)
InputMissing keyboard event handling (shortcuts registered in help vs actual handlers)

Clippy/Fmt Pre-check

Code Review Agent checks the following before review:

cargo fmt --check
cargo clippy --all-targets --all-features -- -D warnings

If there are clippy warnings, FAIL before starting review (should have been caught by verify).

Execution

  1. Collect context (diff, conventions, architecture, Sprint Contract)
    • PLAN provenance tags/gates (if present) — [agent-inferred] / [unverified-gate]
  2. Launch Code Review Agent only (feature-dev:code-reviewer)
    • Global agents/code-review.md prompt + above author gates + Rust/TUI checklist append
  3. Parse verdict → PASS → /wrap, FAIL → fix → /verify → re-review

Rules

  • Sub-agent model: launch the Code Review Agent via the Agent tool with model: "sonnet" (Sonnet 5).
  • Do not run UX Review Agent (TUI project)
  • PASS → run /wrap immediately
  • FAIL → fix → /verify → re-review (max 3)

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.