lxyerlxyer/multi-agent-collaboration-system/.agents/skills/finish-work/SKILL.md

finish-work

Skill1 starsChanged 7 months agoMITView on GitHub

Pre-commit quality checklist covering lint, typecheck, tests, code-spec sync, API changes, database migrations, cross-layer verification, and manual testing. Blocks commit if infra or cross-layer specs lack executable depth. Use when code is written and tested but not yet committed, before submitting changes, or as a final review before git commit.

2 other projects use a version of this.

Adopted by

Most recently taken up by

serionist/claude-session-restoretheir own version, first seen Nov 8, 2026
futex-ai/skillstheir own version, first seen Oct 25, 2026

Other versions2 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 2
futex-ai/skills★ 1same name
serionist/claude-session-restore★ 0same name
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository16 other files it gives its agents.
- AGENTS.mdAGENTS.md
- CLAUDE.mdCLAUDE.md
- .github/copilot-instructions.mdCopilot instructions
- .cursor/rules/macs-protocol.mdcCursor rule
- before-devSkill
- brainstormSkill
- break-loopSkill
- check-cross-layerSkill
- checkSkill
- create-commandSkill
- improve-utSkill
- integrate-skillSkill
- onboardSkill
- record-sessionSkill
- startSkill
- update-specSkill

The file

We split this skill into the rules it gives an agent

8 rules. About 0 are common, 7 are distinctive, and 1 is very specific to this project.

≈0
Common · estimate
Many files like this have a rule of this kind.
≈7
Distinctive · estimate
This author's own choices. Worth a look.
1
Very specific
Tied to their project's names, files or tools. Probably skip.

Common
Distinctive
Very specific

Distinctive:
Before submitting or committing, use this checklist to ensure work completeness.
line 8
Distinctive:
Timing: After code is written and tested, before commit
line 10
Distinctive:
If YES -> Update the relevant code-spec doc.
line 45
Distinctive:
If this change touches infra or cross-layer contracts, this is a blocking checklist:
line 49
Very specific:
If infra/cross-layer changed but the related spec is still abstract, do NOT finish.
line 58
Distinctive:
If you modified API endpoints:
line 62
Distinctive:
If you modified database schema:
line 71
Distinctive:
If the change spans multiple layers:
line 80

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.

Files

SKILL.md

Finish Work - Pre-Commit Checklist

Before submitting or committing, use this checklist to ensure work completeness.

Timing: After code is written and tested, before commit

Checklist

1. Code Quality

# Must pass
pnpm lint
pnpm type-check
pnpm test

pnpm lint passes with 0 errors?
pnpm type-check passes with no type errors?
Tests pass?
No console.log statements (use logger)?
No non-null assertions (the x! operator)?
No any types?

2. Code-Spec Sync

Code-Spec Docs:

Does .trellis/spec/backend/ need updates?
- New patterns, new modules, new conventions
Does .trellis/spec/frontend/ need updates?
- New components, new hooks, new patterns
Does .trellis/spec/guides/ need updates?
- New cross-layer flows, lessons from bugs

Key Question:

"If I fixed a bug or discovered something non-obvious, should I document it so future me (or others) won't hit the same issue?"

If YES -> Update the relevant code-spec doc.

2.5. Code-Spec Hard Block (Infra/Cross-Layer)

If this change touches infra or cross-layer contracts, this is a blocking checklist:

Spec content is executable (real signatures/contracts), not principle-only text
Includes file path + command/API name + payload field names
Includes validation and error matrix
Includes Good/Base/Bad cases
Includes required tests and assertion points

Block Rule: If infra/cross-layer changed but the related spec is still abstract, do NOT finish. Run $update-spec manually first.

3. API Changes

If you modified API endpoints:

Input schema updated?
Output schema updated?
API documentation updated?
Client code updated to match?

4. Database Changes

If you modified database schema:

Migration file created?
Schema file updated?
Related queries updated?
Seed data updated (if applicable)?

5. Cross-Layer Verification

If the change spans multiple layers:

Data flows correctly through all layers?
Error handling works at each boundary?
Types are consistent across layers?
Loading states handled?

6. Manual Testing

Feature works in browser/app?
Edge cases tested?
Error states tested?
Works after page refresh?

Quick Check Flow

# 1. Code checks
pnpm lint && pnpm type-check

# 2. View changes
git status
git diff --name-only

# 3. Based on changed files, check relevant items above

Common Oversights

Oversight	Consequence	Check
Code-spec docs not updated	Others don't know the change	Check .trellis/spec/
Spec text is abstract only	Easy regressions in infra/cross-layer changes	Require signature/contract/matrix/cases/tests
Migration not created	Schema out of sync	Check db/migrations/
Types not synced	Runtime errors	Check shared types
Tests not updated	False confidence	Run full test suite
Console.log left in	Noisy production logs	Search for console.log

Relationship to Other Commands

Development Flow:
  Write code -> Test -> $finish-work -> git commit -> $record-session
                          |                              |
                   Ensure completeness              Record progress
                   
Debug Flow:
  Hit bug -> Fix -> $break-loop -> Knowledge capture
                       |
                  Deep analysis

$finish-work - Check work completeness (this skill)
$record-session - Record session and commits
$break-loop - Deep analysis after debugging

Core Principle

Delivery includes not just code, but also documentation, verification, and knowledge capture.

Complete work = Code + Docs + Tests + Verification

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

It worked
Partly
It didn't

What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

Check your setup, free