agentleFS
kadaliaokadaliao/skills/high-signal-review/SKILL.md

high-signal-review

Skill0 starsChanged 4 months agoMITView on GitHub

Use when reviewing a diff, pull request, patch, or implementation. Reports only concrete, change-induced, evidence-backed correctness, security, compatibility, or meaningful performance issues; suppresses speculative, stylistic, and out-of-scope feedback.

The file

We split this skill into the rules it gives an agent

8 rules. About 0 are common, 7 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈7

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    If a concern fails any part of this gate, do not present it as a finding.

    line 29
  2. Distinctive:

    Only include architecture, maintainability, polish, or optional test suggestions when the user explicitly asks for them.

    line 42
  3. Distinctive:

    P3 - do not use unless the user explicitly requests non-blocking feedback.

    line 51
  4. Distinctive:

    Do not raise severity because a scenario is merely possible.

    line 53
  5. Distinctive:

    Read the task and diff first.

    line 58
  6. Distinctive:

    Keep only the highest-signal independent findings.

    line 64
  7. Very specific:

    After findings, include Test gaps only for a concrete changed behavior that remains unverified and has a realistic regression path.

    line 75
  8. Distinctive:

    When no concern passes the Finding Gate, state exactly:

    line 79

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

High-Signal Review

Review for defects and regression risk, not hypothetical perfection. Prefer no findings over weak findings. Always respond in the user's language.

Finding Gate

Report a finding only when every condition holds:

  1. Change-induced - the diff introduced the problem, made it materially worse, or made a pre-existing issue newly reachable.
  2. Concrete impact - it can cause incorrect behavior, data loss, a security issue, a supported compatibility break, or a meaningful performance regression.
  3. Realistic trigger - identify the input, state, caller, or execution path that causes it.
  4. Evidence - ground it in the changed code, a caller, a type, a test, or a documented contract.
  5. Actionable remedy - the author can make a specific, local correction.

If a concern fails any part of this gate, do not present it as a finding.

Do Not Report By Default

  • Naming, formatting, style, or personal design preferences.
  • Refactors or abstractions that are not needed to correct a defect in this diff.
  • Hypothetical future scale, reuse, extensibility, or architecture concerns.
  • Generic advice such as "could be cleaner," "might be safer," or "consider X."
  • Missing error handling for failure modes not reachable from the changed path.
  • Pre-existing issues unrelated to the diff.
  • Missing tests without a concrete changed behavior and realistic untested regression path.

Only include architecture, maintainability, polish, or optional test suggestions when the user explicitly asks for them. Label those as non-blocking suggestions, never as defects.

Severity

  • P0 - data loss, security compromise, or production outage.
  • P1 - definite incorrect behavior on a supported or common path.
  • P2 - definite edge-case regression with a concrete trigger.
  • P3 - do not use unless the user explicitly requests non-blocking feedback.

Do not raise severity because a scenario is merely possible. Merge multiple symptoms with the same root cause into one finding.

Review Workflow

  1. Read the task and diff first. Treat stated behavior changes as intentional unless they conflict with an established contract.
  2. Trace changed inputs, outputs, state transitions, error paths, and relevant callers or consumers.
  3. Inspect tests only for changed behavior and realistic boundary conditions.
  4. Apply the Finding Gate to each candidate concern.
  5. Keep only the highest-signal independent findings. Do not pad the review.

Output

List findings first, ordered by severity. Each finding must include:

  • severity and file:line
  • triggering scenario
  • concrete impact
  • concise remediation direction

After findings, include Test gaps only for a concrete changed behavior that remains unverified and has a realistic regression path. Omit the section when there are none.

When no concern passes the Finding Gate, state exactly:

No actionable correctness or regression issues found.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.