agentleFS
jscott3201jscott3201/yet-more-skills/skills/typescript-review/SKILL.md

typescript-review

Skill4 starsChanged 2 months agoApache-2.0View on GitHub

Perform a focused TypeScript/UI correctness review or review a frontend diff for reachable defects, missing evidence, data races, accessibility, and contract drift. Not a new PR approval gate.

6 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 4 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Check resource cleanup and repeated use, not only first render.

    line 20
  2. Distinctive:

    Use framework-correct reasoning: React hooks/effects and Svelte runes/ownership are different.

    line 22
  3. Distinctive:

    Follow the existing review and delivery loop.

    line 42
  4. Distinctive:

    Read practice notes and sources only when the task needs more depth.

    line 48

“Common” is measured: kept by at least 6 in 10 of the 4 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

TypeScript and UI Review

Read the change in context

Establish the requested review scope and repository rules. Trace affected callers, state owners, generated contracts, and tests. Distinguish the intended behavior from current implementation and source comments. Review a coherent outcome; do not turn a focused patch into an unrelated frontend modernization program.

Look for consequential defects

Inspect unsafe narrowing, hidden null/undefined states, precision loss, changed serialization, unknown discriminator handling, and edits to generated files. Follow async results through changing props, route/site/session identity, unmount, cancellation, and revision conflict. Check resource cleanup and repeated use, not only first render.

Use framework-correct reasoning: React hooks/effects and Svelte runes/ownership are different. Match shadcn component APIs to the actual primitive backend and installed source. Check form submit semantics, focus, labels, keyboard behavior, and browser/server separation.

For operational screens, verify that stale/unknown evidence is not shown as normal, a local interaction is not treated as backend authority, and an accepted command is not presented as a confirmed physical result. Assess performance claims against measured workloads rather than endorsing speculative memoization or loop rewrites.

Verify evidence and report

Inspect which package, test filter, environment, and build actually ran. Type checks, component tests, browser tests, and visual inspection are separate evidence. Confirm that a new test would fail for the original defect. Do not accept empty selections, automatic golden updates, disabled checks, or broad retries as proof.

Report each actionable finding with location, reachable trigger, impact, and a focused remedy or regression. Label uncertainty and unrun checks. Keep stylistic preferences separate from correctness issues and use the repository's severity language.

Follow the existing review and delivery loop. This skill does not add an approval cycle, authorize changes/merges, or override another role's ownership. A clean review is bounded to the inspected scope; do not claim exhaustive certification.

Further guidance

Read practice notes and sources only when the task needs more depth.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.