agentleFS
joaoguimaraesprojoaoguimaraespro/personal-finance/.cursor/rules/common-code-review.mdc

personal-finance / rules

Cursor rule1 starsChanged todayMITView on GitHub

When to review, the review checklist, severity levels and which Armature reviewer agent to use

The file

We split this common-code-review.mdc into the rules it gives an agent

2 rules. About 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    After writing or changing code, before a pull request.

    line 10
  2. Distinctive:

    Always when the change touches authentication, authorisation, user input, database queries, file system access, external calls, …

    line 11

≈ “Common” is an estimate: at least 1 in 5 of the 6,809 Cursor rule files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
common-code-review.mdc
---
description: "When to review, the review checklist, severity levels and which Armature reviewer agent to use"
globs: 
alwaysApply: true
---
<!-- Generated by armature from core/rules/common/code-review.md. Edit the source rule, not this file. -->
# Code review (all languages)

## When
- After writing or changing code, before a pull request.
- Always when the change touches authentication, authorisation, user input, database queries, file system access,
  external calls, cryptography or money.
- Request review only when the gate and CI are green and the branch is up to date with its base.

## Checklist
- [ ] Does what the task or spec asked, no more and no less
- [ ] Readable, well named, functions focused, no deep nesting
- [ ] Errors handled explicitly; input validated at the boundary
- [ ] No secrets, debug output or commented-out code
- [ ] Tests exist for the new behaviour and none were removed or skipped
- [ ] No N+1 queries, unbounded queries or missing pagination

## Severity
| Level | Meaning | Action |
|---|---|---|
| CRITICAL | Security hole or data loss | Block: fix before merge |
| HIGH | Bug or significant quality issue | Fix before merge |
| MEDIUM | Maintainability concern | Consider fixing |
| LOW | Style or minor suggestion | Optional |

## Agents
| Agent | Use for |
|---|---|
| `security-reviewer` | Auth, input handling, injection, secrets, personal data, dependencies |
| `csharp-reviewer` | C#/.NET changes (stack-dotnet pack) |
| `typescript-reviewer` | TypeScript, Angular, React/Next.js changes (stack-typescript pack) |
| `build-error-resolver` | A failing build, type check or format check |

Reviewers report findings; they do not edit code. A person merges; nothing merges automatically.

<!-- Adapted from affaan-m/ECC rules/common/code-review.md and agents.md (MIT) at d2ef268; agents rewritten to Armature's. -->

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.