skill-al-review-pipeline
Skill115 starsChanged 11 days agoMITView on GitHub
Review an AL increment or audit scope using the configured BCQuality provider and evidence-based native coverage. Shared by Developer Reviewer, Conductor review and Dredd; does not implement fixes or run builds.
In this repository55 other files it gives its agents.
- CLAUDE.mdCLAUDE.md
- claude-plugin/CLAUDE.mdCLAUDE.md
- .github/copilot-instructions.mdCopilot instructions
- instructions/copilot-instructions.mdCopilot instructions
- agent-builderSkill
- al-agent-build-instructionsSkill
- al-agent-createSkill
- al-agent-instructionsSkill
- al-agent-taskSkill
- al-agent-testSkill
- al-buildSkill
- al-context-createSkill
- al-initializeSkill
- al-memory-createSkill
- al-pr-prepareSkill
- al-spec-createSkill
- architectSkill
- auditSkill
- conductSkill
- developSkill
- presalesSkill
- reviewSkill
- skill-agent-instructionsSkill
- skill-agent-task-patternsSkill
- skill-agent-toolkitSkill
- skill-al-review-pipelineSkill
- skill-apiSkill
- skill-contribution-assistantSkill
- skill-copilotSkill
- skill-debugSkill
- skill-estimationSkill
- skill-eventsSkill
- skill-migrateSkill
- skill-pagesSkill
- skill-performanceSkill
- skill-permissionsSkill
- skill-testingSkill
- skill-translateSkill
- specSkill
- triageSkill
- skill-agent-instructionsSkill
- skill-agent-task-patternsSkill
- skill-agent-toolkitSkill
- skill-apiSkill
- skill-contribution-assistantSkill
- skill-copilotSkill
- skill-debugSkill
- skill-estimationSkill
- skill-eventsSkill
- skill-migrateSkill
- skill-pagesSkill
- skill-performanceSkill
- skill-permissionsSkill
- skill-testingSkill
- skill-translateSkill
The file
Show its rules and text
We split this skill into the rules it gives an agent
18 rules. About 0 are common, 12 are distinctive, and 6 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈12
Distinctive · estimate
This author's own choices. Worth a look.
6
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 7
Read the provider contract and task-context guidance.
- Distinctive: line 15
Start from the requested files/diff and acceptance criteria.
- Distinctive: line 19
Read relevant rules explicitly.
- Distinctive: line 20
Verify claims in an implementer's report against current code and evidence.
- Distinctive: line 29
Follow the loaded provider's execution model.
- Distinctive: line 38
Follow provider relevance rules.
- Very specific: line 46
When the provider documents bounded retrieval helpers (BCQuality: tools/Search-Knowledge.ps1 for the catalog and …
- Very specific: line 55
When the project carries an installer receipt (.github/aldc-bcquality-index.json) whose corpusSha matches the observed corpus revision, …
- Distinctive: line 64
If lookup fails, name the exact resource, attempted operation and observed error.
- Distinctive: line 72
Only completed provider results reduce native coverage.
- Distinctive: line 77
Do not assume a custom BCQuality layer exists or covers ALDC conventions.
- Very specific: line 87
Always run the five security checks of review.security against al-security.instructions.md, whatever the provider covered.
- Distinctive: line 98
Where the selection comes from: Use the selection the caller supplied (Conductor passes it inline).
- Very specific: line 121
When the app extends Agent Metadata Provider, also fill review.agent-sdk from the *Completeness checklist* in …
- Distinctive: line 126
Use the shared review report for direct/Conductor reviews.
- Distinctive: line 130
Keep original provider sub-results intact.
- Very specific: line 142
When declared review criteria were supplied (<req>.bcq-criteria.json), report them in review.criteria after the findings are final: a …
- Very specific: line 146
not-evaluated: when that domain's check did not complete.
≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
AL review pipeline
Read the provider contract and task-context guidance. Resolve these links from this installed skill, not a sibling repository. This procedure supplements the caller's write scope, report format and human gate; it grants no extra tools and never authorizes changes to the provider or AL code.
Scope and independent evidence
Start from the requested files/diff and acceptance criteria. A standalone reviewer resolves context itself; a Conductor reviewer consumes the supplied phase context and reads precise references only for gaps. An explicitly attached object is a valid scope without a Git diff. Missing source means no code review has occurred. Read relevant rules explicitly; do not assume another agent loaded them for you. Verify claims in an implementer's report against current code and evidence. Never approve code generated in your own context as an independent review.
Execute the selected provider
- Select the provider from this project's configuration. In plugin mode discover
the exact configured identity in the host and load its instructions here;
home,entryPointandworkspacebelong to multiroot selection. Do not fall back to a different clone or rename a skill implicitly. - Follow the loaded provider's execution model. For an instruction-based skill, loading starts the workflow: apply its Entry/routing, READ/DO and dispatched checks to the actual inputs. You produce their results; do not wait for the host to emit them automatically or recursively invoke the same skill. A tool invocation is required only when the loaded provider actually requires one.
- Derive layers and filters from supported provider configuration/defaults.
Preserve the actual routing result. Do not pick only the most obvious leaf:
account for each dispatched check and each applicable child of a super-skill
as completed, not applicable, skipped with reason, partial, failed or pending.
Follow provider relevance rules; do not execute irrelevant checks merely to
fill a table. Reuse already-read knowledge within this invocation.
Entry may return more than one top-level skill in
dispatch[]— for example theal-code-reviewsuper-skill plus the Communityal-agents-reviewleaf, which is a first-level peer and not one of the super-skill's children. Execute every dispatched entry and retain every resulting findings-report; never treat the first report as the whole run. Roll each one intosub-resultsand account for it in coverage under its own domain label. When the provider documents bounded retrieval helpers (BCQuality:tools/Search-Knowledge.ps1for the catalog andtools/Get-KnowledgeArticles.ps1for bodies), prefer them over ad-hoc reads where an execution capability exists: they page deterministically, cap each response, and return per-article SHA-256 so a cited body is provably the one that was read. Without that capability, use the provider's native bounded reads through EOF and never treat a retrieval failure as an empty result. - Index refresh is independent. If writes/PowerShell are unavailable or forbidden,
record
provider.index.status: not-attemptedand use the provider's documented path-based lookup. When the project carries an installer receipt (.github/aldc-bcquality-index.json) whosecorpusShamatches the observed corpus revision, reportprovider.index.status: prebuiltwith the receipt's generator, index path, SHA-256 and corpus revision; a bare status is refused. Map the receipt into the observation asindexPath→index.path,indexSha256→index.sha256;generatorandcorpusShacarry over unchanged. Then use the provider's index-backed retrieval — including its bounded pagination and per-article content-hash validation. A mismatched or absent receipt isnot-attempted, not a failure. A missing fresh index alone does not cancel code review. If lookup fails, name the exact resource, attempted operation and observed error. - Retain actual sub-results and references. Reading a leaf or describing its
intended behavior is not a completed check. An executed attempt can fail or be
partial;
executed: truedoes not mean success. Never reconstruct unobserved results afterwards as evidence. Zero findings is valid for completed checks.
Cover gaps without inventing parity
Only completed provider results reduce native coverage. Check applicable ALDC rules/skills for uncovered domains: naming, performance, error handling, events, permissions, APIs and testing. Check extension boundaries, actual project layout, and approved acceptance criteria. Do not require a particular folder layout merely because it appears in an example; identify the project's governing rule. Do not assume a custom BCQuality layer exists or covers ALDC conventions. Where no native equivalent exists, report the coverage gap explicitly.
Separate findings from coverage. A valid minor convention finding need not imply a
compiler/runtime error. Cite the exact applicable rule and file location; retain,
resolve or retract it based on evidence, not because another provider found nothing.
contracts.namingConvention in aldc.yaml names planning documents, not AL files.
Security and BCQuality disposition
Always run the five security checks of review.security against
al-security.instructions.md, whatever the provider covered. They exist because every
agent-built app audited in October 2026 failed the same points (MCP with writes for
everything, wide permission sets, unencrypted keys, var events that skip a check).
Reading an article is not applying it. Open each article of the BCQuality selection
and give it a disposition in review.bcquality.articles (applied, not-applicable
with reason, or dismissed with a technical reason citing file:line). The requirement
not asking for something is never a reason to dismiss an applicable article: report it
as a finding instead.
Where the selection comes from. Use the selection the caller supplied (Conductor
passes it inline). When there is none and BCQuality is enabled, make it yourself before
reviewing: from the configured BCQuality root, pick the knowledge articles that concern
the domains and object types of the changed code, using the provider's catalog search
(BCQuality: tools/Search-Knowledge.ps1), its knowledge skill (al-knowledge) or its
documented path-based lookup. Record how you selected them in provider.detail. With
enabled: false there is no selection and nothing is probed.
Two execution paths for BCQuality. In the October 2026 Claude Code runs a provider skill loaded inside a subagent never completed Entry → dispatch → leaves; this host has not been measured. So:
- Selection path (primary, always). The selection comes from the same BCQuality
root the provider is loaded from. Reading every selected article and giving each a
disposition is an executed BCQuality check for those articles: set
review.bcquality.outcome: "selection-completed"andprovider.execution: "aldc-selection"with the number of articles. Do not mark the reviewpartialbecause Entry was not run. - Provider path (extra, when feasible). You may also run the provider's Entry flow
(
al-code-review) as described above. If it completes, keep its sub-results verbatim and setoutcome: "completed". If it does not complete, record that inprovider.detailand keep the selection result; it is not a failure. A selected article without a disposition is the only BCQuality reason forpartial.
When the app extends Agent Metadata Provider, also fill review.agent-sdk from the
Completeness checklist in al-agent-toolkit.instructions.md.
Return an honest result
Use the shared review report for direct/Conductor reviews; Dredd keeps its advisory Audit-Report format. In either format include a compact coverage list with domain/check, status, source and evidence/reason, plus the provider identity and independent index state. Keep original provider sub-results intact; coverage is the caller's summary. A requested check left pending makes the overall result partial. Provider failure with fully completed, adequate native coverage may still complete the stated native scope, but must not be presented as a completed BCQuality review.
Compilation and tests are separate evidence: record current-artifact evidence as validated or not validated and say whether supplied or actually executed. Static analysis and Problems are not a build or a runtime test. For an explicitly static review, absence of a build is a limitation, not an invented AL defect. For a delivery gate requiring build/tests, missing evidence keeps that gate pending. A partial/failed review never becomes approval merely because finding counts are zero.
When declared review criteria were supplied (<req>.bcq-criteria.json), report them
in review.criteria after the findings are final: a criterion is unmet when a
retained finding cites its path (match on references[0].path), met when its
domain was completed by the provider and no retained finding cites it, and
not-evaluated when that domain's check did not complete. Count house rules
(layer: custom) separately. This is bookkeeping over findings that already exist;
it adds no finding, changes no severity and never alters the verdict.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

