frontend-review-checklist
Skill0 starsChanged 4 months agoMITView on GitHub
Enterprise Angular/frontend code review standard. Use when reviewing any frontend PR or diff, when the user asks for a code review of Angular/TypeScript code, or before submitting frontend changes. Encodes the cross-team review bar so it applies consistently without the senior reviewer present.
In this repository11 other files it gives its agents.
- angular-enterpriseSkill
- angular-migrationSkill
- characterization-testsSkill
- claude-md-architectSkill
- code-archaeologySkill
- feature-flag-changeSkill
- rxjs-modernizeSkill
- session-hygieneSkill
- session-stateSkill
- strangler-migrationSkill
- tdd-loopSkill
The file
We split this skill into the rules it gives an agent
3 rules. About 0 are common, 3 are distinctive, and 0 are very specific to this project.
≈0
Common · estimate
Many files like this have a rule of this kind.
≈3
Distinctive · estimate
This author's own choices. Worth a look.
0
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Distinctive: line 9
Run top to bottom; report only violations + verdict.
- Distinctive: line 20
No nested subscribes; use higher-order mapping operators.
- Distinctive: line 21
Every subscription has a termination story (async pipe preferred, takeUntilDestroyed otherwise).
≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
<!-- owner: Muskan, added: 2026-07-16, model: claude-sonnet-5, review: quarterly -->Frontend Review Checklist (Angular/enterprise)
Run top to bottom; report only violations + verdict.
Architecture
- Components: presentation only. Business logic in services/facades; data flow through the sanctioned state pattern (see angular-enterprise skill / CLAUDE.md). Component injecting HttpClient directly = violation.
- One-way data flow: no parent state mutation from children; events up.
- Module/standalone boundaries respected; no deep imports across feature
boundaries (
feature-a/src/internal/*from feature-b = violation).
State & Rx
- No nested subscribes; use higher-order mapping operators.
- Every subscription has a termination story (async pipe preferred, takeUntilDestroyed otherwise). Manual unsubscribe arrays = flag.
- Selectors pure and memoized; effects contain no view logic.
Change safety
- Public component API changes (inputs/outputs) list affected consumers.
- Template changes: check null-safety of new bindings; strict-mode clean.
- New third-party component usage documented against the quirks section.
Quality gates
- Tests: behavior-level, not TestBed-boilerplate-only; assertions exist.
- A11y: interactive elements keyboard-reachable, labels/aria present.
- Perf: no functions called in templates; trackBy on ngFor over data lists; bundle-affecting imports (moment, full lodash) = violation.
Verdict format
APPROVE / REQUEST-CHANGES + violations as file:line — rule — fix.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

