agentleFS
gtrabancogtrabanco/agentic-workflow/skills/review-verify/SKILL.md

review-verify

Skill23 starsChanged 51 days agoMITView on GitHub

Internal run-it verification review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Runs the project's gate and the changed behavior for real — commands, exit codes, observed output — instead of assuming; what cannot be executed goes to the manual checklist. Findings only; never edits code.

The file

We split this skill into the rules it gives an agent

2 rules. About 0 are common, 2 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Not findings: comment/punctuation typos, formatting-only drift, style preference with no cited rule, hypothetical robustness beyond the …

    line 64
  2. Distinctive:

    Every checklist item was evaluated with evidence (file:line or command output) or explicitly marked n/a with the reason.

    line 94

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review Verify (internal)

Composed by review-change / product-audit within their conversation — on any agent, follow this file inline as the routed step. Findings only; never edits, never refactors.

Shift from discoverer to auditor of recorded evidence (S5). The implementer's claim-evidence loop is the primary verification. This review audits the recorded evidence: re-runs a sample of the recorded commands instead of re-deriving the whole change. This is the cost-scaling invariant — reviewers dig into code only when evidence is absent or contradicts.

Scope

The diff or path/glob the caller passes; default the current change vs the default branch. State the scope at the top of the returned table.

Checklist (evaluate EVERY item — none is optional; n/a must be stated)

✓ Evidence audit. Sample the unit doc's Evidence rows: re-run ≥ 3 of the recorded commands and compare observed output against what the implementer recorded. Mismatch → finding: "evidence contradicts observation at file:line". ✓ Claim-evidence loop verification. Check the fold's claim table (if present): every row has status: ✓. Any ✗ row means the implementer's turn did not complete its claim-evidence loop. ✓ Unit-route triage currency. Re-run bun scripts/unit-route.mjs --triage <slug> and compare the Steps: line against the unit doc's Evidence section. Mismatch → stale triage. ✓ The project's verification gate ran in THIS review (type-check, tests, build per the project's declared commands) — paste exit status per command ✓ The change's primary claimed behavior was exercised for real (run the CLI/endpoint/function; paste the actual observed output) — in addition to the evidence audit, verify at least one behavioral claim not covered by recorded evidence ✓ At least one failure-mode from the SPEC's dev scenarios was reproduced (bad input, missing file, error path) and behaved as specified ✓ New/changed tests actually fail when the implementation is reverted or broken (mutate or stash to prove they assert something — restore after) ✓ No test was skipped/disabled to get green (grep for skip/only/todo markers in the diff) ✓ The build artifact/dev server starts cleanly (no new warnings that indicate breakage) ✓ Anything that can only be confirmed by a human (visual, device, locale, load) is listed explicitly under "Manual" — never silently dropped

Materiality bar

Report a row only when a competent user's outcome changes or a rule the project explicitly declares is violated — cite the rule it violates beside the evidence. Not findings: comment/punctuation typos, formatting-only drift, style preference with no cited rule, hypothetical robustness beyond the SPEC's named scenarios. An empty table with Decision: PASS is the expected result for a well-formed change — never pad the table.

Return exactly

Sev and Impact are the two published closed sets (BLOCKER | CRITICAL | WARNING | SUGGESTION and blocking | docs-only | report-only); their meanings are owned by review-implementation (CLASSIFY.md §Severity ladder) — assign a token, never a prose grade.

REVIEW VERIFY — scope: <scope>

| # | Finding | Sev | Impact | Evidence | Suggested fix |
|---|---------|-----|--------|----------|---------------|
| 1 | <what>  | BLOCKER|CRITICAL|WARNING|SUGGESTION | blocking|docs-only|report-only | <file:line> | <smallest action> |

Checklist: <n> evaluated, <n> pass, <n> findings, <n> n/a (<which + why>)
Summary: <1-2 sentences>
Manual (a human must check): <bullet list, or "none">
Decision: PASS | FAIL

FAIL if any BLOCKER, CRITICAL or WARNING finding is open; PASS otherwise. SUGGESTION findings never block — they route to the caller's triage step.

Done when

  • Every checklist item was evaluated with evidence (file:line or command output) or explicitly marked n/a with the reason.
  • The fixed-format block above is returned — nothing more, nothing less — and no code was changed.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.