agentleFS
gdhub-iogdhub-io/character-forge-mcp/.claude/skills/contribute/SKILL.md

contribute

Skill1 starsChanged 4 days agoMITView on GitHub

Take a change to character-forge-mcp from intent to pull request — an issue for the intent, a branch linked to it, develop with tests, refactor (/simplify), review (/code-review), and a PR that closes the issue on merge. Use when asked to implement, fix or change something in this repo, or to "make a PR".

  • Commits and pushes

16 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use review-pr.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • DockerSkill

    review-pr

    Review one or more incoming Docker documentation pull requests as a maintainer. Independently validate technical claims, assess editorial fit and information architecture, choose a verdict, and draft exact inline or PR-wide feedback behind a confirmation gate. Use for requests such as "review PR 123", "is this PR correct?", "does this information belong here?", "validate this PR", or "help review backlog PRs". Do not use to maintain or fix a PR you own; use maintain-pr for that.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

8 rules. 0 are common, 5 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 15 edited versions we read keep these.

  • 5

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    If the working tree has unrelated changes, stop and ask what to do with them.

    line 13
  2. Very specific:

    Follow CLAUDE.md (architecture, the card-field checklist, English-only product text, .js import extensions).

    line 16
  3. Distinctive:

    Add or update tests for the behavior you change.

    line 17
  4. Distinctive:

    Don't bump versions or edit CHANGELOG.md: Release Please does that.

    line 18
  5. Distinctive:

    Commit in small steps with Conventional Commit messages.

    line 19
  6. Very specific:

    Run the simplify skill on the branch's diff and apply what it finds (or note why a finding was skipped).

    line 22
  7. Very specific:

    Run the code-review skill on the branch and fix confirmed findings.

    line 26
  8. Distinctive:

    If the work turns out to need more, open follow-up issues instead of growing the PR.

    line 36

“Common” is measured: kept by at least 6 in 10 of the 15 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Contribute: issue → branch → develop → refactor → review → pull request

Nobody pushes to main; it is protected. Every change answers an issue, and its pull request closes that issue when it is squash-merged (the PR title becomes the commit Release Please reads). Follow the steps in order and tell the user, briefly, where you are. Creating issues, pushing and opening PRs are outward-facing: ask the user before the first one in a task.

1–2. Intent and branch

Run the intent skill: it finds or opens the issue, writes the intent into it (want, why, constraints, done when, how to check, out of scope), and opens a branch linked to the issue with gh issue develop N. A typo or one-file fix gets a short issue instead of a full intent, but always an issue.

If the working tree has unrelated changes, stop and ask what to do with them.

3. Develop

  • Follow CLAUDE.md (architecture, the card-field checklist, English-only product text, .js import extensions).
  • Add or update tests for the behavior you change. Tests never call paid APIs.
  • Don't bump versions or edit CHANGELOG.md: Release Please does that.
  • Commit in small steps with Conventional Commit messages.

4. Refactor

  • Run the simplify skill on the branch's diff and apply what it finds (or note why a finding was skipped).

5. Review

  • npm run lint and npm test must pass (one at a time; they are heavy for this machine).
  • Run the code-review skill on the branch and fix confirmed findings.
  • Run the security-check skill on the branch and fix confirmed findings.
  • Re-read the full diff (git diff main...HEAD) as a stranger: no debug leftovers, no keys, nothing from characters/.

6. Pull request that closes the issue

  • git push -u origin <branch>, then gh pr create with:
    • Title in Conventional Commits, typed by who the change is for (CONTRIBUTING.md, "Commit and PR titles"): feat/fix/perf only for changes users of the tool notice (they make a release); docs, refactor, test, ci, build, chore otherwise. ! only when users must change something. Imperative, under 70 characters.
    • Body from .github/pull_request_template.md, starting with Closes #N. The "Linked issue" check fails without it, and on merge GitHub closes the issue. "How to verify" comes from the intent's "How to check it".
  • Comment on the issue what was decided along the way and what was deliberately not done.
  • Report the PR link. Then wait for CI; if it fails, read the logs (gh pr checks, gh run view --log-failed) and fix on the same branch.
  • If the work turns out to need more, open follow-up issues instead of growing the PR.

Merging is the maintainer's call: don't merge unless asked.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.