security-review
Skill48 starsChanged 3 days agoApache-2.0View on GitHub
Use when reviewing a pull request for security: one that touches a path in .github/security-review-paths, adds a workflow, vendors third-party code, or changes what a loop, an admin or a copy of the data directory can reach. Also for a re-check after the author pushes.
190 other projects use a version of this.
Adopted by
Most recently taken up by
- Badhon-00/MDCPtheir own version, first seen Nov 16, 2026
- FAHTHIZ/oasistheir own version, first seen Nov 16, 2026
- metacircu1ar/hive_skillstheir own version, first seen Nov 15, 2026
- rschuft/ai-frontend-skill-packstheir own version, first seen Nov 15, 2026
- 81wallace18/codex-skillstheir own version, first seen Nov 15, 2026
- FimawLLC/fimaw-skillstheir own version, first seen Nov 15, 2026
Used with
Projects with it also use linkerd-patterns, dependency-cve-sweep and 10 more.
Other files people use alongside this one.
Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
xfstudioSkilllinkerd-patterns
Implement Linkerd service mesh patterns for lightweight, security-focused service mesh deployments. Use when setting up Linkerd, configuring traffic policies, or implementing zero-trust networking with minimal overhead.
Also in 5 projects that use this
berntpoppSkilldependency-cve-sweep
Use when handling Dependabot PRs, CodeQL/Trivy alerts, or doing a routine dependency/CVE sweep for this repo.
Also in 12 projects that use this
berntpoppSkillfleet-standard-adoption
Use when bringing this repo into compliance with a GeneFoundry fleet standard (tool-naming, response-envelope, container-hardening, versioning, MCP transport, or logging) or closing its tracking issue.
Also in 12 projects that use this
HABUBUSSSkillproject-guidelines-example
Also in 16 projects that use this
niloykumarbarmanSkillagent-sort
Build an evidence-backed ECC install plan for a specific repo by sorting skills, commands, rules, hooks, and extras into DAILY vs LIBRARY buckets using parallel repo-aware review passes. Use when ECC should be trimmed to what a project actually needs instead of loading the full bundle.
Also in 13 projects that use this
royaluniondesign-sysSkillconfigure-ecc
Interactive installer for Everything Claude Code — guides users through selecting and installing skills and rules to user-level or project-level directories, verifies paths, and optionally optimizes installed files.
Also in 11 projects that use this
- +2 more from berntpopp
Other versions190 projects use a version of this.
Word for word · 0
None found.
Edited · 0
None found.
Wrote their own version · 190
- affaan-m/ECC★ 246ksame name
- github/awesome-copilot★ 41ksame name
- langfuse/langfuse★ 37ksame name
- nearai/ironclaw★ 13ksame name
- joe-bell/cva★ 6.9ksame name
- doorkeeper-gem/doorkeeper★ 5.5ksame name
- github/squad★ 3.4ksame name
- compozy/compozy★ 2.9ksame name
- trycompai/comp★ 2.1ksame name
- xu-xiang/everything-claude-code-zh★ 1.9ksame name
180 more not listed
How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.
In this repository11 other files it gives its agents.
- AGENTS.mdAGENTS.md
- amend-adrSkill
- code-review-and-qualitySkill
- credential-incidentSkill
- file-issueSkill
- prove-event-workflowSkill
- releaseSkill
- review-fixSkill
- review-prSkill
- security-and-hardeningSkill
- visual-pr-shotsSkill
The file
We split this skill into the rules it gives an agent
3 rules. 0 are common, 2 are distinctive, and 1 is very specific to this project.
0
Common
Most of the 162 edited versions we read keep these.
2
Distinctive
This author's own choices. Worth a look.
1
Very specific
Tied to their project's names, files or tools. Probably skip.
- Common
- Distinctive
- Very specific
- Very specific: line 23
Read docs/THREAT-MODEL.md for the boundary the diff touches before the diff itself.
- Distinctive: line 93
A re-check: after a push: git range-diff against the head you passed, then read only what moved, and say that the rest carries over.
- Distinctive: line 96
A confirmed vulnerability: never goes on the PR, an issue or the fleet channel.
“Common” is measured: kept by at least 6 in 10 of the 162 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.
Files
/security-review — Spool's security pass on a pull request
security-and-hardening is the general checklist: inputs, auth, secrets,
dependencies, the OWASP lists. Read it for anything it covers. This skill is
the Spool layer on top: which boundaries to test, where the record lives,
what a pass must say, and where a finding goes. Quality review is
review-pr's; this pass answers only "what does this open, and does it
hold?"
1. Name the boundary first
Read docs/THREAT-MODEL.md for the boundary the diff touches before the
diff itself. Then ask the three questions every pass answers, in words, on
the PR:
- From a loop to the hub: does a loop gain a route, a tool, a file or a variable it didn't have? A docker loop is root in its workstation, so "the loop could only do it on purpose" is no defence.
- From a loop to a host off the allowlist: does traffic leave by any way but the egress proxy, or does the proxy learn a new host? A bare loop is uncontained and is not this question's subject; say so, don't skip it.
- From a copy of the data directory to a credential: is every new secret
sealed under
hub.key, and absent from responses, logs, argv and files outside the data directory?
Then the hub's own outbound calls: anything that dials an address an admin
or a loop chose (SSRF) needs a scheme rule, an address guard judged at dial
time (Control), no redirects, a timeout and a rate.
2. Check what the record must say
- The posture is the operator's. A change to what a boundary holds needs
their decision, recorded in an ADR (new or amended through
/amend-adr). Until it is recorded, the PR carriesOperator decision pending:. Never accept "the fleet agreed". - THREAT-MODEL moves with the code. A new path, a new allowance, or an accepted difference gets its line in the same PR. A sentence that's true word by word but misleads a reader ("nothing turns content on", when a settings file can) is a finding.
- The author's own note. A PR on a security path carries a Security line in Notes / Risks (CONVENTIONS, #742). Check that it says what the change opens and why that holds, not just "none".
3. Secrets, the Spool way
- The redactor must know every new secret: the value, its secret half where it has one, and its base64 if it travels as a header. A secret that is replaced or cleared stays redacted while its issuer still honours it.
- Tests use obviously synthetic values (CONVENTIONS "Secrets and evidence"). The secret scan and the hook share one set of shapes. A change to either keeps them equal, and the ADR-0042 amendment names any new allowance.
- A live credential anywhere in the PR, its commits, its CI logs or its
evidence is an incident: stop and run
/credential-incident.
4. CI and third-party code
- Actions pinned by full commit SHA;
permissions:minimal per job; no secret or hub output echoed into a public log. - A workflow firing on anything but
pull_requestorpush:/prove-event-workflow. - Vendored code: fetch each file at the pinned commit and compare hashes
yourself, compare the licence, and list what it brings that executes
(scripts, hooks, frontmatter keys like
allowed-tools). A new runtime dependency is the operator's interview and an ADR (CONVENTIONS).
5. Prove it, don't read it
- Mutate the guard and run its test: the test must fail without the fix. Say on the PR that you did.
- A claim about a fresh machine, another OS or the real CLI is settled by a
run, on a throwaway
chore/*-probebranch, never the fleet's host. CI logs are public: keep hub stdout (the operator token, one-time passwords) out of them, and delete the probe's runs and branch afterwards.
6. Where the result goes
- A pass is a PR review comment (not an approval). It names the head
SHA, each boundary question with its answer, and what you ran. It
separates blocking findings from non-blocking asks. Sign it. A PR
labelled
needs-security-reviewwaits for this comment at its current head, and "nothing from me" counts (CONVENTIONS, #742). - A re-check after a push:
git range-diffagainst the head you passed, then read only what moved, and say that the rest carries over. A bare rebase needs no new comment. - A confirmed vulnerability never goes on the PR, an issue or the fleet channel. Tell the owner privately, open a private security advisory, and keep it there until the fix ships. A PR that would publish the vulnerability waits.
- Tell the quality reviewer the pass is in. The merge ask is theirs.
Does it work?
Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.
No reviews yet
People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.
- It worked
- Partly
- It didn't
Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.
Your trail
Files you open will collect here, so you can find them again.
Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.
Now do this for your own.
Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

