agentleFS
elithrarelithrar/dotfiles/.agents/skills/code-reviewer/SKILL.md

code-reviewer

Skill222 starsChanged 54 days agoMITView on GitHub

Review a specified code change for actionable defects. Use for uncommitted changes, base-branch diffs, commits, PRs or MRs; review alone is read-only, and requested fixes follow the review. Not a repository-wide security or complexity audit.

182 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use git-doc-updater, git-precommit and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • u9401066Skill

    git-doc-updater

    Auto-check and update key documentation before Git commits to keep docs in sync with code. Triggers: docs, 文檔, 更新文檔, sync docs, release, 發布.

    Also in 5 projects that use this

  • u9401066Skill

    git-precommit

    Orchestrate pre-commit workflow including Memory Bank sync, README/CHANGELOG/ROADMAP updates. Triggers: GIT, gc, push, commit, 提交, 準備 commit, 要提交了, git commit, pre-commit, 推送.

    Also in 5 projects that use this

  • JeffallanSkill

    shopify-expert

    Builds and debugs Shopify themes (.liquid files, theme.json, sections), develops custom Shopify apps (shopify.app.toml, OAuth, webhooks), and implements Storefront API integrations for headless storefronts. Use when building or customizing Shopify themes, creating Hydrogen or custom React storefronts, developing Shopify apps, implementing checkout UI extensions or Shopify Functions, optimizing performance, or integrating third-party services. Invoke for Liquid templating, Storefront API, app development, checkout customization, Shopify Plus features, App Bridge, Polaris, or Shopify CLI workflows.

    Also in 5 projects that use this

  • JeffallanSkill

    spec-miner

    Reverse-engineering specialist that extracts specifications from existing codebases. Use when working with legacy or undocumented systems, inherited projects, or old codebases with no documentation. Invoke to map code dependencies, generate API documentation from source, identify undocumented business logic, figure out what code does, or create architecture documentation from implementation. Trigger phrases: reverse engineer, old codebase, no docs, no documentation, figure out how this works, inherited project, legacy analysis, code archaeology, undocumented features.

    Also in 6 projects that use this

  • +4 more from u9401066
  • +4 more from Jeffallan

The file

We split this skill into the rules it gives an agent

12 rules. 0 are common, 11 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 155 edited versions we read keep these.

  • 11

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Keep review-only requests read-only.

    line 8
  2. Distinctive:

    Use the target named by the user.

    line 10
  3. Distinctive:

    Read the applicable AGENTS.md and repository review instructions.

    line 16
  4. Distinctive:

    Read enough surrounding implementation, tests, callers, and configuration to understand each changed path.

    line 19
  5. Distinctive:

    Verify each candidate finding from code, relevant history, or the smallest diagnostic check that can confirm or disprove it.

    line 21
  6. Distinctive:

    Prefer repository instructions and configured project commands.

    line 27
  7. Distinctive:

    Do not install dependencies, invoke generic package runners that may download tools, or run broad suites solely because a manifest exists.

    line 29
  8. Distinctive:

    Look for meaningful, change-introduced defects involving:

    line 35
  9. Distinctive:

    Do not report style preferences, speculative future concerns, intentional behavior changes, pre-existing problems, or mechanical issues …

    line 46
  10. Distinctive:

    Use multiple focused passes when useful, but do not delegate unless the user or host workflow explicitly requests independent reviewers.

    line 64
  11. Distinctive:

    Follow with one short paragraph describing the affected scenario and why the behavior is wrong.

    line 74
  12. Very specific:

    If no finding qualifies, say No findings.

    line 81

“Common” is measured: kept by at least 6 in 10 of the 155 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Code Reviewer

Keep review-only requests read-only. When the user also requests fixes, a PR, or posted findings, complete the review and then perform the authorized follow-up. The skill does not authorize additional external actions.

Use the target named by the user. If no target is given, review uncommitted changes. If the working tree is clean, report that no uncommitted target exists rather than silently reviewing the last commit.

Review behavior introduced or materially affected by the change. Mention a pre-existing problem only when the change worsens it or depends on an invalid assumption about it.

Workflow

  1. Read the applicable AGENTS.md and repository review instructions.
  2. Resolve the exact review target and inspect the complete diff.
  3. For a base-branch review, resolve the requested base and compute its merge base with the review head. Prefer the remote-tracking ref of that base when it is ahead of its local ref; the feature branch's own upstream is not the base.
  4. Read enough surrounding implementation, tests, callers, and configuration to understand each changed path.
  5. Identify the intended behavior, preserved invariants, externally reachable paths, and highest-risk changes.
  6. Verify each candidate finding from code, relevant history, or the smallest diagnostic check that can confirm or disprove it.
  7. Continue through the complete diff after finding an issue.
  8. Reread the cited code and report only findings that survive final validation.

Validation

Prefer repository instructions and configured project commands. Run a targeted check only when it can confirm or disprove a candidate finding or material regression.

Do not install dependencies, invoke generic package runners that may download tools, or run broad suites solely because a manifest exists.

Attribute a failure to the reviewed change before presenting it as a finding. Otherwise report it as a verification limitation.

Review Focus

Look for meaningful, change-introduced defects involving:

  • Correctness and state transitions.
  • Authorization, validation, secrets, or data exposure.
  • Concurrency, persistence, retries, or partial failure.
  • Public contracts and compatibility.
  • Performance on reachable paths and realistic input sizes.
  • Maintainability only when the change creates concrete bug risk or costly coupling.

Spend the most depth on high-impact or externally reachable paths.

Do not report style preferences, speculative future concerns, intentional behavior changes, pre-existing problems, or mechanical issues already enforced reliably by configured tooling.

Finding Standard

Report a finding only when all of these are true:

  • It affects correctness, security, performance, or maintainability meaningfully.
  • It is discrete and actionable.
  • It was introduced by the reviewed change.
  • The affected input, state, sequence, or call path can be demonstrated.
  • The author would probably fix it if they knew about it.

Cite the smallest changed line range that causes the issue. The cited range must overlap the reviewed diff. Explain the concrete scenario in the finding paragraph.

Drop speculative concerns and findings that cannot be tied to the reviewed change.

Review Passes

Use multiple focused passes when useful, but do not delegate unless the user or host workflow explicitly requests independent reviewers. Revalidate every compiled finding against the code. Disagreement is a reason to inspect further, not to choose the higher severity.

Output

Present findings first, ordered by priority. Use one entry per issue:

[P1] Imperative finding title — path/to/file.ts:42

Follow with one short paragraph describing the affected scenario and why the behavior is wrong. Add a fix direction only when it is not obvious.

  • P0: Universal release blocker or critical failure.
  • P1: Urgent defect that should be fixed next.
  • P2: Ordinary defect that should be fixed.
  • P3: Low-impact issue still worth fixing.

If no finding qualifies, say No findings. Then add a brief overall assessment and any material test gaps or residual risks.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.