GitHub PRs — Creation and Review Loops

Use this skill when creating PRs or addressing reviewer feedback.

Creating a PR

Pre-flight (mandatory)

1. Run testing skill checklist — all checks must pass
2. Verify branch is rebased on latest main (git-workflow skill)
3. Verify only expected files changed: git diff --name-only origin/main

PR Creation

Tool priority:

1. MCP (preferred): create_pull_request(owner, repo, title, head, base, body)
2. CLI fallback:

   gh pr create --title "type: description (#issue)" \
     --body-file .agents/issues/{n}/pr_body.md \
     --label "{type}" \
     --milestone "{milestone}" \
     --assignee "@me"

Rules:

• Follow .github/PULL_REQUEST_TEMPLATE.md structure
• Title format: type: description (#issue) — max 70 chars
• Always include: Closes #{issue} in body
• Set labels, milestone, assignees
• Create as draft until CI passes, then mark ready
• Never inline PR body in bash command — use --body-file or MCP
• Never commit scratch files (pr_body.md) — delete after use or keep in .agents/issues/

Reading Review Feedback

Read ALL review data — never skip inline comments:

Tool priority:

1. MCP (preferred):

   pull_request_read(method="get_review_comments")  # inline code comments
   pull_request_read(method="get_reviews")          # review summaries
   pull_request_read(method="get_comments")         # general PR comments

2. CLI fallback:

   gh api repos/{owner}/{repo}/pulls/{number}/comments  # inline
   gh api repos/{owner}/{repo}/pulls/{number}/reviews   # summaries
   gh pr view {number} --json comments                  # general

Addressing Feedback

1. Read ALL comments (inline + general + review summaries)
2. Categorize:
   • 🛑 Blocking (changes requested) — fix first
   • ⚠️ Suggestions — apply if reasonable
   • 💬 Nits — fix or acknowledge
3. For each addressed comment: reply explaining what was done
4. Re-run testing skill checklist
5. Push fixes
6. Re-request review (separate comments):

Requesting Q review:

/q review
Addressed feedback: {summary of changes}

Requesting Gemini review:

@gemini-code-assist review
Addressed feedback: {summary of changes}

Important: These MUST be separate comments. /q must be the first line.

Agent Signature

End every PR comment with:

---
🤖 *{agent-name}* using *{model}* | {timestamp}

Merging

• Only merge when CI green + reviewers approved
• Use squash merge for single-feature PRs
• Add skip-docker label for docs/test-only PRs (skips Docker build in CI)