agentleFS
dominionismdominionism/Playbook/skills/assess/SKILL.md

assess

Skill0 starsChanged 2 months agoMITView on GitHub

Review a GitHub pull request at the ceiling of clarity. Use when the user explicitly asks to assess a PR; trace the actual change, produce Story/Delta/Focus visuals, draft findings and a verdict, and never post without approval.

13 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use verify.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Microsoft AzureSkill

    verify

    End-to-end app testing pipeline for browser-based web apps on cloud browsers via Azure Playwright Workspaces: verify the live app, author tests for working flows, heal failing tests, then re-run with video and produce one consolidated report. Three phases (app verification, test authoring, test healing) plus a scoped final sanity run; each phase emits a sub-report. Use when asked to "verify my app", "make sure my app works and has good test coverage", "do a full QA pass", "add tests where I'm missing coverage", "fix failing tests and add new ones", "smoke test before deploy", "QA my deployment", or any combined verify-and-test ask. Requires Azure CLI (`az login`) and a Playwright Workspace resource ID — bootstraps configs on first invocation. Browser-based web apps with Playwright only — not for unit/API tests, native mobile/desktop, load/perf, or full accessibility audits.

    Also in 4 projects that use this

The file

We split this skill into the rules it gives an agent

10 rules. 0 are common, 8 are distinctive, and 2 are very specific to this project.

  • 0

    Common

    Most of the 13 edited versions we read keep these.

  • 8

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Never attribute the review to any tool, CLI, or AI.

    line 9
  2. Distinctive:

    Treat the request supplied with this skill invocation as the PR number, URL, or head branch.

    line 11
  3. Distinctive:

    If the arguments name a PR (number, URL, or head branch), use it.

    line 17
  4. Very specific:

    Only gh pr checkout <n> when you genuinely need deeper exploration (running tests, LSP navigation) — and only if git status --short is …

    line 46
  5. Very specific:

    Size honesty: if the diff is too large to review honestly in one pass, say so before pretending otherwise.

    line 48
  6. Distinctive:

    Do the work the visuals and findings both depend on:

    line 52
  7. Distinctive:

    Read the full diff, then trace the changed flow end to end in the actual code at the PR head — entry point to final effect.

    line 54
  8. Distinctive:

    Read the tests the PR touches.

    line 55
  9. Distinctive:

    Questions are not findings: If you already know the answer is "this is wrong," it's a finding.

    line 104
  10. Distinctive:

    Ask what to do with it. Posting and verdict are the user's call, never yours.

    line 110

“Common” is measured: kept by at least 6 in 10 of the 13 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Produce the PR review a senior engineer would be proud to sign: one document that teaches the reader how the changed system works, shows exactly what moved, says where the risk lives, and states a verdict with reasons. The review is drafted locally and shown in full; nothing reaches GitHub until explicitly approved.

Never attribute the review to any tool, CLI, or AI. The reviewer is whoever GitHub says you are.

Treat the request supplied with this skill invocation as the PR number, URL, or head branch. It may be empty; if so, identify the PR per §1.


1. Identify the PR

If the arguments name a PR (number, URL, or head branch), use it. If they don't:

gh pr list --state open --limit 20

Show the list and ask which one. Never guess — reviewing the wrong PR wastes everyone's time and posting to it is worse.

/assess works on a peer's PR or your own. Note: GitHub does not allow approving or requesting changes on your own PR — a self-assess is a pre-flight quality pass, and its only postable form is a comment.

2. Fetch the PR — all of it

gh pr view <n> --json number,title,body,author,baseRefName,headRefName,isDraft,additions,deletions,changedFiles,url
gh pr view <n> --comments
gh pr diff <n>
  • The body is the author's claim about what the PR does. You will verify it.
  • The comments and existing reviews are prior art. Do not repeat a point already raised — reference or extend it.
  • The diff is the ground truth. Read every hunk. If the PR is a draft, note it — the bar for polish findings drops, the bar for direction findings doesn't.

To read files as they exist at the PR head without disturbing the working tree:

git fetch origin pull/<n>/head
git show FETCH_HEAD:path/to/file.ts

Only gh pr checkout <n> when you genuinely need deeper exploration (running tests, LSP navigation) — and only if git status --short is clean. Say so before switching branches, and switch back after.

Size honesty: if the diff is too large to review honestly in one pass, say so before pretending otherwise. Offer to review commit-by-commit, or recommend the author split it — the same atomicity bar /pr applies when authoring.

3. Understand the change

Do the work the visuals and findings both depend on:

  • Read the full diff, then trace the changed flow end to end in the actual code at the PR head — entry point to final effect. This trace is what the Story will draw; don't draw what you didn't walk.
  • Read the tests the PR touches. Note behavior that changed without a test changing — that gap is a finding.
  • If the repo has durable context, use it: Context/ADR/*.md — a change that contradicts a settled ADR is a finding with the ADR cited; Context/Glossary.md — new code that drifts from canonical terms is a (minor) finding; Context/Plans/ — if the PR implements a plan, check the work items it claims.
  • Compare what the code does against what the PR body says it does. A mismatch is finding #1, whichever direction it runs.

4. Produce the visuals

Activate the installed visuals skill and follow it in review mode. It yields:

  • The Story — the changed flow end to end as it will work post-merge, ✱ marks on what the PR touched, ⚠ marks on the 1–3 places to look hardest, and the plain-language walkthrough.
  • The Delta — the compact before/after of the neighborhood that moved.
  • The Focus notes — one line per ⚠ naming the specific invariant or edge case at risk.

The engine's floor applies here too: a docs-only PR gets no diagrams, and the review says why in one line.

5. Draft the review

Assemble this structure. Omit a section only when it's genuinely empty — never write "N/A":

## What this PR does
<two to four plain sentences, written for someone who hasn't read the diff.
If this summary contradicts the PR's own description, that mismatch is finding #1.>

## How it works now
<the Story: diagram, legend, walkthrough — from /visuals review mode>

## What changed
<the Delta with its caption>

## Where to look hardest
<one line per ⚠, from the Focus notes>

## Findings
<ordered by severity: correctness > design & ADR conflicts > missing tests > clarity.
Each: `path/to/file.ts:<line>` — what's wrong, why it matters, and a concrete suggestion.
If nothing survives scrutiny: "No blocking findings.">

## Questions
<genuine questions — things you actually don't know, not findings wearing a question mark>

## Verdict
<approve | comment | request changes — with a one-line justification>

Rules for findings:

  • Findings target code, never the author. Neutral phrasing, concrete suggestion attached — a finding without a proposed direction is half a finding.
  • Severity order is the sort order. The one correctness bug outranks nine naming nits; never bury it.
  • No nit blizzards. Batch style-level observations into one finding or drop them. If a linter should have caught it, say that once.
  • Questions are not findings. If you already know the answer is "this is wrong," it's a finding. If you genuinely don't know, it's a question.
  • Verdict discipline. request changes requires at least one correctness- or design-severity finding. approve requires zero unresolved correctness findings. Everything else is comment.

6. Deliver, then post only on approval

  1. Show the full draft — every section, diagrams inline.
  2. Ask what to do with it. Posting and verdict are the user's call, never yours. Do not post, and especially do not approve or request changes, without the user explicitly choosing.
  3. On approval, post with a here-doc (Mermaid renders in review bodies):
gh pr review <n> --comment --body-file - <<'EOF'
<full markdown review>
EOF

Substitute --approve or --request-changes only for the user's explicitly chosen verdict. If posting fails (auth, permissions, ruleset), report the failure verbatim and stop.


Anti-patterns

  • The rubber stamp. "LGTM, nice work" with no evidence anything was read. If the review could have been written without the diff, it isn't a review.
  • The nit blizzard. Twenty comma-level comments burying the one transaction-boundary bug. Severity order exists to prevent exactly this.
  • Restating the diff. "This PR changes foo.ts and adds bar()" — the Files tab already says that. Findings and the Story say what the diff means.
  • Reviewing the intention. Judging the PR body's description instead of the code. Verify the claim; the mismatch is the finding.
  • Posting without approval. A review is outward-facing with an audience. The draft is yours; the send button is the user's.
  • Verdict inflation. Approving with a known correctness hole, or requesting changes over style. The verdict rules in §5 are hard.
  • Repeating prior reviewers. A point already raised gets a reference, not a duplicate.
  • Tool attribution. Any Generated with / agent credit. None. Ever.

Workflow

Before this command: an open PR exists — a peer's, or your own as a pre-flight pass before requesting review. /pr produces the artifact /assess evaluates; the two share the /visuals engine and the same clarity bar.

After this command:

  • Findings on your own PR → fix, /commit, and let /pr refresh the body; re-run /assess if the change was structural.
  • A finding that exposed a hard-to-reverse decision → /grill to capture it as an ADR.
  • A concept surfaced during review worth keeping → /record.
  • Stepping away mid-review-cycle → /handoff; resume with /recall.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.