agentleFS
dimastrianndimastriann/odoo-erp-mcp/.agents/skills/security-review/SKILL.md

security-review

Skill3 starsChanged 9 days agoMITView on GitHub

Use before committing changes that touch authentication, authorization, secrets, audit, redaction, Odoo RPC, or request validation. Reviews secret leakage, default-deny policy, query protection, and mutation safeguards.

191 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use dependency-cve-sweep, fleet-standard-adoption and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • berntpoppSkill

    dependency-cve-sweep

    Use when handling Dependabot PRs, CodeQL/Trivy alerts, or doing a routine dependency/CVE sweep for this repo.

    Also in 12 projects that use this

  • berntpoppSkill

    fleet-standard-adoption

    Use when bringing this repo into compliance with a GeneFoundry fleet standard (tool-naming, response-envelope, container-hardening, versioning, MCP transport, or logging) or closing its tracking issue.

    Also in 12 projects that use this

  • xfstudioSkill

    linkerd-patterns

    Implement Linkerd service mesh patterns for lightweight, security-focused service mesh deployments. Use when setting up Linkerd, configuring traffic policies, or implementing zero-trust networking with minimal overhead.

    Also in 6 projects that use this

  • xfstudioSkill

    team-composition-analysis

    This skill should be used when the user asks to "plan team

    Also in 5 projects that use this

  • HABUBUSSSkill

    project-guidelines-example

    Also in 16 projects that use this

  • niloykumarbarmanSkill

    agent-sort

    Build an evidence-backed ECC install plan for a specific repo by sorting skills, commands, rules, hooks, and extras into DAILY vs LIBRARY buckets using parallel repo-aware review passes. Use when ECC should be trimmed to what a project actually needs instead of loading the full bundle.

    Also in 13 projects that use this

  • +2 more from berntpopp

The file

We split this skill into the rules it gives an agent

10 rules. 0 are common, 7 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 163 edited versions we read keep these.

  • 7

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Never log, serialize, return, or put credentials in errors, audit details, metrics, or UI responses.

    line 16
  2. Distinctive:

    Check tests still assert that canary values never appear in responses.

    line 20
  3. Very specific:

    Keep policy default-deny when permissions is enabled.

    line 24
  4. Distinctive:

    Do not add allow rules, legacy-mode shortcuts, or test-only bypasses to make a test pass.

    line 30
  5. Distinctive:

    Never retry a mutation automatically.

    line 48
  6. Very specific:

    Keep authentication on every admin /api route.

    line 56
  7. Very specific:

    Do not disable TLS or HTTPS warnings, and keep ODOO_MCP_UI_BIND local-only by default.

    line 59
  8. Distinctive:

    Keep response-size limits and timeouts enforced.

    line 61
  9. Distinctive:

    Add regression tests for every security boundary changed.

    line 65
  10. Distinctive:

    Run the full quality gate from AGENTS.md.

    line 66

“Common” is measured: kept by at least 6 in 10 of the 163 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Security Review

AGENTS.md is the canonical rule set. Run this review before committing any change that touches a trust boundary.

1. Secrets and credentials

  • SecretString must keep redacted Debug and Serialize.
  • Environment-backed credentials stay in password_env; resolved values are never written back to config.json.
  • Never log, serialize, return, or put credentials in errors, audit details, metrics, or UI responses.
  • redacted_config_value must keep returning an empty password and has_password instead of the secret.
  • Check tests still assert that canary values never appear in responses.

2. Authorization

  • Keep policy default-deny when permissions is enabled.
  • Preserve precedence: field and method, operation, model, instance, then global.
  • Deny must win over allow in the same scope.
  • requires_model, requires_client, capability mapping, and operation identity must match the tool being executed.
  • Do not add allow rules, legacy-mode shortcuts, or test-only bypasses to make a test pass.
  • Reject unknown or conflicting policy input before saving it.

3. Input and query protection

  • Domains are parsed as nested clauses with allowed operators and prefix logical operators; no raw Odoo domain strings.
  • Enforce max_domain_depth, max_domain_terms, max_domain_in_values, max_requested_fields, max_read_ids, max_query_limit, and max_response_records.
  • Validate order clauses; reject injection and unsupported tokens.
  • Reject malformed input before it reaches Odoo.

4. Mutations and audit

  • Mutations still require preview, risk classification, approval when needed, idempotency, single execution, verification, and audit.
  • Never retry a mutation automatically.
  • Audit details are redacted and truncated; hash-chain verification must keep working.
  • Approval and idempotency state transitions must remain guarded.

5. Session and transport

  • UI sessions use HttpOnly, SameSite=Strict cookies.
  • Keep authentication on every admin /api route; only /, static assets, /health, /ready, /api/version, /api/login, and /api/logout stay public.
  • Do not disable TLS or HTTPS warnings, and keep ODOO_MCP_UI_BIND local-only by default.
  • Keep response-size limits and timeouts enforced.

6. Tests and review

  • Add regression tests for every security boundary changed.
  • Run the full quality gate from AGENTS.md.
  • Review the staged diff specifically for secrets, debug output, and weakened defaults before committing.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.