agentleFS
desbmadesbma/agent-skills/review-correctness/SKILL.md

review-correctness

Skill1 starsChanged 16 days agoMITView on GitHub

Review Jujutsu revision changes from jj show and report correctness and completeness defects.

6 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use review-architecture.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • MrCipherSmithSkill

    review-architecture

    Use when: reviewing code for architectural violations — layer violations, dependency direction mistakes, module boundary coupling, SOLID principle breaches, NestJS module/provider structure, React MVVM boundary violations, or MobX store layer misplacement. Triggered by: "review architecture", "check architecture", "architectural review", or dispatched by review-orchestrator with --architecture or --backend. NOT for: style/naming preferences, logic correctness bugs, or security vulnerabilities.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 4 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 6 edited versions we read keep these.

  • 4

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Follow the common review instructions: @../review-common.md

    line 12
  2. Distinctive:

    does not do what it is meant to do: wrong logic, inverted condition, off by one, misused API

    line 18
  3. Distinctive:

    Only report a defect if you can describe the concrete scenario that triggers it, and its consequence

    line 27
  4. Distinctive:

    Do not report a bare suspicion: either exhibit the triggering input, or name what blocked you from confirming it

    line 28

“Common” is measured: kept by at least 6 in 10 of the 6 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Review correctness of Jujutsu changes

Review the Jujutsu changes for the target revision, and report defects that make the code behave incorrectly or incompletely.

Follow the common review instructions: @../review-common.md

Main goals

Take the revision description and the surrounding code as the statement of intent, and find code that:

  • does not do what it is meant to do: wrong logic, inverted condition, off by one, misused API
  • breaks on states it should handle: edge case, empty or missing value, overflow, concurrent access
  • silently ignores an error or abnormal condition instead of surfacing it
  • is incomplete: unhandled case, code path left unimplemented, change applied in one place but not in its siblings
  • reaches for a fragile or suboptimal pattern when a sound alternative exists: a polling loop with a sleep call where an event, condition variable or blocking wait would do
  • carries algorithmic complexity that can explode at runtime on realistic inputs when a lower complexity alternative exists: a quadratic scan inside a loop where a set lookup or precomputed index would do

Guidelines

  • Only report a defect if you can describe the concrete scenario that triggers it, and its consequence
  • Do not report a bare suspicion: either exhibit the triggering input, or name what blocked you from confirming it
  • Flag algorithmic complexity only when a realistic input can make its cost explode and a better alternative exists; small performance micro optimizations are out of scope
  • Stay on correctness: readability, documentation and test coverage are covered by other review domains

Severity

Anchor severity to what the defect does when it triggers:

  • critical — data loss, corruption, a crash, a hang or a security hole on a path ordinary use reaches
  • major — a wrong result or a stall on a plausible input
  • minor — a defect whose trigger is far-fetched or whose consequence the caller absorbs

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.